Title: [90376] trunk/Source/WebCore
- Revision
- 90376
- Author
- [email protected]
- Date
- 2011-07-04 13:28:13 -0700 (Mon, 04 Jul 2011)
Log Message
2011-07-04 Vsevolod Vlasov <[email protected]>
ResourceLoadNotifier::dispatchWillSendRequest should not compare StringImpl directly
https://bugs.webkit.org/show_bug.cgi?id=63873
Reviewed by Alexey Proskuryakov.
* loader/ResourceLoadNotifier.cpp:
(WebCore::ResourceLoadNotifier::dispatchWillSendRequest):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (90375 => 90376)
--- trunk/Source/WebCore/ChangeLog 2011-07-04 20:26:37 UTC (rev 90375)
+++ trunk/Source/WebCore/ChangeLog 2011-07-04 20:28:13 UTC (rev 90376)
@@ -1,3 +1,13 @@
+2011-07-04 Vsevolod Vlasov <[email protected]>
+
+ ResourceLoadNotifier::dispatchWillSendRequest should not compare StringImpl directly
+ https://bugs.webkit.org/show_bug.cgi?id=63873
+
+ Reviewed by Alexey Proskuryakov.
+
+ * loader/ResourceLoadNotifier.cpp:
+ (WebCore::ResourceLoadNotifier::dispatchWillSendRequest):
+
2011-07-04 Sheriff Bot <[email protected]>
Unreviewed, rolling out r90373.
Modified: trunk/Source/WebCore/loader/ResourceLoadNotifier.cpp (90375 => 90376)
--- trunk/Source/WebCore/loader/ResourceLoadNotifier.cpp 2011-07-04 20:26:37 UTC (rev 90375)
+++ trunk/Source/WebCore/loader/ResourceLoadNotifier.cpp 2011-07-04 20:28:13 UTC (rev 90376)
@@ -107,13 +107,13 @@
void ResourceLoadNotifier::dispatchWillSendRequest(DocumentLoader* loader, unsigned long identifier, ResourceRequest& request, const ResourceResponse& redirectResponse)
{
- StringImpl* oldRequestURL = request.url().string().impl();
+ String oldRequestURL = request.url().string();
m_frame->loader()->documentLoader()->didTellClientAboutLoad(request.url());
m_frame->loader()->client()->dispatchWillSendRequest(loader, identifier, request, redirectResponse);
// If the URL changed, then we want to put that new URL in the "did tell client" set too.
- if (!request.isNull() && oldRequestURL != request.url().string().impl())
+ if (!request.isNull() && oldRequestURL != request.url().string())
m_frame->loader()->documentLoader()->didTellClientAboutLoad(request.url());
InspectorInstrumentation::willSendRequest(m_frame, identifier, loader, request, redirectResponse);
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
