[webkit-changes] [90393] trunk/Source/WebCore

Tue, 05 Jul 2011 05:51:07 -0700

Title: [90393] trunk/Source/WebCore
Revision
90393
Author
[email protected]
Date
2011-07-05 05:50:58 -0700 (Tue, 05 Jul 2011)

Log Message

2011-07-05  Andrey Kosyakov  <[email protected]>

        Web Inspector: [refactoring] remove network-sidebar style, add network-log-grid
        https://bugs.webkit.org/show_bug.cgi?id=63913

        Reviewed by Yury Semikhatsky.

        * inspector/front-end/NetworkPanel.js:
        (WebInspector.NetworkPanel):
        (WebInspector.NetworkPanel.prototype._createTable):
        * inspector/front-end/networkPanel.css:
        (.network-log-grid):
        (.network-log-grid table.data):
        (.network-log-grid.small table.data):
        (.network-log-grid td):
        (.network-log-grid.small td):
        (.network-log-grid th):
        (.network-log-grid.small th):
        (.network-log-grid th, .network.panel .data-grid th.sort-descending, .network.panel .data-grid th.sort-ascending):
        (.network-log-grid .data-container):
        (.network-log-grid.small .data-container):
        (.network-log-grid select):
        (.network-log-grid.small tr.offscreen):
        (.network-log-grid tr.offscreen):
        (.network-log-grid tr.offscreen td):
        (.network-log-grid tr.filler):
        (.network-log-grid tr:not(.filler) td.name-column):
        (.network.panel:not(.viewing-resource) .network-log-grid td.name-column:hover):
        (.network-log-grid td.time-column):
        (.network-log-grid.small .network-graph-side):
        (.network-log-grid th.sortable:active):
        (.network-log-grid tr.selected .network-cell-subtitle):
        (.network-log-grid .icon):
        (.network-log-grid.small .icon):
        (.network-log-grid .network-category-scripts .icon):
        (.network-log-grid.small .network-category-scripts .icon):
        (.network-log-grid .network-category-documents .icon):
        (.network-log-grid.small .network-category-documents .icon):
        (.network-log-grid .network-category-stylesheets .icon):
        (.network-log-grid.small .network-category-stylesheets .icon):
        (.network-log-grid .network-category-images .icon):
        (.network-log-grid.small .network-category-images .icon):
        (.network-log-grid .image-network-icon-preview):
        (.network-log-grid.small .image-network-icon-preview):
        (.network-timeline-grid.small .network-event-divider):
        (.network-log-grid .resources-dividers):
        (.network-log-grid .resources-dividers-label-bar):
        (.network-timeline-grid.small .resources-dividers-label-bar):
        (.network-timeline-grid .resources-divider-label):
        (.network-timeline-grid .resources-dividers-label-bar .resources-divider):
        (.network-timeline-grid.small .resources-dividers-label-bar .resources-divider):
        (.network-timeline-grid .resources-divider.first .resources-divider-label):
        (.network-timeline-grid .resources-dividers-label-bar .resources-divider.first):
        (.network-timeline-grid tr.filler td):
        (.network-summary-bar td):
        (.network.panel.viewing-resource .network-log-grid th):
        (.network-log-grid.full-grid-mode .viewer-column):
        (.network-log-grid.brief-grid-mode .time-column):
        (.network-log-grid.viewing-resource-mode .timeline-column):
        (.network.panel .sidebar):
        (.network.panel.viewing-resource .network-log-grid .data-grid-resizer):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (90392 => 90393)


--- trunk/Source/WebCore/ChangeLog	2011-07-05 12:49:20 UTC (rev 90392)
+++ trunk/Source/WebCore/ChangeLog	2011-07-05 12:50:58 UTC (rev 90393)
@@ -1,3 +1,65 @@
+2011-07-05  Andrey Kosyakov  <[email protected]>
+
+        Web Inspector: [refactoring] remove network-sidebar style, add network-log-grid
+        https://bugs.webkit.org/show_bug.cgi?id=63913
+
+        Reviewed by Yury Semikhatsky.
+
+        * inspector/front-end/NetworkPanel.js:
+        (WebInspector.NetworkPanel):
+        (WebInspector.NetworkPanel.prototype._createTable):
+        * inspector/front-end/networkPanel.css:
+        (.network-log-grid):
+        (.network-log-grid table.data):
+        (.network-log-grid.small table.data):
+        (.network-log-grid td):
+        (.network-log-grid.small td):
+        (.network-log-grid th):
+        (.network-log-grid.small th):
+        (.network-log-grid th, .network.panel .data-grid th.sort-descending, .network.panel .data-grid th.sort-ascending):
+        (.network-log-grid .data-container):
+        (.network-log-grid.small .data-container):
+        (.network-log-grid select):
+        (.network-log-grid.small tr.offscreen):
+        (.network-log-grid tr.offscreen):
+        (.network-log-grid tr.offscreen td):
+        (.network-log-grid tr.filler):
+        (.network-log-grid tr:not(.filler) td.name-column):
+        (.network.panel:not(.viewing-resource) .network-log-grid td.name-column:hover):
+        (.network-log-grid td.time-column):
+        (.network-log-grid.small .network-graph-side):
+        (.network-log-grid th.sortable:active):
+        (.network-log-grid tr.selected .network-cell-subtitle):
+        (.network-log-grid .icon):
+        (.network-log-grid.small .icon):
+        (.network-log-grid .network-category-scripts .icon):
+        (.network-log-grid.small .network-category-scripts .icon):
+        (.network-log-grid .network-category-documents .icon):
+        (.network-log-grid.small .network-category-documents .icon):
+        (.network-log-grid .network-category-stylesheets .icon):
+        (.network-log-grid.small .network-category-stylesheets .icon):
+        (.network-log-grid .network-category-images .icon):
+        (.network-log-grid.small .network-category-images .icon):
+        (.network-log-grid .image-network-icon-preview):
+        (.network-log-grid.small .image-network-icon-preview):
+        (.network-timeline-grid.small .network-event-divider):
+        (.network-log-grid .resources-dividers):
+        (.network-log-grid .resources-dividers-label-bar):
+        (.network-timeline-grid.small .resources-dividers-label-bar):
+        (.network-timeline-grid .resources-divider-label):
+        (.network-timeline-grid .resources-dividers-label-bar .resources-divider):
+        (.network-timeline-grid.small .resources-dividers-label-bar .resources-divider):
+        (.network-timeline-grid .resources-divider.first .resources-divider-label):
+        (.network-timeline-grid .resources-dividers-label-bar .resources-divider.first):
+        (.network-timeline-grid tr.filler td):
+        (.network-summary-bar td):
+        (.network.panel.viewing-resource .network-log-grid th):
+        (.network-log-grid.full-grid-mode .viewer-column):
+        (.network-log-grid.brief-grid-mode .time-column):
+        (.network-log-grid.viewing-resource-mode .timeline-column):
+        (.network.panel .sidebar):
+        (.network.panel.viewing-resource .network-log-grid .data-grid-resizer):
+
 2011-07-05  Alexandru Chiculita  <[email protected]>
 
         Reviewed by Simon Hausmann.

Modified: trunk/Source/WebCore/inspector/front-end/NetworkPanel.js (90392 => 90393)


--- trunk/Source/WebCore/inspector/front-end/NetworkPanel.js	2011-07-05 12:49:20 UTC (rev 90392)
+++ trunk/Source/WebCore/inspector/front-end/NetworkPanel.js	2011-07-05 12:50:58 UTC (rev 90393)
@@ -39,7 +39,6 @@
     WebInspector.Panel.call(this, "network");
 
     this.createSidebar();
-    this.sidebarElement.className = "network-sidebar";
 
     this._resources = [];
     this._resourcesById = {};
@@ -187,6 +186,7 @@
 
         this._dataGrid = new WebInspector.DataGrid(columns);
         this._dataGrid.resizeMethod = WebInspector.DataGrid.ResizeMethod.Last;
+        this._dataGrid.element.addStyleClass("network-log-grid");
         this._dataGrid.element.addEventListener("contextmenu", this._contextMenu.bind(this), true);
         this.containerElement.appendChild(this._dataGrid.element);
         this._dataGrid.addEventListener("sorting changed", this._sortItems, this);

Modified: trunk/Source/WebCore/inspector/front-end/networkPanel.css (90392 => 90393)


--- trunk/Source/WebCore/inspector/front-end/networkPanel.css	2011-07-05 12:49:20 UTC (rev 90392)
+++ trunk/Source/WebCore/inspector/front-end/networkPanel.css	2011-07-05 12:50:58 UTC (rev 90393)
@@ -2,7 +2,7 @@
     -webkit-mask-position: -224px 0;
 }
 
-.network-sidebar .data-grid {
+.network-log-grid {
     border: none;
     position: absolute;
     top: 0;
@@ -12,51 +12,51 @@
     font-size: 11px;
 }
 
-.network-sidebar .data-grid table.data {
+.network-log-grid table.data {
     -webkit-background-size: 1px 82px;
     background-image: -webkit-gradient(linear, left top, left bottom, from(rgba(0, 0, 0, 0)), color-stop(0.5, rgba(0, 0, 0, 0)), color-stop(0.5, rgba(0, 0, 0, 0.05)), to(rgba(0, 0, 0, 0.05)));
     font-size: 11px;
 }
 
-.network-sidebar .data-grid.small table.data {
+.network-log-grid.small table.data {
     -webkit-background-size: 1px 42px;
 }
 
-.network-sidebar .data-grid td {
+.network-log-grid td {
     line-height: 17px;
     height: 37px;
     border-right: 1px solid rgb(210, 210, 210);
     vertical-align: middle;
 }
 
-.network-sidebar .data-grid.small td {
-    height: 17px;
+.network-log-grid.small td {
+    height: 17px !important;
 }
 
-.network-sidebar .data-grid th {
+.network-log-grid th {
     border-bottom: 1px solid rgb(64%, 64%, 64%);
     height: 30px;
     font-size: 11px;
     font-weight: bold;
 }
 
-.network-sidebar .data-grid.small th {
+.network-log-grid.small th {
     height: 22px;
 }
 
-.network-sidebar .data-grid th, .network.panel .data-grid th.sort-descending, .network.panel .data-grid th.sort-ascending {
+.network-log-grid th, .network.panel .data-grid th.sort-descending, .network.panel .data-grid th.sort-ascending {
     background: -webkit-gradient(linear, left top, left bottom, from(rgb(236, 236, 236)), to(rgb(217, 217, 217)));
 }
 
-.network-sidebar .data-grid .data-container {
+.network-log-grid .data-container {
     top: 31px;
 }
 
-.network-sidebar .data-grid.small .data-container {
+.network-log-grid.small .data-container {
     top: 23px;
 }
 
-.network-sidebar .data-grid select {
+.network-log-grid select {
     -webkit-appearance: none;
     background-color: transparent;
     border: none;
@@ -65,49 +65,49 @@
     font-weight: bold;
 }
 
-.network-sidebar .data-grid.small tr.offscreen {
+.network-log-grid.small tr.offscreen {
     height: 21px;
 }
 
-.network-sidebar .data-grid tr.offscreen {
+.network-log-grid tr.offscreen {
     height: 41px;
 }
 
-.network-sidebar .data-grid tr.offscreen td {
+.network-log-grid tr.offscreen td {
     display: none;
 }
 
-.network-sidebar .data-grid tr.filler {
+.network-log-grid tr.filler {
     background-color: white;
 }
 
-.network-sidebar .data-grid tr:not(.filler) td.name-column {
+.network-log-grid tr:not(.filler) td.name-column {
     font-weight: bold;
     cursor: pointer;
 }
 
-.network.panel:not(.viewing-resource) .network-sidebar td.name-column:hover {
+.network.panel:not(.viewing-resource) .network-log-grid td.name-column:hover {
     text-decoration: underline;
 }
 
-.network-sidebar .data-grid td.method-column,
-.network-sidebar .data-grid td.status-column,
-.network-sidebar .data-grid td.type-column,
-.network-sidebar .data-grid td.size-column,
-.network-sidebar .data-grid td.time-column {
+.network-log-grid td.method-column,
+.network-log-grid td.status-column,
+.network-log-grid td.type-column,
+.network-log-grid td.size-column,
+.network-log-grid td.time-column {
     background-color: rgba(0, 0, 0, 0.07);
 }
 
-.network-sidebar .data-grid td.size-column,
-.network-sidebar .data-grid td.time-column {
+.network-log-grid td.size-column,
+.network-log-grid td.time-column {
     text-align: right;
 }
 
-.network-sidebar .small .network-graph-side {
+.network-log-grid.small .network-graph-side {
     height: 14px;
 }
 
-.network-sidebar .data-grid th.sortable:active {
+.network-log-grid th.sortable:active {
     background-image: none;
 }
 
@@ -116,7 +116,7 @@
     color: gray;
 }
 
-.network-sidebar tr.selected .network-cell-subtitle {
+.network-log-grid tr.selected .network-cell-subtitle {
     color: white;
 }
 
@@ -124,59 +124,59 @@
     color: gray;
 }
 
-.network-sidebar .data-grid.small .network-cell-subtitle,
-.network-sidebar .data-grid.small .network-header-subtitle
+.network-log-grid.small .network-cell-subtitle,
+.network-log-grid.small .network-header-subtitle
 {
     display: none;
 }
 
 /* Resource preview icons */
 
-.network-sidebar .data-grid .icon {
+.network-log-grid .icon {
     content: url(Images/resourcePlainIcon.png);
 }
 
-.network-sidebar .data-grid.small .icon {
+.network-log-grid.small .icon {
     content: url(Images/resourcePlainIconSmall.png);
 }
 
-.network-sidebar .network-category-scripts .icon {
+.network-log-grid .network-category-scripts .icon {
     content: url(Images/resourceJSIcon.png);
 }
 
-.network-sidebar .data-grid.small .network-category-scripts .icon {
+.network-log-grid.small .network-category-scripts .icon {
     content: url(Images/resourceDocumentIconSmall.png);
 }
 
-.network-sidebar .network-category-documents .icon {
+.network-log-grid .network-category-documents .icon {
     content: url(Images/resourceDocumentIcon.png);
 }
 
-.network-sidebar .data-grid.small .network-category-documents .icon {
+.network-log-grid.small .network-category-documents .icon {
     content: url(Images/resourceDocumentIconSmall.png);
 }
 
-.network-sidebar .network-category-stylesheets .icon {
+.network-log-grid .network-category-stylesheets .icon {
     content: url(Images/resourceCSSIcon.png);
 }
 
-.network-sidebar .data-grid.small .network-category-stylesheets .icon {
+.network-log-grid.small .network-category-stylesheets .icon {
     content: url(Images/resourceDocumentIconSmall.png);
 }
 
-.network-sidebar .network-category-images .icon {
+.network-log-grid .network-category-images .icon {
     position: relative;
     background-image: url(Images/resourcePlainIcon.png);
     background-repeat: no-repeat;
     content: "";
 }
 
-.network-sidebar .data-grid.small .network-category-images .icon {
+.network-log-grid.small .network-category-images .icon {
     background-image: url(Images/resourcePlainIconSmall.png);
     content: "";
 }
 
-.network-sidebar .data-grid .icon {
+.network-log-grid .icon {
     float: left;
     width: 32px;
     height: 32px;
@@ -184,12 +184,12 @@
     margin-right: 3px;
 }
 
-.network-sidebar .data-grid.small .icon {
+.network-log-grid.small .icon {
     width: 16px;
     height: 16px;
 }
 
-.network-sidebar .image-network-icon-preview {
+.network-log-grid .image-network-icon-preview {
     position: absolute;
     margin: auto;
     top: 3px;
@@ -202,7 +202,7 @@
     min-height: 1px;
 }
 
-.network-sidebar .data-grid.small .image-network-icon-preview {
+.network-log-grid.small .image-network-icon-preview {
     top: 2px;
     bottom: 1px;
     left: 3px;
@@ -424,7 +424,7 @@
     z-index: 300;
 }
 
-.network-sidebar .network-timeline-grid.small .network-event-divider {
+.network-timeline-grid.small .network-event-divider {
     top: 23px;
 }
 
@@ -436,40 +436,40 @@
     background-color: rgba(0, 0, 255, 0.5);
 }
 
-.network-sidebar .resources-dividers {
+.network-log-grid .resources-dividers {
     z-index: 0;
 }
 
-.network-sidebar .resources-dividers-label-bar {
+.network-log-grid .resources-dividers-label-bar {
     background-color: transparent;
     border: none;
     height: 30px;
     pointer-events: none;
 }
 
-.network-sidebar .network-timeline-grid.small .resources-dividers-label-bar {
+.network-timeline-grid.small .resources-dividers-label-bar {
     height: 23px;
 }
 
-.network-sidebar .resources-divider-label {
+.network-timeline-grid .resources-divider-label {
     top: 0px;
     margin-top: -4px;
     color: black;
 }
 
-.network-sidebar .resources-dividers-label-bar .resources-divider {
+.network-timeline-grid .resources-dividers-label-bar .resources-divider {
     top: 23px;
 }
 
-.network-sidebar .network-timeline-grid.small .resources-dividers-label-bar .resources-divider {
+.network-timeline-grid.small .resources-dividers-label-bar .resources-divider {
     top: 15px;
 }
 
-.network-sidebar .resources-divider.first .resources-divider-label {
+.network-timeline-grid .resources-divider.first .resources-divider-label {
     display: none;
 }
 
-.network-sidebar .resources-dividers-label-bar .resources-divider.first {
+.network-timeline-grid .resources-dividers-label-bar .resources-divider.first {
     background-color: transparent;
 }
 
@@ -496,7 +496,7 @@
 
 /* Summary */
 
-.network-sidebar tr.filler td {
+.network-timeline-grid tr.filler td {
     padding-bottom: 20px !important;
 }
 
@@ -509,7 +509,7 @@
     background-color: rgb(101, 111, 130);
 }
 
-.network-sidebar .data-grid .network-summary-bar td {
+.network-summary-bar td {
     color: white;
     height: 20px;
     border: none;
@@ -528,8 +528,8 @@
 
 /* Viewer */
 
-.network.panel.viewing-resource .network-sidebar .data-grid td,
-.network.panel.viewing-resource .network-sidebar .data-grid th {
+.network.panel.viewing-resource .network-log-grid td,
+.network.panel.viewing-resource .network-log-grid th {
     border-right: none;
 }
 
@@ -592,16 +592,16 @@
 }
 
 
-.network-sidebar .data-grid.full-grid-mode .viewer-column {
+.network-log-grid.full-grid-mode .viewer-column {
     display: none;
 }
 
-.network-sidebar .data-grid.brief-grid-mode .viewer-column,
-.network-sidebar .data-grid.brief-grid-mode .method-column,
-.network-sidebar .data-grid.brief-grid-mode .status-column,
-.network-sidebar .data-grid.brief-grid-mode .type-column,
-.network-sidebar .data-grid.brief-grid-mode .size-column,
-.network-sidebar .data-grid.brief-grid-mode .time-column {
+.network-log-grid.brief-grid-mode .viewer-column,
+.network-log-grid.brief-grid-mode .method-column,
+.network-log-grid.brief-grid-mode .status-column,
+.network-log-grid.brief-grid-mode .type-column,
+.network-log-grid.brief-grid-mode .size-column,
+.network-log-grid.brief-grid-mode .time-column {
     display: none;
 }
 
@@ -609,28 +609,30 @@
     display: none;
 }
 
-.network-sidebar .data-grid.viewing-resource-mode .method-column,
-.network-sidebar .data-grid.viewing-resource-mode .status-column,
-.network-sidebar .data-grid.viewing-resource-mode .type-column,
-.network-sidebar .data-grid.viewing-resource-mode .size-column,
-.network-sidebar .data-grid.viewing-resource-mode .time-column,
-.network-sidebar .data-grid.viewing-resource-mode .timeline-column {
+.network-log-grid.viewing-resource-mode .method-column,
+.network-log-grid.viewing-resource-mode .status-column,
+.network-log-grid.viewing-resource-mode .type-column,
+.network-log-grid.viewing-resource-mode .size-column,
+.network-log-grid.viewing-resource-mode .time-column,
+.network-log-grid.viewing-resource-mode .timeline-column {
     display: none;
 }
 
-.network.panel .network-sidebar {
+.network.panel .sidebar {
     position: absolute;
     top: 0;
     bottom: 0;
     left: 0;
     right: 0;
+    width: auto;
+    border: none;
 }
 
 .network.panel:not(.viewing-resource) .sidebar-resizer-vertical {
     display: none;
 }
 
-.network.panel.viewing-resource .network-sidebar .data-grid-resizer {
+.network.panel.viewing-resource .network-log-grid .data-grid-resizer {
     display: none;
 }
 

_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to