Title: [90412] trunk/Tools
Revision
90412
Author
[email protected]
Date
2011-07-05 15:59:53 -0700 (Tue, 05 Jul 2011)

Log Message

2011-07-05  Eric Seidel  <[email protected]>

        new-run-webkit-tests fails to start http server if one is already running
        https://bugs.webkit.org/show_bug.cgi?id=63956

        Reviewed by Adam Barth.

        * BuildSlaveSupport/kill-old-processes:
         - Removed ^M line endings and sorted the process names.
         - There are no functional changes to this file.
           (except that now that its using unix line endings it can be executed directly!)
        * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
         - Change the name to 'httpd' to match old-run-webkit-test paths.

Modified Paths

Diff

Modified: trunk/Tools/BuildSlaveSupport/kill-old-processes (90411 => 90412)


--- trunk/Tools/BuildSlaveSupport/kill-old-processes	2011-07-05 22:54:50 UTC (rev 90411)
+++ trunk/Tools/BuildSlaveSupport/kill-old-processes	2011-07-05 22:59:53 UTC (rev 90412)
@@ -1,16 +1,16 @@
 #!/usr/bin/python
-
 # Copyright (C) 2010 Apple Inc.  All rights reserved.
+# Copyright (C) 2011 Google Inc.  All rights reserved.
 #
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions
 # are met:
 #
 # 1.  Redistributions of source code must retain the above copyright
-#     notice, this list of conditions and the following disclaimer. 
+#     notice, this list of conditions and the following disclaimer.
 # 2.  Redistributions in binary form must reproduce the above copyright
 #     notice, this list of conditions and the following disclaimer in the
-#     documentation and/or other materials provided with the distribution. 
+#     documentation and/or other materials provided with the distribution.
 #
 # THIS SOFTWARE IS PROVIDED BY APPLE AND ITS CONTRIBUTORS "AS IS" AND ANY
 # EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
@@ -25,50 +25,54 @@
 
 import os, sys
 
+
 def main():
+    tasksToKillWin = [
+        "cl.exe",
+		"devenv.com",
+		"devenv.exe",
+		"DumpRenderTree.exe",
+		"DumpRenderTree_debug.exe",
+		"httpd.exe",
+		"imagediff.exe",
+		"imagediff_debug.exe",
+		"jsc.exe",
+		"jsc_debug.exe",
+		"LightTPD.exe",
+		"link.exe",
+		"midl.exe",
+		"perl.exe",
+		"Safari.exe",
+		"svn.exe",
+		"testapi.exe",
+		"testapi_debug.exe",
+		"VcBuildHelper.exe",
+		"wdiff.exe",
+		"WebKit2WebProcess.exe",
+		"WebKit2WebProcess_debug.exe",
+		"WebKitTestRunner.exe",
+		"WebKitTestRunner_debug.exe",
+	]
 
-    tasksToKillWin = [ "cl.exe", 
-					"devenv.com", 
-					"devenv.exe", 
-					"DumpRenderTree.exe", 
-					"DumpRenderTree_debug.exe",
-					"httpd.exe", 
-					"imagediff.exe", 
-					"imagediff_debug.exe", 
-					"jsc.exe", 
-					"jsc_debug.exe",
-					"LightTPD.exe", 
-					"link.exe", 
-					"midl.exe", 
-					"perl.exe", 
-					"Safari.exe", 
-					"svn.exe", 
-					"testapi.exe", 
-					"testapi_debug.exe", 
-					"VcBuildHelper.exe", 
-					"wdiff.exe", 
-					"WebKit2WebProcess.exe", 
-					"WebKit2WebProcess_debug.exe", 
-					"WebKitTestRunner.exe", 
-					"WebKitTestRunner_debug.exe" ]
+    tasksToKillMac = [
+		"jsc",
+		"make",
+		"per5.12",
+		"perl",
+		"Problem Reporter",
+		"ruby",
+		"Safari Web Content",
+		"Safari",
+		"svn",
+		"DumpRenderTree",
+		"TestWebKitAPI Web Content",
+		"TestWebKitAPI",
+		"WebKitPluginAgen", # Why no 't'?
+		"WebKitTestRunner Web Content",
+		"WebKitTestRunner",
+		"WebProcess",
+	]
 
-    tasksToKillMac = [ "DumpRenderTree", 
-					"make",
-					"perl", 
-					"per5.12",
-					"ruby",
-					"Safari", 
-					"Safari Web Content",
-					"WebProcess"
-					"svn", 
-					"WebKitTestRunner",
-					"WebKitTestRunner Web Content",
-					"TestWebKitAPI",
-					"TestWebKitAPI Web Content",
-					"jsc",
-					"Problem Reporter",
-					"WebKitPluginAgen" ]
-
     if sys.platform == 'darwin':
         for task in tasksToKillMac:
             os.system("killall -9 -v -m " + task)
@@ -76,7 +80,9 @@
         for task in tasksToKillWin:
             os.system("taskkill /t /f /im " + task)
     else:
-        raise Exception("Have not implemented kill-old-processes for this platform")  
+        raise Exception("Have not implemented kill-old-processes for this platform")
+    # FIXME: Should we return an exit code based on how the kills went?
 
+
 if __name__ == '__main__':
     sys.exit(main())

Modified: trunk/Tools/ChangeLog (90411 => 90412)


--- trunk/Tools/ChangeLog	2011-07-05 22:54:50 UTC (rev 90411)
+++ trunk/Tools/ChangeLog	2011-07-05 22:59:53 UTC (rev 90412)
@@ -1,3 +1,17 @@
+2011-07-05  Eric Seidel  <[email protected]>
+
+        new-run-webkit-tests fails to start http server if one is already running
+        https://bugs.webkit.org/show_bug.cgi?id=63956
+
+        Reviewed by Adam Barth.
+
+        * BuildSlaveSupport/kill-old-processes:
+         - Removed ^M line endings and sorted the process names.
+         - There are no functional changes to this file.
+           (except that now that its using unix line endings it can be executed directly!)
+        * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
+         - Change the name to 'httpd' to match old-run-webkit-test paths.
+
 2011-07-05  Adam Barth  <[email protected]>
 
         Add basic ajax support to garden-o-matic

Modified: trunk/Tools/Scripts/webkitpy/layout_tests/servers/apache_http_server.py (90411 => 90412)


--- trunk/Tools/Scripts/webkitpy/layout_tests/servers/apache_http_server.py	2011-07-05 22:54:50 UTC (rev 90411)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/servers/apache_http_server.py	2011-07-05 22:59:53 UTC (rev 90412)
@@ -48,7 +48,9 @@
           output_dir: the absolute path to the layout test result directory
         """
         http_server_base.HttpServerBase.__init__(self, port_obj)
-        self._name = 'apache'
+        # We use the name "httpd" instead of "apache" to make our paths (e.g. the pid file: /tmp/WebKit/httpd.pid)
+        # match old-run-webkit-tests: https://bugs.webkit.org/show_bug.cgi?id=63956
+        self._name = 'httpd'
         self._mappings = [{'port': 8000},
                           {'port': 8080},
                           {'port': 8081},
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to