Title: [90431] trunk/Tools
- Revision
- 90431
- Author
- [email protected]
- Date
- 2011-07-05 20:34:54 -0700 (Tue, 05 Jul 2011)
Log Message
2011-07-05 Eric Seidel <[email protected]>
Teach run-webkit-tests how to translate --qt and --gtk for new-run-webkit-tests.
Reviewed by Adam Barth.
* Scripts/run-webkit-tests:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (90430 => 90431)
--- trunk/Tools/ChangeLog 2011-07-06 03:15:24 UTC (rev 90430)
+++ trunk/Tools/ChangeLog 2011-07-06 03:34:54 UTC (rev 90431)
@@ -1,3 +1,11 @@
+2011-07-05 Eric Seidel <[email protected]>
+
+ Teach run-webkit-tests how to translate --qt and --gtk for new-run-webkit-tests.
+
+ Reviewed by Adam Barth.
+
+ * Scripts/run-webkit-tests:
+
2011-07-05 Adam Barth <[email protected]>
Add first unit tests for garden-o-matic
Modified: trunk/Tools/Scripts/run-webkit-tests (90430 => 90431)
--- trunk/Tools/Scripts/run-webkit-tests 2011-07-06 03:15:24 UTC (rev 90430)
+++ trunk/Tools/Scripts/run-webkit-tests 2011-07-06 03:34:54 UTC (rev 90431)
@@ -82,6 +82,17 @@
if (runningOnBuildBot()) {
push(@ARGV, "--verbose");
}
+
+ # FIXME: We need a cleaner way to do --platform handling.
+ # One problem is that webkitdirs.pm strips --qt and --gtk from @ARGV when we call isQt/isGtk.
+ # But new-run-webkit-tests wouldn't understand --qt/--gtk if we passed it to it anyway:
+ # https://bugs.webkit.org/show_bug.cgi?id=63970
+ if (isQt()) {
+ push(@ARGV, "--platform=qt");
+ }
+ if (isGtk()) {
+ push(@ARGV, "--platform=gtk");
+ }
}
my $harnessPath = File::Spec->catfile(relativeScriptsDir(), $harnessName);
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
