Title: [90474] trunk/Tools
- Revision
- 90474
- Author
- [email protected]
- Date
- 2011-07-06 11:31:37 -0700 (Wed, 06 Jul 2011)
Log Message
2011-07-06 Xan Lopez <[email protected]>
Reviewed by Gustavo Noronha.
* Scripts/webkitpy/layout_tests/port/gtk.py: use Popen correctly.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (90473 => 90474)
--- trunk/Tools/ChangeLog 2011-07-06 18:26:35 UTC (rev 90473)
+++ trunk/Tools/ChangeLog 2011-07-06 18:31:37 UTC (rev 90474)
@@ -1,3 +1,9 @@
+2011-07-06 Xan Lopez <[email protected]>
+
+ Reviewed by Gustavo Noronha.
+
+ * Scripts/webkitpy/layout_tests/port/gtk.py: use Popen correctly.
+
2011-07-06 Eric Seidel <[email protected]>
webkit-patch failure-reason does not understand NRWT results
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/gtk.py (90473 => 90474)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/gtk.py 2011-07-06 18:26:35 UTC (rev 90473)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/gtk.py 2011-07-06 18:31:37 UTC (rev 90474)
@@ -41,7 +41,7 @@
class GtkDriver(webkit.WebKitDriver):
def start(self):
display_id = self._worker_number + 1
- run_xvfb = ["Xvfb", ":%d -screen 0 800x600x24 -nolisten tcp" % (display_id)]
+ run_xvfb = ["Xvfb", ":%d" % (display_id), "-screen", "0", "800x600x24", "-nolisten", "tcp"]
self._xvfb_process = subprocess.Popen(run_xvfb)
environment = self._port.setup_environ_for_server()
environment['DISPLAY'] = ":%d" % (display_id)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
