[webkit-changes] [90496] trunk/Tools

Wed, 06 Jul 2011 14:10:50 -0700

Title: [90496] trunk/Tools
Revision
90496
Author
[email protected]
Date
2011-07-06 14:10:43 -0700 (Wed, 06 Jul 2011)

Log Message

2011-07-06  Dimitri Glazkov  <[email protected]>

        garden-o-matic should use a favicon to indicate current state.
        https://bugs.webkit.org/show_bug.cgi?id=64027

        Reviewed by Adam Barth.

        * Scripts/webkitpy/tool/servers/data/gardeningserver/favicon-green.png: Added.
        * Scripts/webkitpy/tool/servers/data/gardeningserver/favicon-red.png: Added.
        * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html: Added blurb about icons.
        * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js: Added setting icon state.
        * Scripts/webkitpy/tool/servers/gardeningserver.py: Allowed the use of favicons.

Modified Paths

Added Paths

Diff

Modified: trunk/Tools/ChangeLog (90495 => 90496)


--- trunk/Tools/ChangeLog	2011-07-06 21:09:28 UTC (rev 90495)
+++ trunk/Tools/ChangeLog	2011-07-06 21:10:43 UTC (rev 90496)
@@ -1,3 +1,16 @@
+2011-07-06  Dimitri Glazkov  <[email protected]>
+
+        garden-o-matic should use a favicon to indicate current state.
+        https://bugs.webkit.org/show_bug.cgi?id=64027
+
+        Reviewed by Adam Barth.
+
+        * Scripts/webkitpy/tool/servers/data/gardeningserver/favicon-green.png: Added.
+        * Scripts/webkitpy/tool/servers/data/gardeningserver/favicon-red.png: Added.
+        * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html: Added blurb about icons.
+        * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js: Added setting icon state.
+        * Scripts/webkitpy/tool/servers/gardeningserver.py: Allowed the use of favicons.
+
 2011-07-06  Daniel Bates  <[email protected]>
 
         Fix webkitpy error after changeset 90483 <http://trac.webkit.org/changeset/90483>; Add missing

Added: trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/favicon-green.png (0 => 90496)


--- trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/favicon-green.png	                        (rev 0)
+++ trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/favicon-green.png	2011-07-06 21:10:43 UTC (rev 90496)
@@ -0,0 +1,9 @@
+\x89PNG
+
+
+IHDR\xF3\xFFagAMA\xAF\xC87\x8A\xE9tEXtSoftwareAdobe ImageReadyq\xC9e<\x9FIDAT8˥\x93\xEBKSa\xC7\xFD;v\xCEvl	dD!\x82\x84P{$;\x9A
+ż,K\xD3ݽ\xD26c\xD8L\x8B2r^\xC6H)-\xB3\xD4jsNm\xEA\xD4\xE6֔2q\xD9QB̽\xE9B\xB5at\xB1o\xE7\xEC\xC5L#z\xE0\xCF\xE7\xF3{\xAEq\xE2\xFE'\xF8\x89r\xA7\xEA\xB3=)L\xC6\xE3\xFDa\xE9\x888,u%2Rg\xA2>ݾW\xB4\xAB ϛJ\xCB<\xC9!\x9DG\x86\x9BA\xFA\x96\xBB\xA2\xE9\lF\x89\xEB$\xBDTH\xD2C\xD1;
+تt\xE6xR\xE4\xEA\x9C\xCE\xD5~\xD8^^\x83i\xAE2\xAE\xEFX\xEDC\xE3L\xD8\xF8\x91d\x9F\xDE&\xC8\xF1\xA43\xDDI\xEB\xCCM\xAC	\x94\xA1\xC2_\xCD\xCC\xE8ؔ\xB3\xA9\xF6\x9D\x85\xFD\xF5=\\x9C\xAA\x80\xD8B\xAE\x8B\xAF\x93˜@\xE6N2\xA8Ʋ\xA2\x959\x98U\xDESPLB1U\xF5T!\xDCk\x830x\x95p\xB0\x92ܞ#H\xB8Bb\x82\x8C1\xD3l\x865؄
+_1\x94O\xE4,\x98\xE5$O>\xC6߸\xC0\xB5Pd
+m\xCFa\x9BkD|=\xC9\xC4G\xED	Vn\xA36\xA0\x81\xD6[Įd\x8B桚(\xC4\xD8\xDAP\xFE\xB1\xF9m\xCF.\xC10Q\x8C\xBE`'Fb#&\x90ܧ6\xFA\x97\xBBa\xF4\xABP\xEB\xD7\xE2\xD3׏Q\xE8\xFD\x97\xB71\xD82[\xB5+z\xF7i\xF4; \xA8\xF9]\xD0C17\xE6\x9Bоp\xBAI9̾jD\xBE}\x8E›?7ayze\xCE,hXAK\xA0\xED^3\xA8*bk\xA9\xB7\xF9@\xEC+wQ=!\x87\xDA}u\xD3\xE5Xz\xB7\x80\xB6\xD9\x94\x87\xC2q:g쯺\x91n=\xAA\x92\xD8:\xC4d+_\xB8\x8F\xBD\xB3G\x83\x87\xCCT\x8E\xE6A;\x9CՐJ\xCEƣ\xA5.\x87\x8A!P\xF3\xD6)5!\xDC\xF6\x90\x9BH:\xBE\x81\x88\x98\xDCep\xB0\x92ր\xFA\xD1"\x9C\x96\xA3\x95݂\x9D\x85\xF5\xCE"\xF0Ky\xA6w|\xCA{H\x9A2!i\x87\xED~3z_X\xD1;o\x85\xC5kBZK*
+^\x88R\x{12E7C9}:O\x8A(\xA1\xA7jF\xA0\xE5\x85*^\x98\xADȰ\xD1S\xA5\x84诿\xF1_\xF3gЬ\xE5y\xBA\xD4cIEND\xAEB`\x82
\ No newline at end of file
Property changes on: trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/favicon-green.png
___________________________________________________________________

Added: svn:executable

Added: trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/favicon-red.png (0 => 90496)


--- trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/favicon-red.png	                        (rev 0)
+++ trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/favicon-red.png	2011-07-06 21:10:43 UTC (rev 90496)
@@ -0,0 +1,7 @@
+\x89PNG
+
+
+IHDR\xF3\xFFagAMA\xAF\xC87\x8A\xE9tEXtSoftwareAdobe ImageReadyq\xC9e<OIDAT8˥\x93\xCBK\x94a\xC6\xBF\xD4	\x95\xE9SA\x9Coc\x8A\x94\xAB\x886\xE1\xC6.PDC\x8B\xC4\xB8\xEA\x82\xF4Dբ\xCD@\xABZx\xC1h1\xE0N\x8C\xA2"\xA4\x85C\x8DN\xA9\xA3\x98:v\x9D\x9Df\xE6}\xCF󶰾\xB36uv\xEF\xE1\x9C\xDFy\xEFy\xF2\x8C1\xF8\x9F\xC8\xFF=!\xB7\xAF4ИvCv\x91\xAC$	\x92\x9FH\xF6S8d\xDF\xE9\x8F\xE6\xD6\xE7\xE5*P\xB7.\xFB
+M`+\xAF\xD0Sذ\xF9n\xF7v~c\xC9HVr}\x85\x94ފ\xFBO\x82\xBB\x99\x9B\x97\xFC\x86\xECKW\xD455Bb`l`yj`yk\xB11Aj\xFA\xDDE\xBA\xAB@\xFA\xC6E\xC9\x99\xCAoqS2\xAFFE\xD76\xAF\xF74(l=\x89\xF5\xF0$6#1![\xF7?\x99\xB3@Dw$-W\xB6\xD9fW\xA3&D$\xC7F\xE0n>SR\xEE\xD5Ju\x80Z\xEBNWc#di\x86\xA3\xB9@%\x90\x91\x9E\x8Bb_s\x94R\x9D\xB9\x80\xAAۆ^\x9C\x87\xD1t&:?\x93!Dm\xE7S\xB3Q\xD8e\xD0JWeJÈqMT\xD3\xE1\xEC
+\xEA'D\xA1\xB5B\x8E\xB5\x9C\x8E\xAF\xC1\xF2\xD4:RE\xDF_\x8Eas\xF8\xB13\x9D\x8Aȯ\xAEC2\x87Vz9W\xC1\xC0\xB7\xF0[\xEC\xF1\xD69Ţw\xCFU\x94\x9C\xBB*B4!B\xB8\xEA|\xF8z\xAD\xF5\x80PJ
+fVc\xB1\xC4dEm\xA7\xC8Z\xE0Vw!\xB2\xFD\xB6O\x9F\xC1\xD7p\x89ř\x98\xD6zp\xC7!Mu\xF3S\xA4\xCF>x\xA4\xB8\xB4\xB9\xA9\xF99\xA4f\xA30\xC6\xC0Uއx8\x84\x8F\xAFG\xB7Hv\xB7=}\xDCuʡ\xF3G\xFDB\xF6\x96y=\xE5-\x87\xE0\xB2Ka\x90J\xAC\xE1\xF3\xC48K\xB3+${\x8F?\xFB\xFC\xA3`\xFC\xEC\xE1\x92\xEDv\x91\xB2\xD3L\xE4Љ\xE737ӿ\xC4\x95ѯLj\xEB\xFFIEND\xAEB`\x82
\ No newline at end of file
Property changes on: trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/favicon-red.png
___________________________________________________________________

Added: svn:executable

Modified: trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/index.html (90495 => 90496)


--- trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/index.html	2011-07-06 21:09:28 UTC (rev 90495)
+++ trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/index.html	2011-07-06 21:10:43 UTC (rev 90496)
@@ -1,4 +1,8 @@
 <!DOCTYPE html>
+<!--
+    The favicons are from the awesome famfamfam.com, which is the website of Mark James,
+    a web developer from Birmingham, UK.
+-->
 <html>
 <head>
 <title>Garden-O-Matic</title>
@@ -41,6 +45,7 @@
   width: 200px;
 }
 </style>
+<link rel="icon" id="favicon" type="image/png" href=""
 </head>
 <body>
 <div class="butterbar"><span class="status">Loading...</span> <a class="hide" href=""

Modified: trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/main.js (90495 => 90496)


--- trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/main.js	2011-07-06 21:09:28 UTC (rev 90495)
+++ trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/main.js	2011-07-06 21:10:43 UTC (rev 90496)
@@ -13,13 +13,20 @@
     $(this).parent().fadeOut();
 }
 
+function setIconState(hasFailures)
+{
+    var faviconURL = 'favicon-' + (hasFailures ? 'red' : 'green') + '.png';
+    $('#favicon').attr('href', faviconURL);
+};
+
 function fetchResults(onsuccess)
 {
     results.fetchResultsByBuilder(config.builders, function(resultsByBuilder) {
-        unexpectedFailures = ui.resultsByTest(results.unexpectedFailuresByTest(resultsByBuilder));
+        var unexpectedFailures = ui.resultsByTest(results.unexpectedFailuresByTest(resultsByBuilder));
         $('.failures').append(unexpectedFailures);
         onsuccess();
     });
+    setIconState($('.failures').length);
 }
 
 $('.hide').live('click', hide);

Modified: trunk/Tools/Scripts/webkitpy/tool/servers/gardeningserver.py (90495 => 90496)


--- trunk/Tools/Scripts/webkitpy/tool/servers/gardeningserver.py	2011-07-06 21:09:28 UTC (rev 90495)
+++ trunk/Tools/Scripts/webkitpy/tool/servers/gardeningserver.py	2011-07-06 21:10:43 UTC (rev 90496)
@@ -42,6 +42,8 @@
         "main.js",
         "results.js",
         "ui.js",
+        "favicon-green.png",
+        "favicon-red.png",
     ])
 
     STATIC_FILE_DIRECTORY = os.path.join(os.path.dirname(__file__), "data", "gardeningserver")

_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to