Title: [90521] trunk/Tools
Revision
90521
Author
[email protected]
Date
2011-07-06 18:50:17 -0700 (Wed, 06 Jul 2011)

Log Message

2011-07-06  Adam Barth  <[email protected]>

        Attempt to fix unittest on Leopard.  Let's enumerate the keys in sorted
        order so the test results are predictable.

        * Scripts/webkitpy/tool/bot/irc_command.py:
        * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (90520 => 90521)


--- trunk/Tools/ChangeLog	2011-07-07 01:22:31 UTC (rev 90520)
+++ trunk/Tools/ChangeLog	2011-07-07 01:50:17 UTC (rev 90521)
@@ -1,3 +1,11 @@
+2011-07-06  Adam Barth  <[email protected]>
+
+        Attempt to fix unittest on Leopard.  Let's enumerate the keys in sorted
+        order so the test results are predictable.
+
+        * Scripts/webkitpy/tool/bot/irc_command.py:
+        * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
+
 2011-07-06  Dirk Pranke  <[email protected]>
 
         Reviewed by Eric Siedel.

Modified: trunk/Tools/Scripts/webkitpy/tool/bot/irc_command.py (90520 => 90521)


--- trunk/Tools/Scripts/webkitpy/tool/bot/irc_command.py	2011-07-07 01:22:31 UTC (rev 90520)
+++ trunk/Tools/Scripts/webkitpy/tool/bot/irc_command.py	2011-07-07 01:50:17 UTC (rev 90521)
@@ -155,7 +155,7 @@
 
 class Help(IRCCommand):
     def execute(self, nick, args, tool, sheriff):
-        return "%s: Available commands: %s" % (nick, ", ".join(commands.keys()))
+        return "%s: Available commands: %s" % (nick, ", ".join(sorted(commands.keys())))
 
 
 class Hi(IRCCommand):

Modified: trunk/Tools/Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py (90520 => 90521)


--- trunk/Tools/Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py	2011-07-07 01:22:31 UTC (rev 90520)
+++ trunk/Tools/Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py	2011-07-07 01:50:17 UTC (rev 90521)
@@ -82,7 +82,7 @@
         OutputCapture().assert_outputs(self, run, args=["hi"], expected_stderr=expected_stderr)
 
     def test_help(self):
-        expected_stderr = "MOCK: irc.post: mock_nick: Available commands: hi, help, last-green-revision, rollout, roll-chromium-deps, create-bug, restart, whois\n"
+        expected_stderr = "MOCK: irc.post: mock_nick: Available commands: create-bug, help, hi, last-green-revision, restart, roll-chromium-deps, rollout, whois\n"
         OutputCapture().assert_outputs(self, run, args=["help"], expected_stderr=expected_stderr)
 
     def test_lgr(self):
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to