Log Message
[EFL] DRT: Leak cairo_t to make the pixel tests stop crashing https://bugs.webkit.org/show_bug.cgi?id=64107
Patch by Raphael Kubo da Costa <[email protected]> on 2011-07-07 Reviewed by Kent Tamura. The pointer is later managed by BitmapContext, but it was being de-refed and deleted earlier by our RefPtr, causing crashes in all pixel tests. We now call leakRef() to make sure it is not removed when our createBitmapContextFromWebView goes out of context. * DumpRenderTree/efl/PixelDumpSupportEfl.cpp: (createBitmapContextFromWebView):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (90604 => 90605)
--- trunk/Tools/ChangeLog 2011-07-08 00:49:40 UTC (rev 90604)
+++ trunk/Tools/ChangeLog 2011-07-08 01:16:07 UTC (rev 90605)
@@ -1,3 +1,20 @@
+2011-07-07 Raphael Kubo da Costa <[email protected]>
+
+ [EFL] DRT: Leak cairo_t to make the pixel tests stop crashing
+ https://bugs.webkit.org/show_bug.cgi?id=64107
+
+ Reviewed by Kent Tamura.
+
+ The pointer is later managed by BitmapContext, but it was being
+ de-refed and deleted earlier by our RefPtr, causing crashes in all
+ pixel tests.
+
+ We now call leakRef() to make sure it is not removed when our
+ createBitmapContextFromWebView goes out of context.
+
+ * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
+ (createBitmapContextFromWebView):
+
2011-07-07 Adam Roben <[email protected]>
Update TestFailures's title and header immediately upon navigation
Modified: trunk/Tools/DumpRenderTree/efl/PixelDumpSupportEfl.cpp (90604 => 90605)
--- trunk/Tools/DumpRenderTree/efl/PixelDumpSupportEfl.cpp 2011-07-08 00:49:40 UTC (rev 90604)
+++ trunk/Tools/DumpRenderTree/efl/PixelDumpSupportEfl.cpp 2011-07-08 01:16:07 UTC (rev 90605)
@@ -63,5 +63,5 @@
}
}
- return BitmapContext::createByAdoptingBitmapAndContext(0, context.get());
+ return BitmapContext::createByAdoptingBitmapAndContext(0, context.release().leakRef());
}
_______________________________________________ webkit-changes mailing list [email protected] http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
