Title: [90672] trunk/Tools
- Revision
- 90672
- Author
- [email protected]
- Date
- 2011-07-08 16:35:46 -0700 (Fri, 08 Jul 2011)
Log Message
Make TestFailures's list of flaky tests look more like the list of non-flaky tests
Fixes <http://webkit.org/b/64204> TestFailures page's flaky tests list is ugly!
Reviewed by Daniel Bates.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
(#failure-history, #possibly-flaky-tests): Expanded this rule to apply to the list of flaky
tests.
(#failure-history > li, #possibly-flaky-tests > li): Ditto, but moved the 50px left padding
from here...
(#failure-history > li): ...to here.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
(ViewController.prototype._domForPossiblyFlakyTests): Give the list an id attribute for
styling purposes.
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css (90671 => 90672)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css 2011-07-08 22:57:00 UTC (rev 90671)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css 2011-07-08 23:35:46 UTC (rev 90672)
@@ -24,17 +24,21 @@
content: ':';
}
-#failure-history {
+#failure-history, #possibly-flaky-tests {
margin: 0;
padding: 0 0 0 15px;
}
-#failure-history > li {
+#failure-history > li, #possibly-flaky-tests > li {
background-color: #f0f0f0;
- padding: 10px 10px 10px 50px;
+ padding: 10px;
margin-bottom: 10px;
}
+#failure-history > li {
+ padding-left: 50px;
+}
+
.test-list {
margin: 0 0 0 -40px;
padding: 0;
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js (90671 => 90672)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js 2011-07-08 22:57:00 UTC (rev 90671)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js 2011-07-08 23:35:46 UTC (rev 90672)
@@ -501,6 +501,8 @@
var flakyList = document.createElement('ol');
result.appendChild(flakyList);
+ flakyList.id = 'possibly-flaky-tests';
+
var self = this;
flakyList.appendChildren(sorted(flakyTests).map(function(testName) {
var item = document.createElement('li');
Modified: trunk/Tools/ChangeLog (90671 => 90672)
--- trunk/Tools/ChangeLog 2011-07-08 22:57:00 UTC (rev 90671)
+++ trunk/Tools/ChangeLog 2011-07-08 23:35:46 UTC (rev 90672)
@@ -1,3 +1,22 @@
+2011-07-08 Adam Roben <[email protected]>
+
+ Make TestFailures's list of flaky tests look more like the list of non-flaky tests
+
+ Fixes <http://webkit.org/b/64204> TestFailures page's flaky tests list is ugly!
+
+ Reviewed by Daniel Bates.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
+ (#failure-history, #possibly-flaky-tests): Expanded this rule to apply to the list of flaky
+ tests.
+ (#failure-history > li, #possibly-flaky-tests > li): Ditto, but moved the 50px left padding
+ from here...
+ (#failure-history > li): ...to here.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
+ (ViewController.prototype._domForPossiblyFlakyTests): Give the list an id attribute for
+ styling purposes.
+
2011-07-08 Jeffrey Pfau <[email protected]>
Unreviewed, add myself as committer.
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
