Title: [90700] trunk/Source/WebCore
- Revision
- 90700
- Author
- [email protected]
- Date
- 2011-07-10 18:38:11 -0700 (Sun, 10 Jul 2011)
Log Message
Fix for Bug 63968 - Add comment to explain Vector usage in FontCache::purgeInactiveFontData
https://bugs.webkit.org/show_bug.cgi?id=63968
Reviewed by Dan Bernstein.
No new tests because this changes comments only.
* platform/graphics/FontCache.cpp:
(WebCore::FontCache::purgeInactiveFontData): Add explanation why SimpleFontData is not deleted in the iteration loop.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (90699 => 90700)
--- trunk/Source/WebCore/ChangeLog 2011-07-10 19:33:42 UTC (rev 90699)
+++ trunk/Source/WebCore/ChangeLog 2011-07-11 01:38:11 UTC (rev 90700)
@@ -1,3 +1,15 @@
+2011-07-10 Yuzo Fujishima <[email protected]>
+
+ Fix for Bug 63968 - Add comment to explain Vector usage in FontCache::purgeInactiveFontData
+ https://bugs.webkit.org/show_bug.cgi?id=63968
+
+ Reviewed by Dan Bernstein.
+
+ No new tests because this changes comments only.
+
+ * platform/graphics/FontCache.cpp:
+ (WebCore::FontCache::purgeInactiveFontData): Add explanation why SimpleFontData is not deleted in the iteration loop.
+
2011-07-10 Emil A Eklund <[email protected]>
Switch updateHitTestResult to to new layout types
Modified: trunk/Source/WebCore/platform/graphics/FontCache.cpp (90699 => 90700)
--- trunk/Source/WebCore/platform/graphics/FontCache.cpp 2011-07-10 19:33:42 UTC (rev 90699)
+++ trunk/Source/WebCore/platform/graphics/FontCache.cpp 2011-07-11 01:38:11 UTC (rev 90700)
@@ -345,6 +345,7 @@
for (int i = 0; i < count && it != end; ++it, ++i) {
const SimpleFontData* fontData = *it.get();
gFontDataCache->remove(fontData->platformData());
+ // We should not delete SimpleFontData here because deletion can modify gInactiveFontData. See http://trac.webkit.org/changeset/44011
fontDataToDelete.append(fontData);
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
