Title: [90742] trunk
- Revision
- 90742
- Author
- [email protected]
- Date
- 2011-07-11 07:03:44 -0700 (Mon, 11 Jul 2011)
Log Message
Patch by Noel Gordon <[email protected]> on 2011-07-11
Reviewed by Adam Roben.
Source/WebCore:
Forward focus events to windowless plugins on the windows port.
https://bugs.webkit.org/show_bug.cgi?id=62375
* plugins/win/PluginViewWin.cpp:
(WebCore::PluginView::setFocus): Forward focus events if the plugin is windowless.
LayoutTests:
New plugin/keyboard-events,mouse-events test expectations for the windows port.
https://bugs.webkit.org/show_bug.cgi?id=62375
* platform/win/plugins/keyboard-events-expected.txt: Added.
* platform/win/plugins/mouse-events-expected.txt: Updated.
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (90741 => 90742)
--- trunk/LayoutTests/ChangeLog 2011-07-11 13:54:21 UTC (rev 90741)
+++ trunk/LayoutTests/ChangeLog 2011-07-11 14:03:44 UTC (rev 90742)
@@ -1,3 +1,13 @@
+2011-07-11 Noel Gordon <[email protected]>
+
+ Reviewed by Adam Roben.
+
+ New plugin/keyboard-events,mouse-events test expectations for the windows port.
+ https://bugs.webkit.org/show_bug.cgi?id=62375
+
+ * platform/win/plugins/keyboard-events-expected.txt: Added.
+ * platform/win/plugins/mouse-events-expected.txt: Updated.
+
2011-07-11 Yael Aharon <[email protected]>
[Qt]REGRESSION(r90471): It made 4 fast/notifications tests fail on Qt
Added: trunk/LayoutTests/platform/win/plugins/keyboard-events-expected.txt (0 => 90742)
--- trunk/LayoutTests/platform/win/plugins/keyboard-events-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/win/plugins/keyboard-events-expected.txt 2011-07-11 14:03:44 UTC (rev 90742)
@@ -0,0 +1,11 @@
+CONSOLE MESSAGE: line 0: PLUGIN: getFocusEvent
+CONSOLE MESSAGE: line 0: PLUGIN: mouseDown at (20, 20)
+CONSOLE MESSAGE: line 0: PLUGIN: mouseUp at (20, 20)
+CONSOLE MESSAGE: line 0: PLUGIN: keyDown 'A'
+CONSOLE MESSAGE: line 0: PLUGIN: keyUp 'A'
+CONSOLE MESSAGE: line 0: PLUGIN: keyDown 'B'
+CONSOLE MESSAGE: line 0: PLUGIN: keyUp 'B'
+CONSOLE MESSAGE: line 0: PLUGIN: keyDown 'C'
+CONSOLE MESSAGE: line 0: PLUGIN: keyUp 'C'
+
+This test checks if a plug-in can receive keyboard events sent from eventSender. This is a test for Bug 34936.
Modified: trunk/LayoutTests/platform/win/plugins/mouse-events-expected.txt (90741 => 90742)
--- trunk/LayoutTests/platform/win/plugins/mouse-events-expected.txt 2011-07-11 13:54:21 UTC (rev 90741)
+++ trunk/LayoutTests/platform/win/plugins/mouse-events-expected.txt 2011-07-11 14:03:44 UTC (rev 90742)
@@ -1,3 +1,4 @@
+CONSOLE MESSAGE: line 0: PLUGIN: getFocusEvent
CONSOLE MESSAGE: line 0: PLUGIN: mouseDown at (20, 20)
CONSOLE MESSAGE: line 0: PLUGIN: mouseUp at (20, 20)
CONSOLE MESSAGE: line 0: PLUGIN: mouseDown at (30, 30)
Modified: trunk/Source/WebCore/ChangeLog (90741 => 90742)
--- trunk/Source/WebCore/ChangeLog 2011-07-11 13:54:21 UTC (rev 90741)
+++ trunk/Source/WebCore/ChangeLog 2011-07-11 14:03:44 UTC (rev 90742)
@@ -1,3 +1,13 @@
+2011-07-11 Noel Gordon <[email protected]>
+
+ Reviewed by Adam Roben.
+
+ Forward focus events to windowless plugins on the windows port.
+ https://bugs.webkit.org/show_bug.cgi?id=62375
+
+ * plugins/win/PluginViewWin.cpp:
+ (WebCore::PluginView::setFocus): Forward focus events if the plugin is windowless.
+
2011-07-11 Shinya Kawanaka <[email protected]>
Added accessibility notification when value is changed.
Modified: trunk/Source/WebCore/plugins/win/PluginViewWin.cpp (90741 => 90742)
--- trunk/Source/WebCore/plugins/win/PluginViewWin.cpp 2011-07-11 13:54:21 UTC (rev 90741)
+++ trunk/Source/WebCore/plugins/win/PluginViewWin.cpp 2011-07-11 14:03:44 UTC (rev 90742)
@@ -472,6 +472,17 @@
SetFocus(platformPluginWidget());
Widget::setFocus(focused);
+
+ if (!m_plugin || m_isWindowed)
+ return;
+
+ NPEvent npEvent;
+
+ npEvent.event = focused ? WM_SETFOCUS : WM_KILLFOCUS;
+ npEvent.wParam = 0;
+ npEvent.lParam = 0;
+
+ dispatchNPEvent(npEvent);
}
void PluginView::show()
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
