Title: [90815] trunk/Source/WebCore
Revision
90815
Author
[email protected]
Date
2011-07-12 06:54:10 -0700 (Tue, 12 Jul 2011)

Log Message

Web Inspector: remove more dead code from the Network panel
https://bugs.webkit.org/show_bug.cgi?id=64291

Reviewed by Pavel Feldman.

* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkPanel.prototype._toggleGridMode):
(WebInspector.NetworkPanel.prototype._toggleViewingResourceMode):
* inspector/front-end/networkPanel.css:

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (90814 => 90815)


--- trunk/Source/WebCore/ChangeLog	2011-07-12 13:53:27 UTC (rev 90814)
+++ trunk/Source/WebCore/ChangeLog	2011-07-12 13:54:10 UTC (rev 90815)
@@ -1,3 +1,15 @@
+2011-07-12  Andrey Kosyakov  <[email protected]>
+
+        Web Inspector: remove more dead code from the Network panel
+        https://bugs.webkit.org/show_bug.cgi?id=64291
+
+        Reviewed by Pavel Feldman.
+
+        * inspector/front-end/NetworkPanel.js:
+        (WebInspector.NetworkPanel.prototype._toggleGridMode):
+        (WebInspector.NetworkPanel.prototype._toggleViewingResourceMode):
+        * inspector/front-end/networkPanel.css:
+
 2011-07-12  Adam Roben  <[email protected]>
 
         Unreviewed, rolling out r90811.

Modified: trunk/Source/WebCore/inspector/front-end/NetworkPanel.js (90814 => 90815)


--- trunk/Source/WebCore/inspector/front-end/NetworkPanel.js	2011-07-12 13:53:27 UTC (rev 90814)
+++ trunk/Source/WebCore/inspector/front-end/NetworkPanel.js	2011-07-12 13:54:10 UTC (rev 90815)
@@ -592,20 +592,6 @@
         return node;
     },
 
-    revealAndSelectItem: function(resource)
-    {
-        var node = this._resourceGridNode(resource);
-        if (node) {
-            node.reveal();
-            node.select(true);
-        }
-    },
-
-    addEventDivider: function(divider)
-    {
-        this._timelineGrid.addEventDivider(divider);
-    },
-
     _createStatusbarButtons: function()
     {
         this._preserveLogToggle = new WebInspector.StatusBarButton(WebInspector.UIString("Preserve Log upon Navigation"), "record-profile-status-bar-item");
@@ -904,7 +890,6 @@
         if (this._viewingResourceMode) {
             this._viewingResourceMode = false;
             this.element.removeStyleClass("viewing-resource");
-            this._dataGrid.element.removeStyleClass("viewing-resource-mode");
             this._viewsContainerElement.addStyleClass("hidden");
             this.sidebarElement.style.right = 0;
             this.sidebarElement.style.removeProperty("width");
@@ -912,42 +897,23 @@
                 this._dataGrid.selectedNode.selected = false;
         }
 
-        if (this._briefGrid) {
-            this._dataGrid.element.removeStyleClass("full-grid-mode");
-            this._dataGrid.element.addStyleClass("brief-grid-mode");
+        this._dataGrid.showColumn("method");
+        this._dataGrid.showColumn("status");
+        this._dataGrid.showColumn("type");
+        this._dataGrid.showColumn("size");
+        this._dataGrid.showColumn("time");
 
-            this._dataGrid.hideColumn("method");
-            this._dataGrid.hideColumn("status");
-            this._dataGrid.hideColumn("type");
-            this._dataGrid.hideColumn("size");
-            this._dataGrid.hideColumn("time");
+        var widths = {};
+        widths.name = 20;
+        widths.method = 6;
+        widths.status = 6;
+        widths.type = 6;
+        widths.size = 6;
+        widths.time = 6;
+        widths.timeline = 50;
 
-            var widths = {};
-            widths.name = 20;
-            widths.timeline = 80;
-        } else {
-            this._dataGrid.element.addStyleClass("full-grid-mode");
-            this._dataGrid.element.removeStyleClass("brief-grid-mode");
-
-            this._dataGrid.showColumn("method");
-            this._dataGrid.showColumn("status");
-            this._dataGrid.showColumn("type");
-            this._dataGrid.showColumn("size");
-            this._dataGrid.showColumn("time");
-
-            var widths = {};
-            widths.name = 20;
-            widths.method = 6;
-            widths.status = 6;
-            widths.type = 6;
-            widths.size = 6;
-            widths.time = 6;
-            widths.timeline = 50;
-        }
-
         this._dataGrid.showColumn("timeline");
         this._dataGrid.applyColumnWidthsMap(widths);
-
     },
 
     _toggleViewingResourceMode: function()
@@ -955,12 +921,8 @@
         if (this._viewingResourceMode)
             return;
         this._viewingResourceMode = true;
-        this._preservedColumnWidths = this._dataGrid.columnWidthsMap();
 
         this.element.addStyleClass("viewing-resource");
-        this._dataGrid.element.addStyleClass("viewing-resource-mode");
-        this._dataGrid.element.removeStyleClass("full-grid-mode");
-        this._dataGrid.element.removeStyleClass("brief-grid-mode");
 
         this._dataGrid.hideColumn("method");
         this._dataGrid.hideColumn("status");

Modified: trunk/Source/WebCore/inspector/front-end/networkPanel.css (90814 => 90815)


--- trunk/Source/WebCore/inspector/front-end/networkPanel.css	2011-07-12 13:53:27 UTC (rev 90814)
+++ trunk/Source/WebCore/inspector/front-end/networkPanel.css	2011-07-12 13:54:10 UTC (rev 90815)
@@ -591,33 +591,10 @@
     display: block;
 }
 
-
-.network-log-grid.full-grid-mode .viewer-column {
-    display: none;
-}
-
-.network-log-grid.brief-grid-mode .viewer-column,
-.network-log-grid.brief-grid-mode .method-column,
-.network-log-grid.brief-grid-mode .status-column,
-.network-log-grid.brief-grid-mode .type-column,
-.network-log-grid.brief-grid-mode .size-column,
-.network-log-grid.brief-grid-mode .time-column {
-    display: none;
-}
-
 .network.panel.viewing-resource .network-timeline-grid {
     display: none;
 }
 
-.network-log-grid.viewing-resource-mode .method-column,
-.network-log-grid.viewing-resource-mode .status-column,
-.network-log-grid.viewing-resource-mode .type-column,
-.network-log-grid.viewing-resource-mode .size-column,
-.network-log-grid.viewing-resource-mode .time-column,
-.network-log-grid.viewing-resource-mode .timeline-column {
-    display: none;
-}
-
 .network.panel .sidebar {
     position: absolute;
     top: 0;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to