Title: [90818] trunk
Revision
90818
Author
[email protected]
Date
2011-07-12 07:49:33 -0700 (Tue, 12 Jul 2011)

Log Message

Web Inspector: make TextViewerDelegate methods implementations public in SourceFrame.
https://bugs.webkit.org/show_bug.cgi?id=64353

Reviewed by Pavel Feldman.

Source/WebCore:

* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype.beforeTextChanged):
(WebInspector.SourceFrame.prototype.afterTextChanged):
(WebInspector.SourceFrame.prototype.populateTextAreaContextMenu):
(WebInspector.SourceFrame.prototype.suggestedFileName):
(WebInspector.SourceFrame.prototype.doubleClick):
(WebInspector.SourceFrame.prototype.cancelEditing):
(WebInspector.TextViewerDelegateForSourceFrame.prototype.doubleClick):
(WebInspector.TextViewerDelegateForSourceFrame.prototype.beforeTextChanged):
(WebInspector.TextViewerDelegateForSourceFrame.prototype.afterTextChanged):
(WebInspector.TextViewerDelegateForSourceFrame.prototype.commitEditing):
(WebInspector.TextViewerDelegateForSourceFrame.prototype.cancelEditing):
(WebInspector.TextViewerDelegateForSourceFrame.prototype.populateLineGutterContextMenu):
(WebInspector.TextViewerDelegateForSourceFrame.prototype.populateTextAreaContextMenu):
(WebInspector.TextViewerDelegateForSourceFrame.prototype.suggestedFileName):

LayoutTests:

* inspector/debugger/live-edit.html:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (90817 => 90818)


--- trunk/LayoutTests/ChangeLog	2011-07-12 14:44:33 UTC (rev 90817)
+++ trunk/LayoutTests/ChangeLog	2011-07-12 14:49:33 UTC (rev 90818)
@@ -1,3 +1,12 @@
+2011-07-12  Pavel Podivilov  <[email protected]>
+
+        Web Inspector: make TextViewerDelegate methods implementations public in SourceFrame.
+        https://bugs.webkit.org/show_bug.cgi?id=64353
+
+        Reviewed by Pavel Feldman.
+
+        * inspector/debugger/live-edit.html:
+
 2011-07-12  Adam Roben  <[email protected]>
 
         Update Windows expected results for plugins/mouse-events-fixedpos.html after r90742

Modified: trunk/LayoutTests/inspector/debugger/live-edit.html (90817 => 90818)


--- trunk/LayoutTests/inspector/debugger/live-edit.html	2011-07-12 14:44:33 UTC (rev 90817)
+++ trunk/LayoutTests/inspector/debugger/live-edit.html	2011-07-12 14:49:33 UTC (rev 90818)
@@ -112,7 +112,7 @@
     {
         InspectorTest.addSniffer(WebInspector.debuggerModel, "_didEditScriptSource", callback);
         sourceFrame._textViewer._mainPanel.readOnly = false;
-        sourceFrame._beforeTextChanged();
+        sourceFrame.beforeTextChanged();
         var oldRange, newRange;
         var lines = sourceFrame._textModel._lines;
         for (var i = 0; i < lines.length; ++i) {
@@ -126,7 +126,7 @@
             newRange = new WebInspector.TextRange(i, column, i + lineEndings.length - 1, lastLineLength);
             break;
         }
-        sourceFrame._afterTextChanged(oldRange, newRange);
+        sourceFrame.afterTextChanged(oldRange, newRange);
         sourceFrame._textViewer._commitEditing();
     }
 };

Modified: trunk/Source/WebCore/ChangeLog (90817 => 90818)


--- trunk/Source/WebCore/ChangeLog	2011-07-12 14:44:33 UTC (rev 90817)
+++ trunk/Source/WebCore/ChangeLog	2011-07-12 14:49:33 UTC (rev 90818)
@@ -1,3 +1,26 @@
+2011-07-12  Pavel Podivilov  <[email protected]>
+
+        Web Inspector: make TextViewerDelegate methods implementations public in SourceFrame.
+        https://bugs.webkit.org/show_bug.cgi?id=64353
+
+        Reviewed by Pavel Feldman.
+
+        * inspector/front-end/SourceFrame.js:
+        (WebInspector.SourceFrame.prototype.beforeTextChanged):
+        (WebInspector.SourceFrame.prototype.afterTextChanged):
+        (WebInspector.SourceFrame.prototype.populateTextAreaContextMenu):
+        (WebInspector.SourceFrame.prototype.suggestedFileName):
+        (WebInspector.SourceFrame.prototype.doubleClick):
+        (WebInspector.SourceFrame.prototype.cancelEditing):
+        (WebInspector.TextViewerDelegateForSourceFrame.prototype.doubleClick):
+        (WebInspector.TextViewerDelegateForSourceFrame.prototype.beforeTextChanged):
+        (WebInspector.TextViewerDelegateForSourceFrame.prototype.afterTextChanged):
+        (WebInspector.TextViewerDelegateForSourceFrame.prototype.commitEditing):
+        (WebInspector.TextViewerDelegateForSourceFrame.prototype.cancelEditing):
+        (WebInspector.TextViewerDelegateForSourceFrame.prototype.populateLineGutterContextMenu):
+        (WebInspector.TextViewerDelegateForSourceFrame.prototype.populateTextAreaContextMenu):
+        (WebInspector.TextViewerDelegateForSourceFrame.prototype.suggestedFileName):
+
 2011-07-12  Andrey Kosyakov  <[email protected]>
 
         Web Inspector: remove more dead code from the Network panel

Modified: trunk/Source/WebCore/inspector/front-end/SourceFrame.js (90817 => 90818)


--- trunk/Source/WebCore/inspector/front-end/SourceFrame.js	2011-07-12 14:44:33 UTC (rev 90817)
+++ trunk/Source/WebCore/inspector/front-end/SourceFrame.js	2011-07-12 14:49:33 UTC (rev 90818)
@@ -237,7 +237,7 @@
         delete this._viewerState;
     },
 
-    _beforeTextChanged: function()
+    beforeTextChanged: function()
     {
         if (!this._viewerState) {
             this._saveViewerState();
@@ -248,7 +248,7 @@
         this.clearMessages();
     },
 
-    _afterTextChanged: function(oldRange, newRange)
+    afterTextChanged: function(oldRange, newRange)
     {
         if (!oldRange || !newRange)
             return;
@@ -593,7 +593,7 @@
         this._textViewer.endUpdates();
     },
 
-    _populateLineGutterContextMenu: function(lineNumber, contextMenu)
+    populateLineGutterContextMenu: function(lineNumber, contextMenu)
     {
         contextMenu.appendItem(WebInspector.UIString(WebInspector.useLowerCaseMenuTitles() ? "Continue to here" : "Continue to Here"), this._delegate.continueToLine.bind(this._delegate, lineNumber));
 
@@ -638,11 +638,11 @@
         }
     },
 
-    _populateTextAreaContextMenu: function(contextMenu)
+    populateTextAreaContextMenu: function(contextMenu)
     {
     },
 
-    _suggestedFileName: function()
+    suggestedFileName: function()
     {
         return this._delegate.suggestedFileName();
     },
@@ -872,7 +872,7 @@
         this._textViewer.resize();
     },
 
-    _doubleClick: function(lineNumber)
+    doubleClick: function(lineNumber)
     {
         if (!this._delegate.canEditScriptSource())
             return;
@@ -883,7 +883,7 @@
         this._setReadOnly(false);
     },
 
-    _commitEditing: function()
+    commitEditing: function()
     {
         if (!this._viewerState) {
             // No editing was actually done.
@@ -931,7 +931,7 @@
         this._delegate.setScriptSource(newContent, callback);
     },
 
-    _cancelEditing: function()
+    cancelEditing: function()
     {
         this._restoreViewerState();
         this._setReadOnly(true);
@@ -957,42 +957,42 @@
 WebInspector.TextViewerDelegateForSourceFrame.prototype = {
     doubleClick: function(lineNumber)
     {
-        this._sourceFrame._doubleClick(lineNumber);
+        this._sourceFrame.doubleClick(lineNumber);
     },
 
     beforeTextChanged: function()
     {
-        this._sourceFrame._beforeTextChanged();
+        this._sourceFrame.beforeTextChanged();
     },
 
     afterTextChanged: function(oldRange, newRange)
     {
-        this._sourceFrame._afterTextChanged(oldRange, newRange);
+        this._sourceFrame.afterTextChanged(oldRange, newRange);
     },
 
     commitEditing: function()
     {
-        this._sourceFrame._commitEditing();
+        this._sourceFrame.commitEditing();
     },
 
     cancelEditing: function()
     {
-        this._sourceFrame._cancelEditing();
+        this._sourceFrame.cancelEditing();
     },
 
     populateLineGutterContextMenu: function(lineNumber, contextMenu)
     {
-        this._sourceFrame._populateLineGutterContextMenu(lineNumber, contextMenu);
+        this._sourceFrame.populateLineGutterContextMenu(lineNumber, contextMenu);
     },
 
     populateTextAreaContextMenu: function(contextMenu)
     {
-        this._sourceFrame._populateTextAreaContextMenu(contextMenu);
+        this._sourceFrame.populateTextAreaContextMenu(contextMenu);
     },
 
     suggestedFileName: function()
     {
-        return this._sourceFrame._suggestedFileName();
+        return this._sourceFrame.suggestedFileName();
     }
 };
 
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to