Diff
Modified: trunk/Tools/ChangeLog (90870 => 90871)
--- trunk/Tools/ChangeLog 2011-07-13 00:05:52 UTC (rev 90870)
+++ trunk/Tools/ChangeLog 2011-07-13 00:13:37 UTC (rev 90871)
@@ -1,3 +1,12 @@
+2011-07-12 Adam Barth <[email protected]>
+
+ Tweak some UI in garden-o-matic now that the tree actually has a
+ failure and I can see what this all looks like.
+
+ * Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
+ * Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
+ * Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js:
+
2011-07-12 Joseph Pecoraro <[email protected]>
Unreviewed. Skipping a few tests which fail due to differing output
Modified: trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/main.css (90870 => 90871)
--- trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/main.css 2011-07-13 00:05:52 UTC (rev 90870)
+++ trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/main.css 2011-07-13 00:13:37 UTC (rev 90871)
@@ -58,40 +58,53 @@
}
.regression a {
- text-decoration: none;
font-weight: normal;
}
-.regression .what a[draggable].IMAGE\+TEXT::after {
+.regression .what a {
+ text-decoration: none;
+}
+
+.regression .what a[draggable].IMAGE\+TEXT::before {
content: 'IMAGE+TEXT';
color: white;
background-color: Indigo;
font-size: 10px;
padding: 1px 2px;
- margin: 0 0 0 3px;
+ margin: 0 3px 0 0;
border-radius: 4px;
}
-.regression .what a[draggable].IMAGE::after {
+.regression .what a[draggable].IMAGE::before {
content: 'IMAGE';
color: white;
background-color: MidnightBlue;
font-size: 10px;
padding: 1px 2px;
- margin: 0 0 0 3px;
+ margin: 0 3px 0 0;
border-radius: 4px;
}
-.regression .what a[draggable].TEXT::after {
+.regression .what a[draggable].TEXT::before {
content: 'TEXT';
color: white;
background-color: DodgerBlue;
font-size: 10px;
padding: 1px 2px;
- margin: 0 0 0 3px;
+ margin: 0 3px 0 0;
border-radius: 4px;
}
+.regression .what a[draggable].CRASH::before {
+ content: 'CRASH';
+ color: white;
+ background-color: Tomato;
+ font-size: 10px;
+ padding: 1px 2px;
+ margin: 0 3px 0 0;
+ border-radius: 4px;
+}
+
.regression .what a {
padding: 1px 2px;
border-radius: 4px;
Modified: trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/main.js (90870 => 90871)
--- trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/main.js 2011-07-13 00:05:52 UTC (rev 90870)
+++ trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/main.js 2011-07-13 00:13:37 UTC (rev 90871)
@@ -23,7 +23,7 @@
partyTime.fadeIn(1200).delay(7000).fadeOut();
} else {
var regressions = $('<div class="results-summary regression"></div>');
- $.each(resultsByTest, function(testName, resultNodesByBuilder) {
+ $.each(unexpectedFailures, function(testName, resultNodesByBuilder) {
var testSummary = ui.summarizeTest(testName, resultNodesByBuilder);
regressions.append(testSummary);
Modified: trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/results.js (90870 => 90871)
--- trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/results.js 2011-07-13 00:05:52 UTC (rev 90870)
+++ trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/results.js 2011-07-13 00:13:37 UTC (rev 90871)
@@ -64,7 +64,7 @@
builder: builderName,
master: kMasterName,
testtype: kTestType,
- name: name,
+ name: testName,
};
}
Modified: trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js (90870 => 90871)
--- trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js 2011-07-13 00:05:52 UTC (rev 90870)
+++ trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js 2011-07-13 00:13:37 UTC (rev 90871)
@@ -7,6 +7,11 @@
return builderName.replace(/Webkit /, '');
}
+function displayNameForRevision(revisionNumber)
+{
+ return 'r' + revisionNumber;
+}
+
ui.urlForTest = function(testName)
{
return 'http://trac.webkit.org/browser/trunk/LayoutTests/' + testName;
@@ -15,7 +20,7 @@
ui.urlForRevisionRange = function(firstRevision, lastRevision)
{
if (firstRevision != lastRevision)
- return 'http://trac.webkit.org/log/trunk/?rev=' + firstRevision + '&stop_rev=' + lastRevision + '&limit=100&verbose=on';
+ return 'http://trac.webkit.org/log/trunk/?rev=' + lastRevision + '&stop_rev=' + firstRevision + '&limit=100&verbose=on';
return 'http://trac.webkit.org/changeset/' + firstRevision;
};
@@ -47,10 +52,13 @@
var impliedFirstFailingRevision = newestPassingRevision + 1;
var href = "" oldestFailingRevision);
- var textForRevisionRange = impliedFirstFailingRevision == oldestFailingRevision ? impliedFirstFailingRevision : impliedFirstFailingRevision + ':' + oldestFailingRevision;
- var text = 'Regression ' + textForRevisionRange;
+ var text = impliedFirstFailingRevision == oldestFailingRevision ?
+ displayNameForRevision(impliedFirstFailingRevision) :
+ displayNameForRevision(impliedFirstFailingRevision) + '-' + displayNameForRevision(oldestFailingRevision);
- return $('<a class="regression-range"></a>').attr('href', href).text(text);
+ var block = $('<div class="regression-range">Regression Range: <a></a></div>');
+ $('a', block).attr('href', href).text(text)
+ return block;
};
ui.results = function(resultsURLs)
Modified: trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js (90870 => 90871)
--- trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js 2011-07-13 00:05:52 UTC (rev 90870)
+++ trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js 2011-07-13 00:13:37 UTC (rev 90871)
@@ -31,11 +31,11 @@
test("summarizeRegressionRange", 2, function() {
var summaryWithMultipleRevisions = ui.summarizeRegressionRange(90424, 90426);
summaryWithMultipleRevisions.wrap('<wrapper></wrapper>');
- equal(summaryWithMultipleRevisions.parent().html(), '<a class="regression-range" href="" 90427:90424</a>');
+ equal(summaryWithMultipleRevisions.parent().html(), '<div class="regression-range">Regression Range: <a href=""
var summaryWithOneRevision = ui.summarizeRegressionRange(90425, 90426);
summaryWithOneRevision.wrap('<wrapper></wrapper>');
- equal(summaryWithOneRevision.parent().html(), '<a class="regression-range" href="" 90427:90425</a>');
+ equal(summaryWithOneRevision.parent().html(), '<div class="regression-range">Regression Range: <a href=""
});
test("results", 1, function() {
