Title: [90916] trunk/Source/_javascript_Core
Revision
90916
Author
[email protected]
Date
2011-07-13 07:25:23 -0700 (Wed, 13 Jul 2011)

Log Message

Reviewed by Andreas Kling.

Broken build on QNX
https://bugs.webkit.org/show_bug.cgi?id=63717

QNX doesn't support pthread's SA_RESTART (required by
JSC_MULTIPLE_THREADS), JIT is broken at runtime and there a
few minor compilation errors here and there.

Original patch by Ritt Konstantin <[email protected]>, also
tested by him on QNX v6.5 (x86)

* wtf/DateMath.cpp: fix usage of abs/labs
* wtf/Platform.h: Disable JIT and JSC_MULTIPLE_THREADS
* wtf/StackBounds.cpp: Add a couple of missing includes (and sort them)

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (90915 => 90916)


--- trunk/Source/_javascript_Core/ChangeLog	2011-07-13 14:11:49 UTC (rev 90915)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-07-13 14:25:23 UTC (rev 90916)
@@ -1,3 +1,21 @@
+2011-07-13  Ademar de Souza Reis Jr.  <[email protected]>
+
+        Reviewed by Andreas Kling.
+
+        Broken build on QNX
+        https://bugs.webkit.org/show_bug.cgi?id=63717
+
+        QNX doesn't support pthread's SA_RESTART (required by
+        JSC_MULTIPLE_THREADS), JIT is broken at runtime and there a
+        few minor compilation errors here and there.
+
+        Original patch by Ritt Konstantin <[email protected]>, also
+        tested by him on QNX v6.5 (x86)
+
+        * wtf/DateMath.cpp: fix usage of abs/labs
+        * wtf/Platform.h: Disable JIT and JSC_MULTIPLE_THREADS
+        * wtf/StackBounds.cpp: Add a couple of missing includes (and sort them)
+
 2011-07-12  Anders Carlsson  <[email protected]>
 
         If a compiler has nullptr support, include <cstddef> to get the nullptr_t definition

Modified: trunk/Source/_javascript_Core/wtf/DateMath.cpp (90915 => 90916)


--- trunk/Source/_javascript_Core/wtf/DateMath.cpp	2011-07-13 14:11:49 UTC (rev 90915)
+++ trunk/Source/_javascript_Core/wtf/DateMath.cpp	2011-07-13 14:25:23 UTC (rev 90916)
@@ -698,7 +698,7 @@
             return std::numeric_limits<double>::quiet_NaN();
         if (*postParsePosition != ':' || (postParsePosition - currentPosition) != 2)
             return std::numeric_limits<double>::quiet_NaN();
-        tzHoursAbs = abs(tzHours);
+        tzHoursAbs = labs(tzHours);
         currentPosition = postParsePosition + 1;
         
         if (!isASCIIDigit(*currentPosition))

Modified: trunk/Source/_javascript_Core/wtf/Platform.h (90915 => 90916)


--- trunk/Source/_javascript_Core/wtf/Platform.h	2011-07-13 14:11:49 UTC (rev 90915)
+++ trunk/Source/_javascript_Core/wtf/Platform.h	2011-07-13 14:25:23 UTC (rev 90916)
@@ -578,7 +578,7 @@
 #define WTF_USE_PTHREAD_BASED_QT 1
 #endif
 
-#if (PLATFORM(GTK) || PLATFORM(IOS) || PLATFORM(MAC) || PLATFORM(WIN) || (PLATFORM(QT) && (OS(DARWIN) || USE(PTHREAD_BASED_QT)) && !ENABLE(SINGLE_THREADED))) && !defined(ENABLE_JSC_MULTIPLE_THREADS)
+#if (PLATFORM(GTK) || PLATFORM(IOS) || PLATFORM(MAC) || PLATFORM(WIN) || (PLATFORM(QT) && (OS(DARWIN) || USE(PTHREAD_BASED_QT)) && !ENABLE(SINGLE_THREADED))) && !OS(QNX) && !defined(ENABLE_JSC_MULTIPLE_THREADS)
 #define ENABLE_JSC_MULTIPLE_THREADS 1
 #endif
 
@@ -1027,7 +1027,8 @@
 #if !defined(ENABLE_JIT) \
     && (CPU(X86) || CPU(X86_64) || CPU(ARM) || CPU(MIPS)) \
     && (OS(DARWIN) || !COMPILER(GCC) || GCC_VERSION_AT_LEAST(4, 1, 0)) \
-    && !OS(WINCE)
+    && !OS(WINCE) \
+    && !OS(QNX)
 #define ENABLE_JIT 1
 #endif
 

Modified: trunk/Source/_javascript_Core/wtf/StackBounds.cpp (90915 => 90916)


--- trunk/Source/_javascript_Core/wtf/StackBounds.cpp	2011-07-13 14:11:49 UTC (rev 90915)
+++ trunk/Source/_javascript_Core/wtf/StackBounds.cpp	2011-07-13 14:25:23 UTC (rev 90916)
@@ -41,10 +41,12 @@
 
 #elif OS(QNX)
 
+#include <errno.h>
 #include <fcntl.h>
+#include <pthread.h>
+#include <stdio.h>
+#include <string.h>
 #include <sys/procfs.h>
-#include <stdio.h>
-#include <errno.h>
 
 #elif OS(UNIX)
 
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to