Title: [90970] trunk/Source/WebCore
Revision
90970
Author
[email protected]
Date
2011-07-13 19:05:02 -0700 (Wed, 13 Jul 2011)

Log Message

Remove hack that forcefully prevents scripts from running in shadow SVG
https://bugs.webkit.org/show_bug.cgi?id=64419

This hack was put in to prevent scripts from running in shadow SVG. This should never have
happened, but did because we didn't parse <script> tags in SVG properly. This was fixed in
r88584, so the hack is no longer needed.

No new tests since there is no change in functionality.

Reviewed by Tony Gentilcore.

* dom/ScriptElement.cpp:
(WebCore::ScriptElement::prepareScript):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (90969 => 90970)


--- trunk/Source/WebCore/ChangeLog	2011-07-14 01:46:19 UTC (rev 90969)
+++ trunk/Source/WebCore/ChangeLog	2011-07-14 02:05:02 UTC (rev 90970)
@@ -1,3 +1,19 @@
+2011-07-13  James Simonsen  <[email protected]>
+
+        Remove hack that forcefully prevents scripts from running in shadow SVG
+        https://bugs.webkit.org/show_bug.cgi?id=64419
+
+        This hack was put in to prevent scripts from running in shadow SVG. This should never have
+        happened, but did because we didn't parse <script> tags in SVG properly. This was fixed in
+        r88584, so the hack is no longer needed.
+
+        No new tests since there is no change in functionality.
+
+        Reviewed by Tony Gentilcore.
+
+        * dom/ScriptElement.cpp:
+        (WebCore::ScriptElement::prepareScript):
+
 2011-07-13  Mihnea Ovidenie  <[email protected]>
 
         [CSSRegions] Parse -webkit-content-order property

Modified: trunk/Source/WebCore/dom/ScriptElement.cpp (90969 => 90970)


--- trunk/Source/WebCore/dom/ScriptElement.cpp	2011-07-14 01:46:19 UTC (rev 90969)
+++ trunk/Source/WebCore/dom/ScriptElement.cpp	2011-07-14 02:05:02 UTC (rev 90970)
@@ -203,14 +203,6 @@
     if (!m_element->document()->frame()->script()->canExecuteScripts(AboutToExecuteScript))
         return false;
 
-    // FIXME: This is non-standard. Remove this after https://bugs.webkit.org/show_bug.cgi?id=62412.
-    Node* ancestor = m_element->parentNode();
-    while (ancestor) {
-        if (ancestor->isSVGShadowRoot())
-            return false;
-        ancestor = ancestor->parentNode();
-    }
-
     if (!isScriptForEventSupported())
         return false;
 
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to