Title: [90977] trunk/Tools
- Revision
- 90977
- Author
- [email protected]
- Date
- 2011-07-13 21:13:19 -0700 (Wed, 13 Jul 2011)
Log Message
NRWT doesn't store the svn revision in full_results.json on chromium-win
https://bugs.webkit.org/show_bug.cgi?id=64492
Reviewed by Adam Barth.
Add a warning message in the revision='' case to help us diagnose
what's going wrong on the bot.
* Scripts/webkitpy/layout_tests/controllers/manager.py:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (90976 => 90977)
--- trunk/Tools/ChangeLog 2011-07-14 03:39:31 UTC (rev 90976)
+++ trunk/Tools/ChangeLog 2011-07-14 04:13:19 UTC (rev 90977)
@@ -1,3 +1,15 @@
+2011-07-13 Eric Seidel <[email protected]>
+
+ NRWT doesn't store the svn revision in full_results.json on chromium-win
+ https://bugs.webkit.org/show_bug.cgi?id=64492
+
+ Reviewed by Adam Barth.
+
+ Add a warning message in the revision='' case to help us diagnose
+ what's going wrong on the bot.
+
+ * Scripts/webkitpy/layout_tests/controllers/manager.py:
+
2011-07-13 Dirk Pranke <[email protected]>
new-run-webkit-tests: print baseline search path as part of config output
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py (90976 => 90977)
--- trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py 2011-07-14 03:39:31 UTC (rev 90976)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py 2011-07-14 04:13:19 UTC (rev 90977)
@@ -210,7 +210,8 @@
results['has_pretty_patch'] = port_obj.pretty_patch_available()
try:
results['revision'] = scm.default_scm().head_svn_revision()
- except Exception:
+ except Exception, e:
+ _log.warn("Failed to determine svn revision for checkout (cwd: %s), leaving 'revision' key blank in full_results.json.\n%s" % (port_obj._filesystem.getcwd(), e))
# Handle cases where we're running outside of version control.
results['revision'] = ""
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
