Diff
Modified: trunk/Tools/ChangeLog (91008 => 91009)
--- trunk/Tools/ChangeLog 2011-07-14 17:15:04 UTC (rev 91008)
+++ trunk/Tools/ChangeLog 2011-07-14 17:24:13 UTC (rev 91009)
@@ -1,5 +1,27 @@
2011-07-14 Adam Barth <aba...@webkit.org>
+ garden-o-matic results pane should be more discoverable
+ https://bugs.webkit.org/show_bug.cgi?id=64513
+
+ Reviewed by Eric Seidel.
+
+ This patch causes us to trigger the results pane on mouse clicks
+ instead of mousein. Also, handle the case of no results details more
+ elegantly.
+
+ * Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
+ * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
+ - Change the binding to "click".
+ * Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
+ - Handle the "no results URLs" case explicitly instead of never
+ calling the callback.
+ * Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
+ * Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
+ - Show a message when there are no result details to show.
+ * Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js:
+
+2011-07-14 Adam Barth <aba...@webkit.org>
+
garden-o-matic should badge TIMEOUT failures
https://bugs.webkit.org/show_bug.cgi?id=64435
Modified: trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/main.css (91008 => 91009)
--- trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/main.css 2011-07-14 17:15:04 UTC (rev 91008)
+++ trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/main.css 2011-07-14 17:24:13 UTC (rev 91009)
@@ -148,11 +148,6 @@
color: #555;
}
-.regression .where li:hover {
- color: black;
- background-color: #f3f3f3;
-}
-
.regression .regression-range, .regression .failure-count {
padding: 0px 2px;
display: inline-block;
@@ -197,6 +192,11 @@
background-color: white;
}
+.results-detail .failure-details .missing-data {
+ font-style: italic;
+ text-align: center;
+}
+
.results-detail .failure-details {
height: 100%;
}
Modified: trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/main.js (91008 => 91009)
--- trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/main.js 2011-07-14 17:15:04 UTC (rev 91008)
+++ trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/main.js 2011-07-14 17:24:13 UTC (rev 91009)
@@ -108,7 +108,7 @@
});
}
-$('.regression .where li').live('mouseenter', showResultsDetail);
+$('.regression .where a').live('click', showResultsDetail);
$('.results-detail .dismiss').live('click', hideResultsDetail);
$(document).ready(function() {
Modified: trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/results.js (91008 => 91009)
--- trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/results.js 2011-07-14 17:15:04 UTC (rev 91008)
+++ trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/results.js 2011-07-14 17:24:13 UTC (rev 91009)
@@ -429,6 +429,11 @@
var resultURLs = [];
var requestsInFlight = suffixList.length;
+ if (!requestsInFlight) {
+ callback([]);
+ return;
+ }
+
function checkComplete()
{
if (--requestsInFlight == 0)
Modified: trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js (91008 => 91009)
--- trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js 2011-07-14 17:15:04 UTC (rev 91008)
+++ trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js 2011-07-14 17:24:13 UTC (rev 91009)
@@ -326,7 +326,7 @@
deepEqual(collectedResults, ["TEXT", "IMAGE"]);
});
-test("fetchResultsURLs", 3, function() {
+test("fetchResultsURLs", 4, function() {
var simulator = new NetworkSimulator();
var probedURLs = [];
@@ -347,6 +347,9 @@
"http://build.chromium.org/f/chromium/layout_test_results/Mock_Builder/results/layout-test-results/userscripts/another-test-crash-log.txt"
]);
});
+ results.fetchResultsURLs("Mock Builder", "userscripts/another-test.html", ['TIMEOUT'], function(resultURLs) {
+ deepEqual(resultURLs, []);
+ });
});
deepEqual(probedURLs, [
Modified: trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js (91008 => 91009)
--- trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js 2011-07-14 17:15:04 UTC (rev 91008)
+++ trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js 2011-07-14 17:24:13 UTC (rev 91009)
@@ -42,7 +42,7 @@
var where = $('.where', block);
$.each(resultNodesByBuilder, function(builderName, resultNode) {
- where.append($('<li></li>').attr(config.kBuilderNameAttr, builderName).text(displayNameForBuilder(builderName)));
+ where.append($('a', '<li><a href="" builderName).text(displayNameForBuilder(builderName)));
});
return block;
@@ -77,6 +77,10 @@
ui.failureDetails = function(resultsURLs)
{
var block = $('<table class="failure-details"><tbody><tr></tr></tbody></table>');
+
+ if (!resultsURLs.length)
+ $('tr', block).append($('<td><div class="missing-data">No data</div></td>'));
+
$.each(resultsURLs, function(index, resultURL) {
var kind = results.resultKind(resultURL);
var type = results.resultType(resultURL);
@@ -84,6 +88,7 @@
var content = $(fragment).attr('src', resultURL).addClass(kind);
$('tr', block).append($('<td></td>').append(content));
});
+
return block;
};
Modified: trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js (91008 => 91009)
--- trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js 2011-07-14 17:15:04 UTC (rev 91008)
+++ trunk/Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js 2011-07-14 17:24:13 UTC (rev 91009)
@@ -72,4 +72,18 @@
'</table>');
});
+test("failureDetails (empty)", 1, function() {
+ var testResults = ui.failureDetails([]);
+ testResults.wrap('<wrapper></wrapper>');
+ equal(testResults.parent().html(),
+ '<table class="failure-details">' +
+ '<tbody>' +
+ '<tr>' +
+ '<td><div class="missing-data">No data</div></td>' +
+ '</tr>' +
+ '</tbody>' +
+ '</table>');
+});
+
+
})();
