Title: [91022] trunk/Source/_javascript_Core
Revision
91022
Author
[email protected]
Date
2011-07-14 12:31:23 -0700 (Thu, 14 Jul 2011)

Log Message

DFG speculative JIT contains a FIXME for rewinding speculative code generation that
has already been fixed.
https://bugs.webkit.org/show_bug.cgi?id=64022

Patch by Filip Pizlo <[email protected]> on 2011-07-14
Reviewed by Gavin Barraclough.

* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::terminateSpeculativeExecution):

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (91021 => 91022)


--- trunk/Source/_javascript_Core/ChangeLog	2011-07-14 19:24:24 UTC (rev 91021)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-07-14 19:31:23 UTC (rev 91022)
@@ -1,3 +1,14 @@
+2011-07-14  Filip Pizlo  <[email protected]>
+
+        DFG speculative JIT contains a FIXME for rewinding speculative code generation that
+        has already been fixed.
+        https://bugs.webkit.org/show_bug.cgi?id=64022
+
+        Reviewed by Gavin Barraclough.
+
+        * dfg/DFGSpeculativeJIT.h:
+        (JSC::DFG::SpeculativeJIT::terminateSpeculativeExecution):
+
 2011-07-14  Ryuan Choi  <[email protected]>
 
         [EFL] Add OwnPtr specialization for Ecore_Pipe.

Modified: trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.h (91021 => 91022)


--- trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.h	2011-07-14 19:24:24 UTC (rev 91021)
+++ trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.h	2011-07-14 19:31:23 UTC (rev 91022)
@@ -204,10 +204,7 @@
     // Called when we statically determine that a speculation will fail.
     void terminateSpeculativeExecution()
     {
-        // FIXME: in cases where we can statically determine we're going to bail out from the speculative
-        // JIT we should probably rewind code generation and only produce the non-speculative path.
         m_compileOkay = false;
-        speculationCheck(m_jit.jump());
     }
 
     template<bool strict>
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to