Title: [91040] trunk/Source/WebCore
Revision
91040
Author
[email protected]
Date
2011-07-14 18:51:45 -0700 (Thu, 14 Jul 2011)

Log Message

[Mac] Use [NSCursor operationNotAllowedCursor] for CSS no-drop as well as CSS not-allowed
https://bugs.webkit.org/show_bug.cgi?id=64570

Reviewed by Alexey Proskuryakov.

Mac OS X documentation and usage makes it clear that this cursor is usually used for no-drop,
and that it's also reasonable to use it for not-allowed.

* platform/mac/CursorMac.mm:
(WebCore::Cursor::ensurePlatformCursor): Use [NSCursor operationNotAllowedCursor] for
Cursor::NoDrop.

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (91039 => 91040)


--- trunk/Source/WebCore/ChangeLog	2011-07-15 01:40:25 UTC (rev 91039)
+++ trunk/Source/WebCore/ChangeLog	2011-07-15 01:51:45 UTC (rev 91040)
@@ -1,3 +1,17 @@
+2011-07-14  Darin Adler  <[email protected]>
+
+        [Mac] Use [NSCursor operationNotAllowedCursor] for CSS no-drop as well as CSS not-allowed
+        https://bugs.webkit.org/show_bug.cgi?id=64570
+
+        Reviewed by Alexey Proskuryakov.
+
+        Mac OS X documentation and usage makes it clear that this cursor is usually used for no-drop,
+        and that it's also reasonable to use it for not-allowed.
+
+        * platform/mac/CursorMac.mm:
+        (WebCore::Cursor::ensurePlatformCursor): Use [NSCursor operationNotAllowedCursor] for
+        Cursor::NoDrop.
+
 2011-07-14  Luke Macpherson   <[email protected]>
 
         Reviewed by Dimitri Glazkov.

Modified: trunk/Source/WebCore/platform/mac/CursorMac.mm (91039 => 91040)


--- trunk/Source/WebCore/platform/mac/CursorMac.mm	2011-07-15 01:40:25 UTC (rev 91039)
+++ trunk/Source/WebCore/platform/mac/CursorMac.mm	2011-07-15 01:51:45 UTC (rev 91040)
@@ -238,7 +238,11 @@
 #endif
         break;
     case Cursor::NoDrop:
+#if !defined(BUILDING_ON_LEOPARD)
+        m_platformCursor = [NSCursor operationNotAllowedCursor];
+#else
         m_platformCursor = createNamedCursor("noDropCursor", 3, 1);
+#endif
         break;
     case Cursor::Copy:
 #if !defined(BUILDING_ON_LEOPARD)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to