Title: [91256] trunk/Source/WebCore
- Revision
- 91256
- Author
- [email protected]
- Date
- 2011-07-19 08:29:37 -0700 (Tue, 19 Jul 2011)
Log Message
2011-07-19 Vitaly Repeshko <[email protected]>
[V8] Don't put CSSRuleLists in object groups.
https://bugs.webkit.org/show_bug.cgi?id=64798
Reviewed by Pavel Feldman.
Retention of CSSRuleLists should be implemented using hidden
references from holder objects. By putting lists in groups we
artificially extend their lifetimes much more than necessary.
* bindings/v8/V8GCController.cpp:
(WebCore::GrouperVisitor::visitDOMWrapper):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (91255 => 91256)
--- trunk/Source/WebCore/ChangeLog 2011-07-19 15:26:16 UTC (rev 91255)
+++ trunk/Source/WebCore/ChangeLog 2011-07-19 15:29:37 UTC (rev 91256)
@@ -1,3 +1,17 @@
+2011-07-19 Vitaly Repeshko <[email protected]>
+
+ [V8] Don't put CSSRuleLists in object groups.
+ https://bugs.webkit.org/show_bug.cgi?id=64798
+
+ Reviewed by Pavel Feldman.
+
+ Retention of CSSRuleLists should be implemented using hidden
+ references from holder objects. By putting lists in groups we
+ artificially extend their lifetimes much more than necessary.
+
+ * bindings/v8/V8GCController.cpp:
+ (WebCore::GrouperVisitor::visitDOMWrapper):
+
2011-07-19 Gyuyoung Kim <[email protected]>
[EFL] Add ewk_network.cpp|h files.
Modified: trunk/Source/WebCore/bindings/v8/V8GCController.cpp (91255 => 91256)
--- trunk/Source/WebCore/bindings/v8/V8GCController.cpp 2011-07-19 15:26:16 UTC (rev 91255)
+++ trunk/Source/WebCore/bindings/v8/V8GCController.cpp 2011-07-19 15:29:37 UTC (rev 91256)
@@ -389,14 +389,6 @@
if (!values.isEmpty())
v8::V8::AddImplicitReferences(wrapper, values.data(), values.size());
}
-
- } else if (typeInfo->isSubclass(&V8CSSRuleList::info)) {
- CSSRuleList* cssRuleList = static_cast<CSSRuleList*>(object);
- GroupId groupId(cssRuleList);
- StyleList* styleList = cssRuleList->styleList();
- if (styleList)
- groupId = calculateGroupId(styleList);
- m_grouper.append(GrouperItem(groupId, wrapper));
}
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
