Title: [91273] trunk/Tools
- Revision
- 91273
- Author
- [email protected]
- Date
- 2011-07-19 11:21:52 -0700 (Tue, 19 Jul 2011)
Log Message
Buildbot marks a nrwt bot red when tests are missing results
https://bugs.webkit.org/show_bug.cgi?id=64812
Reviewed by Tony Chang.
Added "missing results" label for tests that are missing results.
buildbot Now reports shows a label "X missing results" on a run when X tests were missing
expected results on that run.
Also rephrased "X failed" and "X were flaky" to "X failures" and "X flakes".
* BuildSlaveSupport/build.webkit.org-config/master.cfg:
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg (91272 => 91273)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg 2011-07-19 18:11:39 UTC (rev 91272)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg 2011-07-19 18:21:52 UTC (rev 91273)
@@ -234,9 +234,10 @@
def _parseNewRunWebKitTestsOutput(self, logText):
incorrectLayoutLines = []
expressions = {
- 'failed': re.compile(r'Regressions: Unexpected.+:?\s*\((\d+)\)'),
- 'were flaky': re.compile(r'Unexpected flakiness.+:?\s*\((\d+)\)'),
+ 'failures': re.compile(r'Regressions: Unexpected.+:?\s*\((\d+)\)'),
+ 'flakes': re.compile(r'Unexpected flakiness.+:?\s*\((\d+)\)'),
'new passes': re.compile(r'Expected to .+, but passed:\s+\((\d+)\)'),
+ 'missing results': re.compile(r'no expected results found\s*:\s+\((\d+)\)'),
}
testFailures = {}
@@ -312,10 +313,10 @@
result = SUCCESS
if self.incorrectLayoutLines:
for line in self.incorrectLayoutLines:
- if result != FAILURE and (line.find('were flaky') >= 0 or line.find('new passes') >= 0):
+ if line.find('flakes') >= 0 or line.find('new passes') >= 0 or line.find('missing results') >= 0:
result = WARNINGS
else:
- result = FAILURE
+ return FAILURE
return result
Modified: trunk/Tools/ChangeLog (91272 => 91273)
--- trunk/Tools/ChangeLog 2011-07-19 18:11:39 UTC (rev 91272)
+++ trunk/Tools/ChangeLog 2011-07-19 18:21:52 UTC (rev 91273)
@@ -1,3 +1,19 @@
+2011-07-19 Ryosuke Niwa <[email protected]>
+
+ Buildbot marks a nrwt bot red when tests are missing results
+ https://bugs.webkit.org/show_bug.cgi?id=64812
+
+ Reviewed by Tony Chang.
+
+ Added "missing results" label for tests that are missing results.
+
+ buildbot Now reports shows a label "X missing results" on a run when X tests were missing
+ expected results on that run.
+
+ Also rephrased "X failed" and "X were flaky" to "X failures" and "X flakes".
+
+ * BuildSlaveSupport/build.webkit.org-config/master.cfg:
+
2011-07-19 Adam Roben <[email protected]>
Extract some of FailingTestsBugForm's code into a base class
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
