Title: [91305] trunk/LayoutTests
Revision
91305
Author
[email protected]
Date
2011-07-19 14:51:34 -0700 (Tue, 19 Jul 2011)

Log Message

https://bugs.webkit.org/show_bug.cgi?id=64809
REGRESSION (r91114-r91116): fast/dom/error-to-string-stack-overflow.html failing on Windows 7 Release (Tests)

Reviewed by Adam Roben.

I think this just needs new results. The test deliberately triggers a stack overflow,
and doesn't catch it, so the error is printed to the console. Previously RangeError
had the wrong prototype, and didn't convert the error into a useful error message,
printing a blank line in the console. Since r91116 we inherit from Error correctly,
and print the error to the console.

* fast/dom/error-to-string-stack-overflow-expected.txt:
* fast/js/script-tests/object-prototype-properties.js:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (91304 => 91305)


--- trunk/LayoutTests/ChangeLog	2011-07-19 21:49:07 UTC (rev 91304)
+++ trunk/LayoutTests/ChangeLog	2011-07-19 21:51:34 UTC (rev 91305)
@@ -1,3 +1,19 @@
+2011-07-19  Gavin Barraclough  <[email protected]>
+
+        https://bugs.webkit.org/show_bug.cgi?id=64809
+        REGRESSION (r91114-r91116): fast/dom/error-to-string-stack-overflow.html failing on Windows 7 Release (Tests)
+
+        Reviewed by Adam Roben.
+
+        I think this just needs new results. The test deliberately triggers a stack overflow,
+        and doesn't catch it, so the error is printed to the console. Previously RangeError
+        had the wrong prototype, and didn't convert the error into a useful error message,
+        printing a blank line in the console. Since r91116 we inherit from Error correctly,
+        and print the error to the console.
+
+        * fast/dom/error-to-string-stack-overflow-expected.txt:
+        * fast/js/script-tests/object-prototype-properties.js:
+
 2011-07-19  Ryosuke Niwa  <[email protected]>
 
         More Chromium rebaselines for r91277.

Modified: trunk/LayoutTests/fast/dom/error-to-string-stack-overflow-expected.txt (91304 => 91305)


--- trunk/LayoutTests/fast/dom/error-to-string-stack-overflow-expected.txt	2011-07-19 21:49:07 UTC (rev 91304)
+++ trunk/LayoutTests/fast/dom/error-to-string-stack-overflow-expected.txt	2011-07-19 21:51:34 UTC (rev 91305)
@@ -1,4 +1,4 @@
-CONSOLE MESSAGE: line 17: 
+CONSOLE MESSAGE: line 17: RangeError: Maximum call stack size exceeded.
 Regression test for https://bugs.webkit.org/show_bug.cgi?id=30774. This test passes if it doesn't crash.
 
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to