Title: [91324] trunk/Source/WebCore
Revision
91324
Author
[email protected]
Date
2011-07-19 17:46:57 -0700 (Tue, 19 Jul 2011)

Log Message

2011-07-19  Simon Fraser  <[email protected]>

        REGRESSION (r91136-r91146): 40 tests failing on Windows 7 Release (Tests)
        https://bugs.webkit.org/show_bug.cgi?id=64808

        Reviewed by Adam Roben.

        Initializing m_uncommittedChanges to a non-zero value
        caused the first call to noteLayerPropertyChanged() to
        not call m_client->notifySyncRequired(). This resulted in
        animations never getting committed on Windows, which broke
        a lot of tests.

        * platform/graphics/ca/GraphicsLayerCA.cpp:
        (WebCore::GraphicsLayerCA::GraphicsLayerCA):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (91323 => 91324)


--- trunk/Source/WebCore/ChangeLog	2011-07-20 00:29:20 UTC (rev 91323)
+++ trunk/Source/WebCore/ChangeLog	2011-07-20 00:46:57 UTC (rev 91324)
@@ -1,3 +1,19 @@
+2011-07-19  Simon Fraser  <[email protected]>
+
+        REGRESSION (r91136-r91146): 40 tests failing on Windows 7 Release (Tests)
+        https://bugs.webkit.org/show_bug.cgi?id=64808
+
+        Reviewed by Adam Roben.
+
+        Initializing m_uncommittedChanges to a non-zero value
+        caused the first call to noteLayerPropertyChanged() to
+        not call m_client->notifySyncRequired(). This resulted in
+        animations never getting committed on Windows, which broke
+        a lot of tests.
+
+        * platform/graphics/ca/GraphicsLayerCA.cpp:
+        (WebCore::GraphicsLayerCA::GraphicsLayerCA):
+
 2011-07-19  James Robinson  <[email protected]>
 
         [chromium] LayerRendererChromium shouldn't be a friend of RenderSurfaceChromium

Modified: trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp (91323 => 91324)


--- trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp	2011-07-20 00:29:20 UTC (rev 91323)
+++ trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp	2011-07-20 00:46:57 UTC (rev 91324)
@@ -250,7 +250,7 @@
     , m_contentsLayerPurpose(NoContentsLayer)
     , m_contentsLayerHasBackgroundColor(false)
     , m_allowTiledLayer(true)
-    , m_uncommittedChanges(ContentsScaleChanged)
+    , m_uncommittedChanges(0)
 {
     m_layer = PlatformCALayer::create(PlatformCALayer::LayerTypeWebLayer, this);
 
@@ -259,6 +259,7 @@
 #endif
 
     updateDebugIndicators();
+    noteLayerPropertyChanged(ContentsScaleChanged);
 }
 
 GraphicsLayerCA::~GraphicsLayerCA()
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to