Title: [91349] trunk
Revision
91349
Author
[email protected]
Date
2011-07-20 02:21:51 -0700 (Wed, 20 Jul 2011)

Log Message

Unreviewed, rolling out r91285.
http://trac.webkit.org/changeset/91285
https://bugs.webkit.org/show_bug.cgi?id=64854

"Assertion hit in svg/custom/crash-textPath-attributes.html"
(Requested by mihnea on #webkit).

Patch by Sheriff Bot <[email protected]> on 2011-07-20

Source/WebCore:

* rendering/RenderObjectChildList.cpp:
(WebCore::RenderObjectChildList::updateBeforeAfterContent):

LayoutTests:

* fast/dynamic/hover-before-position-after-style-change-expected.txt: Removed.
* fast/dynamic/hover-before-position-after-style-change.html: Removed.

Modified Paths

Removed Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (91348 => 91349)


--- trunk/LayoutTests/ChangeLog	2011-07-20 08:59:48 UTC (rev 91348)
+++ trunk/LayoutTests/ChangeLog	2011-07-20 09:21:51 UTC (rev 91349)
@@ -1,3 +1,15 @@
+2011-07-20  Sheriff Bot  <[email protected]>
+
+        Unreviewed, rolling out r91285.
+        http://trac.webkit.org/changeset/91285
+        https://bugs.webkit.org/show_bug.cgi?id=64854
+
+        "Assertion hit in svg/custom/crash-textPath-attributes.html"
+        (Requested by mihnea on #webkit).
+
+        * fast/dynamic/hover-before-position-after-style-change-expected.txt: Removed.
+        * fast/dynamic/hover-before-position-after-style-change.html: Removed.
+
 2011-07-20  Boris Smus  <[email protected]>
 
         Web Inspector: audit extensions need a way to link directly to resources

Deleted: trunk/LayoutTests/fast/dynamic/hover-before-position-after-style-change-expected.txt (91348 => 91349)


--- trunk/LayoutTests/fast/dynamic/hover-before-position-after-style-change-expected.txt	2011-07-20 08:59:48 UTC (rev 91348)
+++ trunk/LayoutTests/fast/dynamic/hover-before-position-after-style-change-expected.txt	2011-07-20 09:21:51 UTC (rev 91349)
@@ -1,4 +0,0 @@
-Test for https://bugs.webkit.org/show_bug.cgi?id=56401 Hover the mouse over the "Inline" text. The test passes if "Inline" is not placed on a new line.
-
-PASS
-

Deleted: trunk/LayoutTests/fast/dynamic/hover-before-position-after-style-change.html (91348 => 91349)


--- trunk/LayoutTests/fast/dynamic/hover-before-position-after-style-change.html	2011-07-20 08:59:48 UTC (rev 91348)
+++ trunk/LayoutTests/fast/dynamic/hover-before-position-after-style-change.html	2011-07-20 09:21:51 UTC (rev 91349)
@@ -1,56 +0,0 @@
-<!DOCTYPE HTML>
-<html>
-    <head>
-        <style>
-            div { width:100px; height:100px;}
-            div#outsideDiv:before       { content:"> "; }
-            div#outsideDiv:hover:before { content:"< "; }
-        </style>
-        <p>
-            Test for <a href=""
-            Hover the mouse over the "Inline" text. The test passes if "Inline" is not placed on a new line.
-        </p>
-    </head>
-    <body>
-        <div id="console"></div>
-        <div id="outsideDiv" _onmouseover_="checkTestResult()">
-            <span>Inline</span>
-            <div id="insideDiv">Block</p>
-        </div>
-        <script>
-            function getElementTop(elementId)
-            {
-                var elem = document.getElementById(elementId);
-                return elem.getBoundingClientRect().top;
-            }
-
-            function simulateMouseMove()
-            {
-                var outsideDivTop = getElementTop("outsideDiv");
-                if (window.eventSender)
-                    eventSender.mouseMoveTo(50, outsideDivTop);
-            }
-
-            function checkTestResult()
-            {
-                var outsideDivTop = getElementTop("outsideDiv");
-                var insideDivTop = getElementTop("insideDiv");
-                document.getElementById("console").innerText = (insideDivOriginalTop != insideDivTop) ? "FAIL" : "PASS";
-                if (window.layoutTestController)
-                    document.getElementById("outsideDiv").style.visibility = 'hidden';
-            }
-
-            if (window.layoutTestController)
-                layoutTestController.dumpAsText();
-
-            document.body.offsetTop;
-            // Capture the initial values for inside div top
-            var insideDivOriginalTop = getElementTop("insideDiv");
-
-            if (window.layoutTestController) {
-                simulateMouseMove();
-                checkTestResult();
-            }
-        </script>
-    </body>
-</html>

Modified: trunk/Source/WebCore/ChangeLog (91348 => 91349)


--- trunk/Source/WebCore/ChangeLog	2011-07-20 08:59:48 UTC (rev 91348)
+++ trunk/Source/WebCore/ChangeLog	2011-07-20 09:21:51 UTC (rev 91349)
@@ -1,3 +1,15 @@
+2011-07-20  Sheriff Bot  <[email protected]>
+
+        Unreviewed, rolling out r91285.
+        http://trac.webkit.org/changeset/91285
+        https://bugs.webkit.org/show_bug.cgi?id=64854
+
+        "Assertion hit in svg/custom/crash-textPath-attributes.html"
+        (Requested by mihnea on #webkit).
+
+        * rendering/RenderObjectChildList.cpp:
+        (WebCore::RenderObjectChildList::updateBeforeAfterContent):
+
 2011-07-20  Yury Semikhatsky  <[email protected]>
 
         Web Inspector: don't send Console.enable messages in case of workers

Modified: trunk/Source/WebCore/rendering/RenderObjectChildList.cpp (91348 => 91349)


--- trunk/Source/WebCore/rendering/RenderObjectChildList.cpp	2011-07-20 08:59:48 UTC (rev 91348)
+++ trunk/Source/WebCore/rendering/RenderObjectChildList.cpp	2011-07-20 09:21:51 UTC (rev 91349)
@@ -410,13 +410,6 @@
     }
     
     RenderObject* insertBefore = (type == BEFORE) ? owner->virtualChildren()->firstChild() : 0;
-    if (insertBefore && insertBefore->isAnonymousBlock() && insertBefore->childrenInline()) {
-        // We are going to add the "before" element. We have to check whether the "insertBefore" element
-        // is an anonymous block with inline children. If it is, then we should insert the "before" element
-        // before the first inline child of the anonymous block, otherwise we will end up with the "before"
-        // element in a different block.
-        insertBefore = insertBefore->firstChild();
-    }
 
     // Generated content consists of a single container that houses multiple children (specified
     // by the content property).  This generated content container gets the pseudo-element style set on it.
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to