Title: [91362] trunk/Source/WebCore
Revision
91362
Author
[email protected]
Date
2011-07-20 07:43:52 -0700 (Wed, 20 Jul 2011)

Log Message

[V8] JavaMethodJobject::signature() incorrectly encodes arguments of type JavaTypeString
https://bugs.webkit.org/show_bug.cgi?id=62389

Reviewed by Tony Gentilcore.

Covered by existing tests.

* bridge/jni/JavaMethodJobject.cpp:
(JavaMethodJobject::signature):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (91361 => 91362)


--- trunk/Source/WebCore/ChangeLog	2011-07-20 14:11:23 UTC (rev 91361)
+++ trunk/Source/WebCore/ChangeLog	2011-07-20 14:43:52 UTC (rev 91362)
@@ -1,3 +1,15 @@
+2011-07-20  Steve Block  <[email protected]>
+
+        [V8] JavaMethodJobject::signature() incorrectly encodes arguments of type JavaTypeString
+        https://bugs.webkit.org/show_bug.cgi?id=62389
+
+        Reviewed by Tony Gentilcore.
+
+        Covered by existing tests.
+
+        * bridge/jni/JavaMethodJobject.cpp:
+        (JavaMethodJobject::signature):
+
 2011-07-20  Yury Semikhatsky  <[email protected]>
 
         Web Inspector: sidebar width sometimes is not restored

Modified: trunk/Source/WebCore/bridge/jni/JavaMethodJobject.cpp (91361 => 91362)


--- trunk/Source/WebCore/bridge/jni/JavaMethodJobject.cpp	2011-07-20 14:11:23 UTC (rev 91361)
+++ trunk/Source/WebCore/bridge/jni/JavaMethodJobject.cpp	2011-07-20 14:43:52 UTC (rev 91362)
@@ -130,7 +130,11 @@
                 appendClassName(signatureBuilder, javaClassName.data());
             else {
                 signatureBuilder.append(signatureFromJavaType(type));
-                if (type == JavaTypeObject) {
+                if (type == JavaTypeObject
+#if USE(V8)
+                    || type == JavaTypeString
+#endif
+                    ) {
                     appendClassName(signatureBuilder, javaClassName.data());
                     signatureBuilder.append(';');
                 }
@@ -143,7 +147,11 @@
             appendClassName(signatureBuilder, returnType);
         else {
             signatureBuilder.append(signatureFromJavaType(m_returnType));
-            if (m_returnType == JavaTypeObject) {
+            if (m_returnType == JavaTypeObject
+#if USE(V8)
+                || m_returnType == JavaTypeString
+#endif
+                ) {
                 appendClassName(signatureBuilder, returnType);
                 signatureBuilder.append(';');
             }
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to