Title: [91394] trunk/Source/_javascript_Core
Revision
91394
Author
[email protected]
Date
2011-07-20 13:25:15 -0700 (Wed, 20 Jul 2011)

Log Message

Codeblock doesn't visit cached structures in global resolve instructions
https://bugs.webkit.org/show_bug.cgi?id=64889

Reviewed by Sam Weinig.

Visit the global resolve instructions.  This fixes a couple
of random crashes seen in the jquery tests when using the
interpreter.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::visitAggregate):

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (91393 => 91394)


--- trunk/Source/_javascript_Core/ChangeLog	2011-07-20 20:10:21 UTC (rev 91393)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-07-20 20:25:15 UTC (rev 91394)
@@ -1,3 +1,17 @@
+2011-07-20  Oliver Hunt  <[email protected]>
+
+        Codeblock doesn't visit cached structures in global resolve instructions
+        https://bugs.webkit.org/show_bug.cgi?id=64889
+
+        Reviewed by Sam Weinig.
+
+        Visit the global resolve instructions.  This fixes a couple
+        of random crashes seen in the jquery tests when using the
+        interpreter.
+
+        * bytecode/CodeBlock.cpp:
+        (JSC::CodeBlock::visitAggregate):
+
 2011-07-20  James Robinson  <[email protected]>
 
         Revert worker and WebKit2 runloops to use currentTime() for scheduling instead of the monotonic clock

Modified: trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp (91393 => 91394)


--- trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp	2011-07-20 20:10:21 UTC (rev 91393)
+++ trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp	2011-07-20 20:25:15 UTC (rev 91394)
@@ -1555,6 +1555,8 @@
 #if ENABLE(INTERPRETER)
     for (size_t size = m_propertyAccessInstructions.size(), i = 0; i < size; ++i)
         visitStructures(visitor, &m_instructions[m_propertyAccessInstructions[i]]);
+    for (size_t size = m_globalResolveInstructions.size(), i = 0; i < size; ++i)
+        visitStructures(visitor, &m_instructions[m_globalResolveInstructions[i]]);
 #endif
 #if ENABLE(JIT)
     for (size_t size = m_globalResolveInfos.size(), i = 0; i < size; ++i) {
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to