Title: [91439] trunk/Source/_javascript_Core
Revision
91439
Author
[email protected]
Date
2011-07-20 19:12:25 -0700 (Wed, 20 Jul 2011)

Log Message

DFG non-speculative JIT does not use() the aliased GetByVal,
resulting in bloated use counts.
https://bugs.webkit.org/show_bug.cgi?id=64911

Patch by Filip Pizlo <[email protected]> on 2011-07-20
Reviewed by Gavin Barraclough.

Inserted a call to use() for the aliased GetByVal.

* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::compile):

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (91438 => 91439)


--- trunk/Source/_javascript_Core/ChangeLog	2011-07-21 02:08:22 UTC (rev 91438)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-07-21 02:12:25 UTC (rev 91439)
@@ -1,3 +1,16 @@
+2011-07-20  Filip Pizlo  <[email protected]>
+
+        DFG non-speculative JIT does not use() the aliased GetByVal,
+        resulting in bloated use counts.
+        https://bugs.webkit.org/show_bug.cgi?id=64911
+
+        Reviewed by Gavin Barraclough.
+        
+        Inserted a call to use() for the aliased GetByVal.
+
+        * dfg/DFGNonSpeculativeJIT.cpp:
+        (JSC::DFG::NonSpeculativeJIT::compile):
+
 2011-07-20  Gavin Barraclough  <[email protected]>
 
         https://bugs.webkit.org/show_bug.cgi?id=64909

Modified: trunk/Source/_javascript_Core/dfg/DFGNonSpeculativeJIT.cpp (91438 => 91439)


--- trunk/Source/_javascript_Core/dfg/DFGNonSpeculativeJIT.cpp	2011-07-21 02:08:22 UTC (rev 91438)
+++ trunk/Source/_javascript_Core/dfg/DFGNonSpeculativeJIT.cpp	2011-07-21 02:12:25 UTC (rev 91439)
@@ -707,6 +707,9 @@
         break;
 
     case GetByVal: {
+        if (node.child3() != NoNode)
+            use(node.child3());
+        
         JSValueOperand base(this, node.child1());
         JSValueOperand property(this, node.child2());
 
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to