Title: [91452] trunk/Source/WebCore
- Revision
- 91452
- Author
- [email protected]
- Date
- 2011-07-21 02:29:23 -0700 (Thu, 21 Jul 2011)
Log Message
Patch by Rohan McGovern <[email protected]> on 2011-07-21
Reviewed by Noam Rosenthal.
[Qt] Qt5 Build Fix: remove useless use of qRound(int)
https://bugs.webkit.org/show_bug.cgi?id=64907
Rounding an integer doesn't make sense.
Since 2dcd3939a8bd5ff743e4c87f87b2d81b1a101467 in qtbase, this is not
permitted to compile.
No new tests needed.
* platform/graphics/qt/FontPlatformDataQt.cpp:
(WebCore::FontPlatformData::FontPlatformData): Eliminate qRound(int).
* platform/qt/PlatformScreenQt.cpp:
(WebCore::screenDepthPerComponent): Ditto.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (91451 => 91452)
--- trunk/Source/WebCore/ChangeLog 2011-07-21 09:27:02 UTC (rev 91451)
+++ trunk/Source/WebCore/ChangeLog 2011-07-21 09:29:23 UTC (rev 91452)
@@ -1,3 +1,21 @@
+2011-07-21 Rohan McGovern <[email protected]>
+
+ Reviewed by Noam Rosenthal.
+
+ [Qt] Qt5 Build Fix: remove useless use of qRound(int)
+ https://bugs.webkit.org/show_bug.cgi?id=64907
+
+ Rounding an integer doesn't make sense.
+ Since 2dcd3939a8bd5ff743e4c87f87b2d81b1a101467 in qtbase, this is not
+ permitted to compile.
+
+ No new tests needed.
+
+ * platform/graphics/qt/FontPlatformDataQt.cpp:
+ (WebCore::FontPlatformData::FontPlatformData): Eliminate qRound(int).
+ * platform/qt/PlatformScreenQt.cpp:
+ (WebCore::screenDepthPerComponent): Ditto.
+
2011-07-20 Ryosuke Niwa <[email protected]>
Fix a Valgrind failure caused by r91435.
Modified: trunk/Source/WebCore/platform/graphics/qt/FontPlatformDataQt.cpp (91451 => 91452)
--- trunk/Source/WebCore/platform/graphics/qt/FontPlatformDataQt.cpp 2011-07-21 09:27:02 UTC (rev 91451)
+++ trunk/Source/WebCore/platform/graphics/qt/FontPlatformDataQt.cpp 2011-07-21 09:29:23 UTC (rev 91452)
@@ -64,9 +64,9 @@
: m_data(adoptRef(new FontPlatformDataPrivate()))
{
QFont& font = m_data->font;
- int requestedSize = qRound(description.computedPixelSize());
+ int requestedSize = description.computedPixelSize();
font.setFamily(familyName);
- font.setPixelSize(qRound(requestedSize));
+ font.setPixelSize(requestedSize);
font.setItalic(description.italic());
font.setWeight(toQFontWeight(description.weight()));
font.setWordSpacing(wordSpacing);
Modified: trunk/Source/WebCore/platform/qt/PlatformScreenQt.cpp (91451 => 91452)
--- trunk/Source/WebCore/platform/qt/PlatformScreenQt.cpp 2011-07-21 09:27:02 UTC (rev 91451)
+++ trunk/Source/WebCore/platform/qt/PlatformScreenQt.cpp 2011-07-21 09:29:23 UTC (rev 91452)
@@ -80,7 +80,7 @@
case 32:
return 8;
default:
- return qRound(depth / 3);
+ return depth / 3;
}
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
