Title: [91500] branches/safari-534.51-branch/Source/WebKit2
Diff
Modified: branches/safari-534.51-branch/Source/WebKit2/ChangeLog (91499 => 91500)
--- branches/safari-534.51-branch/Source/WebKit2/ChangeLog 2011-07-21 21:33:26 UTC (rev 91499)
+++ branches/safari-534.51-branch/Source/WebKit2/ChangeLog 2011-07-21 21:34:36 UTC (rev 91500)
@@ -1,3 +1,18 @@
+2011-07-21 Lucas Forschler <[email protected]>
+
+ Merged 88667.
+
+ 2011-06-13 Sam Weinig <[email protected]>
+
+ Reviewed by Darin Adler.
+
+ REGRESSION (81679-81939): In Safari, Dictionary look up (tap or Ctrl-Cmd-D) doesn't work if you have clicked on a word and not moved the mouse
+ <rdar://problem/9580237>
+
+ * WebProcess/WebPage/mac/WebPageMac.mm:
+ (WebKit::shouldUseSelection):
+ Return early if the selection we are using is not a range.
+
2011-06-24 Lucas Forschler <[email protected]>
Merged 89706.
Modified: branches/safari-534.51-branch/Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm (91499 => 91500)
--- branches/safari-534.51-branch/Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm 2011-07-21 21:33:26 UTC (rev 91499)
+++ branches/safari-534.51-branch/Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm 2011-07-21 21:34:36 UTC (rev 91500)
@@ -424,6 +424,9 @@
static bool shouldUseSelection(const VisiblePosition& position, const VisibleSelection& selection)
{
+ if (!selection.isRange())
+ return false;
+
RefPtr<Range> selectedRange = selection.toNormalizedRange();
if (!selectedRange)
return false;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
