Title: [91508] trunk/Tools
Revision
91508
Author
[email protected]
Date
2011-07-21 14:48:32 -0700 (Thu, 21 Jul 2011)

Log Message

Unreviewed.  Reenable ORWT for the --leaks bot.
Something is still wrong with the leaks summarizing
but I'm about to head out on vacation for 2 weeks,
so it's best to just revert back to ORWT until I'm back.

* Scripts/run-webkit-tests:
(usingLeaks):
(useNewRunWebKitTests):

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (91507 => 91508)


--- trunk/Tools/ChangeLog	2011-07-21 21:48:27 UTC (rev 91507)
+++ trunk/Tools/ChangeLog	2011-07-21 21:48:32 UTC (rev 91508)
@@ -1,3 +1,14 @@
+2011-07-21  Eric Seidel  <[email protected]>
+
+        Unreviewed.  Reenable ORWT for the --leaks bot.
+        Something is still wrong with the leaks summarizing
+        but I'm about to head out on vacation for 2 weeks,
+        so it's best to just revert back to ORWT until I'm back.
+
+        * Scripts/run-webkit-tests:
+        (usingLeaks):
+        (useNewRunWebKitTests):
+
 2011-07-21  Ojan Vafai  <[email protected]>
 
         cleanup jsonresults.py style in preparation for making some changes

Modified: trunk/Tools/Scripts/run-webkit-tests (91507 => 91508)


--- trunk/Tools/Scripts/run-webkit-tests	2011-07-21 21:48:27 UTC (rev 91507)
+++ trunk/Tools/Scripts/run-webkit-tests	2011-07-21 21:48:32 UTC (rev 91508)
@@ -65,6 +65,13 @@
     return grep(/(-2|--webkit-test-runner)/, @ARGV);
 }
 
+sub usingLeaks()
+{
+    # NRWT doesn't support --leaks yet.
+    # https://bugs.webkit.org/show_bug.cgi?id=63832
+    return grep(/--leaks/, @ARGV);
+}
+
 sub useNewRunWebKitTests()
 {
     # Change this check to control which platforms use new-run-webkit-tests by default.
@@ -82,7 +89,7 @@
         return (!usingWebKit2() and !isDarwin() and !isARM() and (getQtVersion() ne "4.8"));
     }
 
-    return ((isLeopard() or isSnowLeopard() or isGtk()) and !usingWebKit2());
+    return ((isLeopard() or isSnowLeopard() or isGtk()) and !usingWebKit2() and !usingLeaks());
 }
 
 my $harnessName = "old-run-webkit-tests";
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to