Title: [91518] trunk/Tools
- Revision
- 91518
- Author
- [email protected]
- Date
- 2011-07-21 15:13:33 -0700 (Thu, 21 Jul 2011)
Log Message
fix links on the flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=64832
Reviewed by Tony Chang.
Make them actual anchor tags and linkify the test name instead of
adding an extra link. Also simplify the update view since we now
show the linkified test name.
* TestResultServer/static-dashboards/flakiness_dashboard.html:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (91517 => 91518)
--- trunk/Tools/ChangeLog 2011-07-21 22:09:11 UTC (rev 91517)
+++ trunk/Tools/ChangeLog 2011-07-21 22:13:33 UTC (rev 91518)
@@ -1,3 +1,16 @@
+2011-07-19 Ojan Vafai <[email protected]>
+
+ fix links on the flakiness dashboard
+ https://bugs.webkit.org/show_bug.cgi?id=64832
+
+ Reviewed by Tony Chang.
+
+ Make them actual anchor tags and linkify the test name instead of
+ adding an extra link. Also simplify the update view since we now
+ show the linkified test name.
+
+ * TestResultServer/static-dashboards/flakiness_dashboard.html:
+
2011-07-21 Adam Barth <[email protected]>
webkit.org builders should upload results to test-results AppEngine instance
Modified: trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.html (91517 => 91518)
--- trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.html 2011-07-21 22:09:11 UTC (rev 91517)
+++ trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.html 2011-07-21 22:13:33 UTC (rev 91518)
@@ -1197,7 +1197,7 @@
function linkHTMLToOpenWindow(url, text)
{
- return '<div class=link _onclick_="window.open(\'' + url + '\')">' + text + '</div>';
+ return '<a href="" + url + '" target="_blank">' + text + '</a>';
}
// FIXME: replaced with chromiumRevisionLink/webKitRevisionLink
@@ -1300,12 +1300,6 @@
showPopup(e, html);
}
-function showPopupForTest(e, test)
-{
- showPopup(e, htmlForIndividulTestOnAllBuilders(test));
- appendExpectations();
-}
-
function htmlForTestResults(test)
{
if (!g_currentState.showRunsOnBuilderPage && !isCrossBuilderView())
@@ -1726,10 +1720,14 @@
function showUpdateInfoForTest(testsNeedingUpdate, keys)
{
var test = keys[g_currentState.updateIndex];
- document.body.innerHTML = '<b>' + test + '</b>' +
- '<div style="float:right">' + (g_currentState.updateIndex + 1) + ' of ' +
- + keys.length + ' tests</div><br><br>';
+ document.body.innerHTML = '';
+ // FIXME: Make this DOM creation less verbose.
+ var index = document.createElement('div');
+ index.style.cssFloat = 'right';
+ index.textContent = (g_currentState.updateIndex + 1) + ' of ' + keys.length + ' tests';
+ document.body.appendChild(index);
+
var buttonRegion = document.createElement('div');
var includeBtn = document.createElement('input');
includeBtn.type = 'button';
@@ -1854,12 +1852,14 @@
var testResults = g_testToResultsMap[test];
var master;
var html = '';
+ if (isLayoutTestResults()) {
+ var tracURL = TEST_URL_BASE_PATH_TRAC + test
+ html += '<h2>' + linkHTMLToOpenWindow(tracURL, test) + '</h2>';
+ } else
+ html += '<h2>' + test + '</h2>';
+
if (testResults && testResults.length) {
master = builderMaster(testResults[0].builder);
- if (isLayoutTestResults()) {
- var tracURL = TEST_URL_BASE_PATH_TRAC + test
- html += linkHTMLToOpenWindow(tracURL, tracURL);
- }
html +='<div><b>If a builder is not listed, that means the builder ' +
'does not run that test (e.g. it is skipped) or all runs of the ' +
@@ -2364,7 +2364,7 @@
{
var testsHTML = [];
for (var i = 0; i < tests.length; i++)
- testsHTML.push('<h2 _onclick_="selectContents(this)">' + tests[i] + '</h2>' + htmlForIndividulTestOnAllBuilders(tests[i]));
+ testsHTML.push(htmlForIndividulTestOnAllBuilders(tests[i]));
return testsHTML.join('<hr>');
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
