Title: [91529] trunk/Tools
- Revision
- 91529
- Author
- [email protected]
- Date
- 2011-07-21 16:28:06 -0700 (Thu, 21 Jul 2011)
Log Message
Fix issue throwing a 500 to the bots. We were modifying
the dictionary during an iteration over it's keys and would get
RuntimeError: dictionary changed size during iteration
* TestResultServer/model/jsonresults.py:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (91528 => 91529)
--- trunk/Tools/ChangeLog 2011-07-21 23:21:42 UTC (rev 91528)
+++ trunk/Tools/ChangeLog 2011-07-21 23:28:06 UTC (rev 91529)
@@ -1,3 +1,11 @@
+2011-07-21 Ojan Vafai <[email protected]>
+
+ Fix issue throwing a 500 to the bots. We were modifying
+ the dictionary during an iteration over it's keys and would get
+ RuntimeError: dictionary changed size during iteration
+
+ * TestResultServer/model/jsonresults.py:
+
2011-07-21 Adam Barth <[email protected]>
ORWT fails to consume some NRWT arguments
Modified: trunk/Tools/TestResultServer/model/jsonresults.py (91528 => 91529)
--- trunk/Tools/TestResultServer/model/jsonresults.py 2011-07-21 23:21:42 UTC (rev 91528)
+++ trunk/Tools/TestResultServer/model/jsonresults.py 2011-07-21 23:28:06 UTC (rev 91529)
@@ -209,14 +209,14 @@
@classmethod
def _remove_gtest_modifiers(cls, builder, json):
tests = json[builder][JSON_RESULTS_TESTS]
+ new_tests = {}
for name, test in tests.iteritems():
new_name = name.replace('.FLAKY_', '.', 1)
new_name = new_name.replace('.FAILS_', '.', 1)
new_name = new_name.replace('.MAYBE_', '.', 1)
new_name = new_name.replace('.DISABLED_', '.', 1)
- if new_name != name:
- tests[new_name] = test
- del tests[name]
+ new_tests[new_name] = test
+ json[builder][JSON_RESULTS_TESTS] = new_tests
@classmethod
def _check_json(cls, builder, json):
Modified: trunk/Tools/TestResultServer/model/jsonresults_unittest.py (91528 => 91529)
--- trunk/Tools/TestResultServer/model/jsonresults_unittest.py 2011-07-21 23:21:42 UTC (rev 91528)
+++ trunk/Tools/TestResultServer/model/jsonresults_unittest.py 2011-07-21 23:28:06 UTC (rev 91529)
@@ -618,6 +618,9 @@
"foo.DISABLED_bar2": {
"results": "[1,\"I\"]",
"times": "[1,0]"},
+ "foo.bar3": {
+ "results": "[1,\"I\"]",
+ "times": "[1,0]"},
"foo.FAILS_bar3": {
"results": "[1,\"I\"]",
"times": "[1,0]"},
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
