Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js (91647 => 91648)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js 2011-07-24 16:03:33 UTC (rev 91647)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js 2011-07-24 18:48:54 UTC (rev 91648)
@@ -36,7 +36,7 @@
config.kBuilderNameAttr = 'data-builder-name';
config.kFailureCountAttr = 'data-failure-count';
config.kFailureTypesAttr = 'data-failure-types';
-config.kAlertTypeAttr = 'data-alert-type';
+config.kInfobarTypeAttr = 'data-infobar-type';
var kTenMinutesInMilliseconds = 10 * 60 * 1000;
config.kUpdateFrequency = kTenMinutesInMilliseconds;
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html (91647 => 91648)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html 2011-07-24 16:03:33 UTC (rev 91647)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html 2011-07-24 18:48:54 UTC (rev 91648)
@@ -11,7 +11,7 @@
</head>
<body>
<div class="butterbar"><span class="status">Loading...</span></div>
-<div class="alert"><span class="status"></span></div>
+<div class="infobar"><span class="status"></span></div>
<div class="recent-history"></div>
<div class="results">
<div class="content"></div>
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css (91647 => 91648)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css 2011-07-24 16:03:33 UTC (rev 91647)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css 2011-07-24 18:48:54 UTC (rev 91648)
@@ -104,24 +104,24 @@
margin-left: 20px;
}
-/*** alert ***/
+/*** infobar ***/
-.alert {
+.infobar {
display: none;
background-color: Cornsilk;
border: 5px solid Tomato;
padding: 10px;
margin: 5px auto;
font-size: 15px;
- width: 75%;
+ width: 100%;
text-align: center;
}
-.alert .status a {
+.infobar .status a {
font-weight: normal;
}
-.alert .status ul {
+.infobar .status ul {
margin: 0;
padding: 0;
list-style: none;
@@ -129,7 +129,7 @@
padding: 0 0 0 10px;
}
-.alert .status li {
+.infobar .status li {
display: inline-block;
margin: 0px 5px;
}
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js (91647 => 91648)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js 2011-07-24 16:03:33 UTC (rev 91647)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js 2011-07-24 18:48:54 UTC (rev 91648)
@@ -5,7 +5,7 @@
var g_updateTimerId = 0;
var g_resultsDetailsIterator = null;
-var kBuildFailedAlertType = 'build-failed';
+var kBuildFailedInfobarType = 'build-failed';
var kCommitLogLength = 20;
function dismissButterbar()
@@ -19,27 +19,27 @@
$('.butterbar').fadeIn('fast');
}
-function hideAlert()
+function hideInfobar()
{
- $('.alert').animate({
+ $('.infobar').animate({
opacity: 'toggle',
height: 'toggle',
});
}
-function hideAlertIfOfType(type)
+function hideInfobarIfOfType(type)
{
- if (!$('.alert .status').is(':visible'))
+ if (!$('.infobar .status').is(':visible'))
return;
- if ($('.alert .status').attr(config.kAlertTypeAttr) != type)
+ if ($('.infobar .status').attr(config.kInfobarTypeAttr) != type)
return;
- hideAlert();
+ hideInfobar();
}
-function displayAlert(message, type)
+function displayInfobar(message, type)
{
- $('.alert .status').empty().attr(config.kAlertTypeAttr, type).append(message);
- $('.alert').animate({
+ $('.infobar .status').empty().attr(config.kInfobarTypeAttr, type).append(message);
+ $('.infobar').animate({
opacity: 'toggle',
height: 'toggle',
});
@@ -302,10 +302,10 @@
{
results.fetchBuildersWithCompileErrors(function(builderNameList) {
if (!builderNameList.length) {
- hideAlertIfOfType(kBuildFailedAlertType);
+ hideInfobarIfOfType(kBuildFailedInfobarType);
return;
}
- displayAlert(ui.alertMessageForCompileErrors(builderNameList), kBuildFailedAlertType);
+ displayInfobar(ui.infobarMessageForCompileErrors(builderNameList), kBuildFailedInfobarType);
});
}
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js (91647 => 91648)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js 2011-07-24 16:03:33 UTC (rev 91647)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js 2011-07-24 18:48:54 UTC (rev 91648)
@@ -86,7 +86,7 @@
return block;
};
-ui.alertMessageForCompileErrors = function(builderNameList)
+ui.infobarMessageForCompileErrors = function(builderNameList)
{
var block = $('<div class="compile-errors">Build Failed:<ul></ul></div>');
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js (91647 => 91648)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js 2011-07-24 16:03:33 UTC (rev 91647)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js 2011-07-24 18:48:54 UTC (rev 91648)
@@ -63,8 +63,8 @@
equal(ui.failureCount(3), 'Seen 3 times.');
});
-test("alertMessageForCompileErrors", 1, function() {
- var message = ui.alertMessageForCompileErrors(['Mock Builder', 'Another Builder']);
+test("infobarMessageForCompileErrors", 1, function() {
+ var message = ui.infobarMessageForCompileErrors(['Mock Builder', 'Another Builder']);
message.wrap('<wrapper></wrapper>');
equal(message.parent().html(),
'<div class="compile-errors">Build Failed:<ul>' +
Modified: trunk/Tools/ChangeLog (91647 => 91648)
--- trunk/Tools/ChangeLog 2011-07-24 16:03:33 UTC (rev 91647)
+++ trunk/Tools/ChangeLog 2011-07-24 18:48:54 UTC (rev 91648)
@@ -1,3 +1,14 @@
+2011-07-24 Adam Barth <[email protected]>
+
+ Rename garden-o-matic "alert" to "infobar" and increase the width to 100%.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:
+
2011-07-23 Dimitri Glazkov <[email protected]>
TestConfiguration should be hashable and comparable for equality.
