Title: [91727] trunk/Source
- Revision
- 91727
- Author
- [email protected]
- Date
- 2011-07-25 17:12:29 -0700 (Mon, 25 Jul 2011)
Log Message
WebFrame should have a method to determine its visual emptiness
https://bugs.webkit.org/show_bug.cgi?id=64223
Patch by Ian Henderson <[email protected]> on 2011-07-25
Reviewed by Dan Bernstein.
Source/WebCore:
* page/FrameView.h:
(WebCore::FrameView::isVisuallyNonEmpty): Add an accessor to FrameView
so we can tell whether it's visually non-empty.
Source/WebKit/mac:
* WebView/WebFrame.mm:
(-[WebFrame _isVisuallyNonEmpty]): Pipe the isVisuallyNonEmpty method
through WebKit.
* WebView/WebFramePrivate.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (91726 => 91727)
--- trunk/Source/WebCore/ChangeLog 2011-07-26 00:11:16 UTC (rev 91726)
+++ trunk/Source/WebCore/ChangeLog 2011-07-26 00:12:29 UTC (rev 91727)
@@ -1,3 +1,14 @@
+2011-07-25 Ian Henderson <[email protected]>
+
+ WebFrame should have a method to determine its visual emptiness
+ https://bugs.webkit.org/show_bug.cgi?id=64223
+
+ Reviewed by Dan Bernstein.
+
+ * page/FrameView.h:
+ (WebCore::FrameView::isVisuallyNonEmpty): Add an accessor to FrameView
+ so we can tell whether it's visually non-empty.
+
2011-07-25 Scott Graham <[email protected]>
REGRESSION (r39725?): Resources removed from document can not be freed until the document is deleted
Modified: trunk/Source/WebCore/page/FrameView.h (91726 => 91727)
--- trunk/Source/WebCore/page/FrameView.h 2011-07-26 00:11:16 UTC (rev 91726)
+++ trunk/Source/WebCore/page/FrameView.h 2011-07-26 00:12:29 UTC (rev 91727)
@@ -232,6 +232,7 @@
void incrementVisuallyNonEmptyCharacterCount(unsigned);
void incrementVisuallyNonEmptyPixelCount(const IntSize&);
void setIsVisuallyNonEmpty() { m_isVisuallyNonEmpty = true; }
+ bool isVisuallyNonEmpty() const { return m_isVisuallyNonEmpty; }
void forceLayout(bool allowSubtree = false);
void forceLayoutForPagination(const FloatSize& pageSize, float maximumShrinkFactor, AdjustViewSizeOrNot);
Modified: trunk/Source/WebKit/mac/ChangeLog (91726 => 91727)
--- trunk/Source/WebKit/mac/ChangeLog 2011-07-26 00:11:16 UTC (rev 91726)
+++ trunk/Source/WebKit/mac/ChangeLog 2011-07-26 00:12:29 UTC (rev 91727)
@@ -1,3 +1,15 @@
+2011-07-25 Ian Henderson <[email protected]>
+
+ WebFrame should have a method to determine its visual emptiness
+ https://bugs.webkit.org/show_bug.cgi?id=64223
+
+ Reviewed by Dan Bernstein.
+
+ * WebView/WebFrame.mm:
+ (-[WebFrame _isVisuallyNonEmpty]): Pipe the isVisuallyNonEmpty method
+ through WebKit.
+ * WebView/WebFramePrivate.h:
+
2011-07-19 Leo Yang <[email protected]>
SVG: Missing implementation of <altGlyphDef>, <altGlyphItem> and <glyphRef>
Modified: trunk/Source/WebKit/mac/WebView/WebFrame.mm (91726 => 91727)
--- trunk/Source/WebKit/mac/WebView/WebFrame.mm 2011-07-26 00:11:16 UTC (rev 91726)
+++ trunk/Source/WebKit/mac/WebView/WebFrame.mm 2011-07-26 00:12:29 UTC (rev 91727)
@@ -913,6 +913,13 @@
return _private->coreFrame->loader()->stateMachine()->firstLayoutDone();
}
+- (BOOL)_isVisuallyNonEmpty
+{
+ if (FrameView* view = _private->coreFrame->view())
+ return view->isVisuallyNonEmpty();
+ return NO;
+}
+
- (WebFrameLoadType)_loadType
{
return (WebFrameLoadType)_private->coreFrame->loader()->loadType();
Modified: trunk/Source/WebKit/mac/WebView/WebFramePrivate.h (91726 => 91727)
--- trunk/Source/WebKit/mac/WebView/WebFramePrivate.h 2011-07-26 00:11:16 UTC (rev 91726)
+++ trunk/Source/WebKit/mac/WebView/WebFramePrivate.h 2011-07-26 00:12:29 UTC (rev 91727)
@@ -74,6 +74,7 @@
- (NSColor *)_bodyBackgroundColor;
- (BOOL)_isFrameSet;
- (BOOL)_firstLayoutDone;
+- (BOOL)_isVisuallyNonEmpty;
- (WebFrameLoadType)_loadType;
// These methods take and return NSRanges based on the root editable element as the positional base.
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
