Title: [91762] trunk/Tools
- Revision
- 91762
- Author
- [email protected]
- Date
- 2011-07-26 10:37:15 -0700 (Tue, 26 Jul 2011)
Log Message
Windows bots on build.chromium.org can't figure out the head_svn_revision
https://bugs.webkit.org/show_bug.cgi?id=65156
Reviewed by Tony Chang.
This patch is a bit of a guess as to the issue based on the
investigation in https://bugs.webkit.org/show_bug.cgi?id=65148. I'm
not sure whether it will fix the issue, but it seems worth a try.
* Scripts/webkitpy/common/checkout/scm/svn.py:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (91761 => 91762)
--- trunk/Tools/ChangeLog 2011-07-26 17:32:20 UTC (rev 91761)
+++ trunk/Tools/ChangeLog 2011-07-26 17:37:15 UTC (rev 91762)
@@ -1,3 +1,16 @@
+2011-07-26 Adam Barth <[email protected]>
+
+ Windows bots on build.chromium.org can't figure out the head_svn_revision
+ https://bugs.webkit.org/show_bug.cgi?id=65156
+
+ Reviewed by Tony Chang.
+
+ This patch is a bit of a guess as to the issue based on the
+ investigation in https://bugs.webkit.org/show_bug.cgi?id=65148. I'm
+ not sure whether it will fix the issue, but it seems worth a try.
+
+ * Scripts/webkitpy/common/checkout/scm/svn.py:
+
2011-07-26 Carlos Garcia Campos <[email protected]>
Unreviewed. Fix WebKitGtk build with GTK+ 3.x after r91707.
Modified: trunk/Tools/Scripts/webkitpy/common/checkout/scm/svn.py (91761 => 91762)
--- trunk/Tools/Scripts/webkitpy/common/checkout/scm/svn.py 2011-07-26 17:32:20 UTC (rev 91761)
+++ trunk/Tools/Scripts/webkitpy/common/checkout/scm/svn.py 2011-07-26 17:37:15 UTC (rev 91762)
@@ -91,9 +91,9 @@
@classmethod
def value_from_svn_info(cls, path, field_name):
- svn_info_args = ['svn', 'info', path]
+ svn_info_args = ['svn', 'info']
# FIXME: This method should use a passed in executive or be made an instance method and use self._executive.
- info_output = Executive().run_command(svn_info_args).rstrip()
+ info_output = Executive().run_command(svn_info_args, cwd=path).rstrip()
match = re.search("^%s: (?P<value>.+)$" % field_name, info_output, re.MULTILINE)
if not match:
raise ScriptError(script_args=svn_info_args, message='svn info did not contain a %s.' % field_name)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
