Title: [91770] trunk/Source/WebCore
- Revision
- 91770
- Author
- e...@chromium.org
- Date
- 2011-07-26 12:13:07 -0700 (Tue, 26 Jul 2011)
Log Message
regression: generating CSSValueKeywords should not print by default
https://bugs.webkit.org/show_bug.cgi?id=65195
Reviewed by Tony Chang.
Some refactoring made some callers no longer pass the final 'beQuiet'
parameter to applyPreprocessor. This flag was only used to print the
input filename anyway, so remove the flag and just make the caller
print the filename if it wants this.
* bindings/scripts/IDLParser.pm:
(Parse): print before calling applyPreprocessor, if necessary.
* bindings/scripts/preprocessor.pm:
(applyPreprocessor): remove the beQuiet flag; just always be quiet.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (91769 => 91770)
--- trunk/Source/WebCore/ChangeLog 2011-07-26 19:03:18 UTC (rev 91769)
+++ trunk/Source/WebCore/ChangeLog 2011-07-26 19:13:07 UTC (rev 91770)
@@ -1,3 +1,20 @@
+2011-07-26 Evan Martin <e...@chromium.org>
+
+ regression: generating CSSValueKeywords should not print by default
+ https://bugs.webkit.org/show_bug.cgi?id=65195
+
+ Reviewed by Tony Chang.
+
+ Some refactoring made some callers no longer pass the final 'beQuiet'
+ parameter to applyPreprocessor. This flag was only used to print the
+ input filename anyway, so remove the flag and just make the caller
+ print the filename if it wants this.
+
+ * bindings/scripts/IDLParser.pm:
+ (Parse): print before calling applyPreprocessor, if necessary.
+ * bindings/scripts/preprocessor.pm:
+ (applyPreprocessor): remove the beQuiet flag; just always be quiet.
+
2011-07-26 Raphael Kubo da Costa <k...@profusion.mobi>
[EFL] Do not crash on the isSlider() assert.
Modified: trunk/Source/WebCore/bindings/scripts/IDLParser.pm (91769 => 91770)
--- trunk/Source/WebCore/bindings/scripts/IDLParser.pm 2011-07-26 19:03:18 UTC (rev 91769)
+++ trunk/Source/WebCore/bindings/scripts/IDLParser.pm 2011-07-26 19:13:07 UTC (rev 91770)
@@ -66,7 +66,8 @@
my $preprocessor = shift;
$parentsOnly = shift;
- my @documentContent = applyPreprocessor($fileName, $defines, $preprocessor, $beQuiet);
+ print " | *** Starting to parse $fileName...\n |\n" unless $beQuiet;
+ my @documentContent = applyPreprocessor($fileName, $defines, $preprocessor);
my $dataAvailable = 0;
Modified: trunk/Source/WebCore/bindings/scripts/preprocessor.pm (91769 => 91770)
--- trunk/Source/WebCore/bindings/scripts/preprocessor.pm 2011-07-26 19:03:18 UTC (rev 91769)
+++ trunk/Source/WebCore/bindings/scripts/preprocessor.pm 2011-07-26 19:13:07 UTC (rev 91770)
@@ -39,7 +39,6 @@
my $fileName = shift;
my $defines = shift;
my $preprocessor = shift;
- my $beQuiet = shift;
if (!$preprocessor) {
require Config;
@@ -58,8 +57,6 @@
$defines = "";
}
- print " | *** Starting to parse $fileName...\n |\n" unless $beQuiet;
-
my $pid = open2(\*PP_OUT, \*PP_IN, split(' ', $preprocessor), (map { "-D$_" } split(' ', $defines)), $fileName);
close PP_IN;
my @documentContent = <PP_OUT>;
Modified: trunk/Source/WebCore/css/make-css-file-arrays.pl (91769 => 91770)
--- trunk/Source/WebCore/css/make-css-file-arrays.pl 2011-07-26 19:03:18 UTC (rev 91769)
+++ trunk/Source/WebCore/css/make-css-file-arrays.pl 2011-07-26 19:13:07 UTC (rev 91770)
@@ -56,7 +56,7 @@
$text =~ s|^#.*?$||mg;
} else {
require preprocessor;
- $text = join('', applyPreprocessor($in, $defines, $preprocessor, 1));
+ $text = join('', applyPreprocessor($in, $defines, $preprocessor));
}
# Remove comments in a simple-minded way that will work fine for our files.
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
