Title: [92054] trunk/Tools
- Revision
- 92054
- Author
- [email protected]
- Date
- 2011-07-30 11:24:13 -0700 (Sat, 30 Jul 2011)
Log Message
garden-o-matic should strikeout revisions that have been rolled out
https://bugs.webkit.org/show_bug.cgi?id=65227
Reviewed by Dimitri Glazkov.
This helps gardeners keep track of which problems have been solved.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js (92053 => 92054)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js 2011-07-30 18:12:47 UTC (rev 92053)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js 2011-07-30 18:24:13 UTC (rev 92054)
@@ -70,6 +70,15 @@
}
}
+function findRevert(message)
+{
+ var regexp = /rolling out r(\d+)\./;
+ var revision = findUsingRegExp(message, regexp);
+ if (!revision)
+ return undefined;
+ return parseInt(revision, 10);
+}
+
// FIXME: Consider exposing this method for unit testing.
function parseCommitData(responseXML)
{
@@ -91,6 +100,7 @@
'reviewer': findReviewer(message),
'bugID': findBugID(message),
'message': message,
+ 'revertedRevision': findRevert(message),
};
});
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css (92053 => 92054)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css 2011-07-30 18:12:47 UTC (rev 92053)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css 2011-07-30 18:24:13 UTC (rev 92054)
@@ -166,6 +166,10 @@
padding: 4px 0px 4px 3px;
}
+.changelog .reverted {
+ text-decoration: line-through;
+}
+
.changelog .possible-regression {
background-color: PapayaWhip;
}
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js (92053 => 92054)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js 2011-07-30 18:12:47 UTC (rev 92053)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js 2011-07-30 18:24:13 UTC (rev 92054)
@@ -6,10 +6,24 @@
model.state = {};
+function findAndMarkRevertedRevisions(commitDataList)
+{
+ var revertedRevisions = {};
+ $.each(commitDataList, function(index, commitData) {
+ if (commitData.revertedRevision)
+ revertedRevisions[commitData.revertedRevision] = true;
+ });
+ $.each(commitDataList, function(index, commitData) {
+ if (commitData.revision in revertedRevisions)
+ commitData.wasReverted = true;
+ });
+}
+
model.updateRecentCommits = function(callback)
{
trac.recentCommitData('trunk', kCommitLogLength, function(commitDataList) {
model.state.recentCommits = commitDataList;
+ findAndMarkRevertedRevisions(model.state.recentCommits);
callback();
});
};
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js (92053 => 92054)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js 2011-07-30 18:12:47 UTC (rev 92053)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js 2011-07-30 18:24:13 UTC (rev 92054)
@@ -126,6 +126,8 @@
$('.reviewer', entry).text(commitData.reviewer);
else
$('.reviewer-container', entry).detach();
+ if (commitData.wasReverted)
+ entry.addClass('reverted');
return entry;
}
Modified: trunk/Tools/ChangeLog (92053 => 92054)
--- trunk/Tools/ChangeLog 2011-07-30 18:12:47 UTC (rev 92053)
+++ trunk/Tools/ChangeLog 2011-07-30 18:24:13 UTC (rev 92054)
@@ -1,5 +1,19 @@
2011-07-30 Adam Barth <[email protected]>
+ garden-o-matic should strikeout revisions that have been rolled out
+ https://bugs.webkit.org/show_bug.cgi?id=65227
+
+ Reviewed by Dimitri Glazkov.
+
+ This helps gardeners keep track of which problems have been solved.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
+
+2011-07-30 Adam Barth <[email protected]>
+
Add missing files to the server.
* Scripts/webkitpy/tool/servers/gardeningserver.py:
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
