Title: [92057] trunk/Tools
- Revision
- 92057
- Author
- [email protected]
- Date
- 2011-07-30 11:27:23 -0700 (Sat, 30 Jul 2011)
Log Message
garden-o-matic regression ranges expand after fast bots start passing
https://bugs.webkit.org/show_bug.cgi?id=65406
Reviewed by Dimitri Glazkov.
Once the gardener has fixed a problem, the fast bots pick up the fix,
which means we end up using the slow bots to compute the regression
range. Unfortunately, the slow bots give us large regression ranges,
leading to this strange effect where the regression range quality
degrades as fixes roll in.
This patch causes us to remember the previous regression ranges we've
seen and to use that information in the future, as long as it's
consistent with the new information we receive.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js (92056 => 92057)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js 2011-07-30 18:26:09 UTC (rev 92056)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js 2011-07-30 18:27:23 UTC (rev 92057)
@@ -5,6 +5,7 @@
var kCommitLogLength = 50;
model.state = {};
+model.state.failureAnalysisByTest = {};
function findAndMarkRevertedRevisions(commitDataList)
{
@@ -39,6 +40,12 @@
model.analyzeUnexpectedFailures = function(callback)
{
var unexpectedFailures = results.unexpectedFailuresByTest(model.state.resultsByBuilder);
+
+ $.each(model.state.failureAnalysisByTest, function(testName, failureAnalysis) {
+ if (!(testName in unexpectedFailures))
+ delete model.state.failureAnalysisByTest[testName];
+ });
+
$.each(unexpectedFailures, function(testName, resultNodesByBuilder) {
var builderNameList = base.keys(resultNodesByBuilder);
results.unifyRegressionRanges(builderNameList, testName, function(oldestFailingRevision, newestPassingRevision) {
@@ -48,6 +55,16 @@
'oldestFailingRevision': oldestFailingRevision,
'newestPassingRevision': newestPassingRevision,
};
+
+ var previousFailureAnalysis = model.state.failureAnalysisByTest[testName];
+ if (previousFailureAnalysis
+ && previousFailureAnalysis.oldestFailingRevision <= failureAnalysis.oldestFailingRevision
+ && previousFailureAnalysis.newestPassingRevision >= failureAnalysis.newestPassingRevision) {
+ failureAnalysis.oldestFailingRevision = previousFailureAnalysis.oldestFailingRevision;
+ failureAnalysis.newestPassingRevision = previousFailureAnalysis.newestPassingRevision;
+ }
+
+ model.state.failureAnalysisByTest[testName] = failureAnalysis;
callback(failureAnalysis);
});
});
Modified: trunk/Tools/ChangeLog (92056 => 92057)
--- trunk/Tools/ChangeLog 2011-07-30 18:26:09 UTC (rev 92056)
+++ trunk/Tools/ChangeLog 2011-07-30 18:27:23 UTC (rev 92057)
@@ -1,5 +1,24 @@
2011-07-30 Adam Barth <[email protected]>
+ garden-o-matic regression ranges expand after fast bots start passing
+ https://bugs.webkit.org/show_bug.cgi?id=65406
+
+ Reviewed by Dimitri Glazkov.
+
+ Once the gardener has fixed a problem, the fast bots pick up the fix,
+ which means we end up using the slow bots to compute the regression
+ range. Unfortunately, the slow bots give us large regression ranges,
+ leading to this strange effect where the regression range quality
+ degrades as fixes roll in.
+
+ This patch causes us to remember the previous regression ranges we've
+ seen and to use that information in the future, as long as it's
+ consistent with the new information we receive.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
+
+2011-07-30 Adam Barth <[email protected]>
+
garden-o-matic should have a Refresh button to update its display
https://bugs.webkit.org/show_bug.cgi?id=65403
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
