Title: [92133] trunk/Tools
- Revision
- 92133
- Author
- [email protected]
- Date
- 2011-08-01 11:45:02 -0700 (Mon, 01 Aug 2011)
Log Message
garden-o-matic should show all failures, even ones that it can't find a regression range for
https://bugs.webkit.org/show_bug.cgi?id=65447
Reviewed by Dimitri Glazkov.
Previously, we just wouldn't display test failures that we couldn't
identify a regression range for (or whose regression range had fallen
off the page). This patch just displays them at the end of the list,
which is slightly (but not much) better.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js (92132 => 92133)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js 2011-08-01 18:03:03 UTC (rev 92132)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js 2011-08-01 18:45:02 UTC (rev 92133)
@@ -212,12 +212,10 @@
var impliedFirstFailingRevision = failureAnalysis.newestPassingRevision + 1;
var regressionRows = rowsInRevisionRange(impliedFirstFailingRevision, failureAnalysis.oldestFailingRevision);
- // FIXME: We need to create more rows if regressionRows.length is zero.
-
$('.entry', regressionRows).addClass('possible-regression');
var failureSummary = ui.summarizeFailure(failureAnalysis).attr(config.kRevisionAttr, impliedFirstFailingRevision);
- regressionRows.last().after(failureSummary);
+ (regressionRows.length ? regressionRows : $('.recent-history tr')).last().after(failureSummary);
// FIXME: We should just compute this for failureSummary instead of recomputing the whole page.
showBuilderProgress();
Modified: trunk/Tools/ChangeLog (92132 => 92133)
--- trunk/Tools/ChangeLog 2011-08-01 18:03:03 UTC (rev 92132)
+++ trunk/Tools/ChangeLog 2011-08-01 18:45:02 UTC (rev 92133)
@@ -1,3 +1,17 @@
+2011-08-01 Adam Barth <[email protected]>
+
+ garden-o-matic should show all failures, even ones that it can't find a regression range for
+ https://bugs.webkit.org/show_bug.cgi?id=65447
+
+ Reviewed by Dimitri Glazkov.
+
+ Previously, we just wouldn't display test failures that we couldn't
+ identify a regression range for (or whose regression range had fallen
+ off the page). This patch just displays them at the end of the list,
+ which is slightly (but not much) better.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
+
2011-08-01 Jeff Miller <[email protected]>
Windows build fix after r92096.
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
