Title: [92188] trunk/Tools
- Revision
- 92188
- Author
- [email protected]
- Date
- 2011-08-02 07:11:02 -0700 (Tue, 02 Aug 2011)
Log Message
Fix _win32_check_running_pid on 64bit windows python
https://bugs.webkit.org/show_bug.cgi?id=64950
Reviewed by Adam Roben.
Use the correct types for the PROCESSENTRY32 struct.
th32DefaultHeapID is declared as ULONG_PTR and not as DWORD.
Using 32bit for pointers instead of 64bit results in an ERROR_BAD_LENGTH
failure, when calling the Process32First function.
This is covered by the executive unittest.
* Scripts/webkitpy/common/system/executive.py:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (92187 => 92188)
--- trunk/Tools/ChangeLog 2011-08-02 14:01:12 UTC (rev 92187)
+++ trunk/Tools/ChangeLog 2011-08-02 14:11:02 UTC (rev 92188)
@@ -1,3 +1,18 @@
+2011-08-02 Patrick Gansterer <[email protected]>
+
+ Fix _win32_check_running_pid on 64bit windows python
+ https://bugs.webkit.org/show_bug.cgi?id=64950
+
+ Reviewed by Adam Roben.
+
+ Use the correct types for the PROCESSENTRY32 struct.
+ th32DefaultHeapID is declared as ULONG_PTR and not as DWORD.
+ Using 32bit for pointers instead of 64bit results in an ERROR_BAD_LENGTH
+ failure, when calling the Process32First function.
+ This is covered by the executive unittest.
+
+ * Scripts/webkitpy/common/system/executive.py:
+
2011-08-01 Adam Barth <[email protected]>
garden-o-matic should call optimize-baselines when rebaselining tests
Modified: trunk/Tools/Scripts/webkitpy/common/system/executive.py (92187 => 92188)
--- trunk/Tools/Scripts/webkitpy/common/system/executive.py 2011-08-02 14:01:12 UTC (rev 92187)
+++ trunk/Tools/Scripts/webkitpy/common/system/executive.py 2011-08-02 14:11:02 UTC (rev 92188)
@@ -243,7 +243,7 @@
_fields_ = [("dwSize", ctypes.c_ulong),
("cntUsage", ctypes.c_ulong),
("th32ProcessID", ctypes.c_ulong),
- ("th32DefaultHeapID", ctypes.c_ulong),
+ ("th32DefaultHeapID", ctypes.POINTER(ctypes.c_ulong)),
("th32ModuleID", ctypes.c_ulong),
("cntThreads", ctypes.c_ulong),
("th32ParentProcessID", ctypes.c_ulong),
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
