Title: [92239] trunk/Source/WebCore
- Revision
- 92239
- Author
- [email protected]
- Date
- 2011-08-02 15:17:51 -0700 (Tue, 02 Aug 2011)
Log Message
fail earlier to track down null CachedScript execution
https://bugs.webkit.org/show_bug.cgi?id=65563
Over in http://code.google.com/p/chromium/issues/detail?id=75604 I can't reproduce the problem. Careful reading of the code hasn't led me
to an obvious cause either. This patch should cause failure earlier, and lead to better stacks. I'll watch Chrome Canary's crash
uploads carefully, and remove this CRASH() (and fix the underlying problem) once I understand it.
Reviewed by Alexey Proskuryakov.
No new tests, as my goal here is to get telemetry on a bug that I cannot reproduce.
* dom/ScriptRunner.cpp:
(WebCore::ScriptRunner::queueScriptForExecution):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (92238 => 92239)
--- trunk/Source/WebCore/ChangeLog 2011-08-02 22:11:30 UTC (rev 92238)
+++ trunk/Source/WebCore/ChangeLog 2011-08-02 22:17:51 UTC (rev 92239)
@@ -1,3 +1,19 @@
+2011-08-02 Gavin Peters <[email protected]>
+
+ fail earlier to track down null CachedScript execution
+ https://bugs.webkit.org/show_bug.cgi?id=65563
+
+ Over in http://code.google.com/p/chromium/issues/detail?id=75604 I can't reproduce the problem. Careful reading of the code hasn't led me
+ to an obvious cause either. This patch should cause failure earlier, and lead to better stacks. I'll watch Chrome Canary's crash
+ uploads carefully, and remove this CRASH() (and fix the underlying problem) once I understand it.
+
+ Reviewed by Alexey Proskuryakov.
+
+ No new tests, as my goal here is to get telemetry on a bug that I cannot reproduce.
+
+ * dom/ScriptRunner.cpp:
+ (WebCore::ScriptRunner::queueScriptForExecution):
+
2011-08-02 Sailesh Agrawal <[email protected]>
Chromium: Update forked ScrollbarThemeChromiumMac.mm
Modified: trunk/Source/WebCore/dom/ScriptRunner.cpp (92238 => 92239)
--- trunk/Source/WebCore/dom/ScriptRunner.cpp 2011-08-02 22:11:30 UTC (rev 92238)
+++ trunk/Source/WebCore/dom/ScriptRunner.cpp 2011-08-02 22:17:51 UTC (rev 92239)
@@ -52,6 +52,11 @@
void ScriptRunner::queueScriptForExecution(ScriptElement* scriptElement, CachedResourceHandle<CachedScript> cachedScript, ExecutionType executionType)
{
ASSERT(scriptElement);
+
+ // Temporary: intended to help debug how null CachedScript objects can even get queued for execution, which
+ // seems to sometimes happen (see http://code.google.com/p/chromium/issues/detail?id=75604 )
+ if (!cachedScript.get())
+ CRASH();
Element* element = scriptElement->element();
ASSERT(element);
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
