Diff
Modified: trunk/Source/WebCore/ChangeLog (92264 => 92265)
--- trunk/Source/WebCore/ChangeLog 2011-08-03 08:20:41 UTC (rev 92264)
+++ trunk/Source/WebCore/ChangeLog 2011-08-03 08:28:40 UTC (rev 92265)
@@ -1,3 +1,16 @@
+2011-08-03 Pavel Feldman <[email protected]>
+
+ Web Inspector: remove Node parameter from the InspectorClient::highlight
+ https://bugs.webkit.org/show_bug.cgi?id=65549
+
+ Reviewed by Yury Semikhatsky.
+
+ * inspector/InspectorClient.h:
+ * inspector/InspectorDOMAgent.cpp:
+ (WebCore::InspectorDOMAgent::highlight):
+ * loader/EmptyClients.h:
+ (WebCore::EmptyInspectorClient::highlight):
+
2011-08-03 Antti Koivisto <[email protected]>
https://bugs.webkit.org/show_bug.cgi?id=65599
Modified: trunk/Source/WebCore/inspector/InspectorClient.h (92264 => 92265)
--- trunk/Source/WebCore/inspector/InspectorClient.h 2011-08-03 08:20:41 UTC (rev 92264)
+++ trunk/Source/WebCore/inspector/InspectorClient.h 2011-08-03 08:28:40 UTC (rev 92265)
@@ -44,7 +44,7 @@
virtual void openInspectorFrontend(InspectorController*) = 0;
- virtual void highlight(Node*) = 0;
+ virtual void highlight() = 0;
virtual void hideHighlight() = 0;
// Navigation can cause some WebKit implementations to change the view / page / inspector controller instance.
Modified: trunk/Source/WebCore/inspector/InspectorDOMAgent.cpp (92264 => 92265)
--- trunk/Source/WebCore/inspector/InspectorDOMAgent.cpp 2011-08-03 08:20:41 UTC (rev 92264)
+++ trunk/Source/WebCore/inspector/InspectorDOMAgent.cpp 2011-08-03 08:28:40 UTC (rev 92265)
@@ -1009,7 +1009,7 @@
ASSERT_ARG(node, node);
m_highlightedNode = node;
m_highlightMode = mode;
- m_client->highlight(node);
+ m_client->highlight();
}
void InspectorDOMAgent::highlightNode(ErrorString* error, int nodeId, String* mode)
Modified: trunk/Source/WebCore/loader/EmptyClients.h (92264 => 92265)
--- trunk/Source/WebCore/loader/EmptyClients.h 2011-08-03 08:20:41 UTC (rev 92264)
+++ trunk/Source/WebCore/loader/EmptyClients.h 2011-08-03 08:28:40 UTC (rev 92265)
@@ -589,7 +589,7 @@
virtual void openInspectorFrontend(InspectorController*) { }
- virtual void highlight(Node*) { }
+ virtual void highlight() { }
virtual void hideHighlight() { }
virtual bool sendMessageToFrontend(const String&) { return false; }
Modified: trunk/Source/WebKit/chromium/ChangeLog (92264 => 92265)
--- trunk/Source/WebKit/chromium/ChangeLog 2011-08-03 08:20:41 UTC (rev 92264)
+++ trunk/Source/WebKit/chromium/ChangeLog 2011-08-03 08:28:40 UTC (rev 92265)
@@ -1,3 +1,17 @@
+2011-08-03 Pavel Feldman <[email protected]>
+
+ Web Inspector: remove Node parameter from the InspectorClient::highlight
+ https://bugs.webkit.org/show_bug.cgi?id=65549
+
+ Reviewed by Yury Semikhatsky.
+
+ * src/InspectorClientImpl.cpp:
+ (WebKit::InspectorClientImpl::highlight):
+ * src/InspectorClientImpl.h:
+ * src/WebDevToolsAgentImpl.cpp:
+ (WebKit::WebDevToolsAgentImpl::highlight):
+ * src/WebDevToolsAgentImpl.h:
+
2011-08-02 David Reveman <[email protected]>
[Chromium] Remove outer border from TilingData as it's no longer needed by layer compositor for anti-aliasing.
Modified: trunk/Source/WebKit/chromium/src/InspectorClientImpl.cpp (92264 => 92265)
--- trunk/Source/WebKit/chromium/src/InspectorClientImpl.cpp 2011-08-03 08:20:41 UTC (rev 92264)
+++ trunk/Source/WebKit/chromium/src/InspectorClientImpl.cpp 2011-08-03 08:28:40 UTC (rev 92265)
@@ -69,10 +69,10 @@
agent->openInspectorFrontend(controller);
}
-void InspectorClientImpl::highlight(Node* node)
+void InspectorClientImpl::highlight()
{
if (WebDevToolsAgentImpl* agent = devToolsAgent())
- agent->highlight(node);
+ agent->highlight();
}
void InspectorClientImpl::hideHighlight()
Modified: trunk/Source/WebKit/chromium/src/InspectorClientImpl.h (92264 => 92265)
--- trunk/Source/WebKit/chromium/src/InspectorClientImpl.h 2011-08-03 08:20:41 UTC (rev 92264)
+++ trunk/Source/WebKit/chromium/src/InspectorClientImpl.h 2011-08-03 08:28:40 UTC (rev 92265)
@@ -50,7 +50,7 @@
virtual void inspectorDestroyed();
virtual void openInspectorFrontend(WebCore::InspectorController*);
- virtual void highlight(WebCore::Node*);
+ virtual void highlight();
virtual void hideHighlight();
virtual bool sendMessageToFrontend(const WTF::String&);
Modified: trunk/Source/WebKit/chromium/src/WebDevToolsAgentImpl.cpp (92264 => 92265)
--- trunk/Source/WebKit/chromium/src/WebDevToolsAgentImpl.cpp 2011-08-03 08:20:41 UTC (rev 92264)
+++ trunk/Source/WebKit/chromium/src/WebDevToolsAgentImpl.cpp 2011-08-03 08:28:40 UTC (rev 92265)
@@ -282,7 +282,7 @@
ic->drawNodeHighlight(gc);
}
-void WebDevToolsAgentImpl::highlight(Node* node)
+void WebDevToolsAgentImpl::highlight()
{
m_webViewImpl->setPageOverlayClient(this);
}
Modified: trunk/Source/WebKit/chromium/src/WebDevToolsAgentImpl.h (92264 => 92265)
--- trunk/Source/WebKit/chromium/src/WebDevToolsAgentImpl.h 2011-08-03 08:20:41 UTC (rev 92264)
+++ trunk/Source/WebKit/chromium/src/WebDevToolsAgentImpl.h 2011-08-03 08:28:40 UTC (rev 92265)
@@ -86,7 +86,7 @@
// InspectorClient implementation.
virtual void inspectorDestroyed();
virtual void openInspectorFrontend(WebCore::InspectorController*);
- virtual void highlight(WebCore::Node*);
+ virtual void highlight();
virtual void hideHighlight();
virtual void updateInspectorStateCookie(const WTF::String&);
virtual bool sendMessageToFrontend(const WTF::String&);
Modified: trunk/Source/WebKit/efl/ChangeLog (92264 => 92265)
--- trunk/Source/WebKit/efl/ChangeLog 2011-08-03 08:20:41 UTC (rev 92264)
+++ trunk/Source/WebKit/efl/ChangeLog 2011-08-03 08:28:40 UTC (rev 92265)
@@ -1,3 +1,14 @@
+2011-08-03 Pavel Feldman <[email protected]>
+
+ Web Inspector: remove Node parameter from the InspectorClient::highlight
+ https://bugs.webkit.org/show_bug.cgi?id=65549
+
+ Reviewed by Yury Semikhatsky.
+
+ * WebCoreSupport/InspectorClientEfl.cpp:
+ (WebCore::InspectorClientEfl::highlight):
+ * WebCoreSupport/InspectorClientEfl.h:
+
2011-08-02 Raphael Kubo da Costa <[email protected]>
[EFL] Ignore empty requests on policy decisions.
Modified: trunk/Source/WebKit/efl/WebCoreSupport/InspectorClientEfl.cpp (92264 => 92265)
--- trunk/Source/WebKit/efl/WebCoreSupport/InspectorClientEfl.cpp 2011-08-03 08:20:41 UTC (rev 92264)
+++ trunk/Source/WebKit/efl/WebCoreSupport/InspectorClientEfl.cpp 2011-08-03 08:28:40 UTC (rev 92265)
@@ -38,7 +38,7 @@
notImplemented();
}
-void InspectorClientEfl::highlight(Node* node)
+void InspectorClientEfl::highlight()
{
notImplemented();
}
Modified: trunk/Source/WebKit/efl/WebCoreSupport/InspectorClientEfl.h (92264 => 92265)
--- trunk/Source/WebKit/efl/WebCoreSupport/InspectorClientEfl.h 2011-08-03 08:20:41 UTC (rev 92264)
+++ trunk/Source/WebKit/efl/WebCoreSupport/InspectorClientEfl.h 2011-08-03 08:28:40 UTC (rev 92265)
@@ -36,7 +36,6 @@
#include <wtf/Forward.h>
namespace WebCore {
-class Node;
class Page;
class InspectorClientEfl : public WebCore::InspectorClient {
@@ -45,7 +44,7 @@
virtual void openInspectorFrontend(InspectorController*);
- virtual void highlight(Node*);
+ virtual void highlight();
virtual void hideHighlight();
virtual void populateSetting(const String& key, String* value);
Modified: trunk/Source/WebKit/gtk/ChangeLog (92264 => 92265)
--- trunk/Source/WebKit/gtk/ChangeLog 2011-08-03 08:20:41 UTC (rev 92264)
+++ trunk/Source/WebKit/gtk/ChangeLog 2011-08-03 08:28:40 UTC (rev 92265)
@@ -1,3 +1,14 @@
+2011-08-03 Pavel Feldman <[email protected]>
+
+ Web Inspector: remove Node parameter from the InspectorClient::highlight
+ https://bugs.webkit.org/show_bug.cgi?id=65549
+
+ Reviewed by Yury Semikhatsky.
+
+ * WebCoreSupport/InspectorClientGtk.cpp:
+ (WebKit::InspectorClient::highlight):
+ * WebCoreSupport/InspectorClientGtk.h:
+
2011-08-03 Carlos Garcia Campos <[email protected]>
[GTK] Reorganize pkg-config files
Modified: trunk/Source/WebKit/gtk/WebCoreSupport/InspectorClientGtk.cpp (92264 => 92265)
--- trunk/Source/WebKit/gtk/WebCoreSupport/InspectorClientGtk.cpp 2011-08-03 08:20:41 UTC (rev 92264)
+++ trunk/Source/WebKit/gtk/WebCoreSupport/InspectorClientGtk.cpp 2011-08-03 08:28:40 UTC (rev 92265)
@@ -161,7 +161,7 @@
m_frontendPage = 0;
}
-void InspectorClient::highlight(Node*)
+void InspectorClient::highlight()
{
hideHighlight();
}
Modified: trunk/Source/WebKit/gtk/WebCoreSupport/InspectorClientGtk.h (92264 => 92265)
--- trunk/Source/WebKit/gtk/WebCoreSupport/InspectorClientGtk.h 2011-08-03 08:20:41 UTC (rev 92264)
+++ trunk/Source/WebKit/gtk/WebCoreSupport/InspectorClientGtk.h 2011-08-03 08:28:40 UTC (rev 92265)
@@ -37,7 +37,6 @@
#include <wtf/Forward.h>
namespace WebCore {
- class Node;
class Page;
}
@@ -56,7 +55,7 @@
virtual void openInspectorFrontend(WebCore::InspectorController*);
- virtual void highlight(WebCore::Node*);
+ virtual void highlight();
virtual void hideHighlight();
virtual bool sendMessageToFrontend(const WTF::String&);
Modified: trunk/Source/WebKit/haiku/ChangeLog (92264 => 92265)
--- trunk/Source/WebKit/haiku/ChangeLog 2011-08-03 08:20:41 UTC (rev 92264)
+++ trunk/Source/WebKit/haiku/ChangeLog 2011-08-03 08:28:40 UTC (rev 92265)
@@ -1,3 +1,14 @@
+2011-08-03 Pavel Feldman <[email protected]>
+
+ Web Inspector: remove Node parameter from the InspectorClient::highlight
+ https://bugs.webkit.org/show_bug.cgi?id=65549
+
+ Reviewed by Yury Semikhatsky.
+
+ * WebCoreSupport/InspectorClientHaiku.cpp:
+ (WebCore::InspectorClientHaiku::highlight):
+ * WebCoreSupport/InspectorClientHaiku.h:
+
2011-07-26 Sadrul Habib Chowdhury <[email protected]>
Add support for download='filename' attribute in anchors.
Modified: trunk/Source/WebKit/haiku/WebCoreSupport/InspectorClientHaiku.cpp (92264 => 92265)
--- trunk/Source/WebKit/haiku/WebCoreSupport/InspectorClientHaiku.cpp 2011-08-03 08:20:41 UTC (rev 92264)
+++ trunk/Source/WebKit/haiku/WebCoreSupport/InspectorClientHaiku.cpp 2011-08-03 08:28:40 UTC (rev 92265)
@@ -47,7 +47,7 @@
notImplemented();
}
-void InspectorClientHaiku::highlight(Node* node)
+void InspectorClientHaiku::highlight()
{
notImplemented();
}
Modified: trunk/Source/WebKit/haiku/WebCoreSupport/InspectorClientHaiku.h (92264 => 92265)
--- trunk/Source/WebKit/haiku/WebCoreSupport/InspectorClientHaiku.h 2011-08-03 08:20:41 UTC (rev 92264)
+++ trunk/Source/WebKit/haiku/WebCoreSupport/InspectorClientHaiku.h 2011-08-03 08:28:40 UTC (rev 92265)
@@ -43,7 +43,7 @@
virtual void openInspectorFrontend(WebCore::InspectorController*);
- virtual void highlight(Node*);
+ virtual void highlight();
virtual void hideHighlight();
virtual void populateSetting(const WTF::String& key, WTF::String* value);
Modified: trunk/Source/WebKit/mac/ChangeLog (92264 => 92265)
--- trunk/Source/WebKit/mac/ChangeLog 2011-08-03 08:20:41 UTC (rev 92264)
+++ trunk/Source/WebKit/mac/ChangeLog 2011-08-03 08:28:40 UTC (rev 92265)
@@ -1,3 +1,17 @@
+2011-08-03 Pavel Feldman <[email protected]>
+
+ Web Inspector: remove Node parameter from the InspectorClient::highlight
+ https://bugs.webkit.org/show_bug.cgi?id=65549
+
+ Reviewed by Yury Semikhatsky.
+
+ * WebCoreSupport/WebInspectorClient.h:
+ * WebCoreSupport/WebInspectorClient.mm:
+ (WebInspectorClient::highlight):
+ * WebInspector/WebNodeHighlighter.h:
+ * WebInspector/WebNodeHighlighter.mm:
+ (-[WebNodeHighlighter highlight]):
+
2011-07-30 Patrick Gansterer <[email protected]>
Remove inclusion of MainThread.h from Threading.h
Modified: trunk/Source/WebKit/mac/WebCoreSupport/WebInspectorClient.h (92264 => 92265)
--- trunk/Source/WebKit/mac/WebCoreSupport/WebInspectorClient.h 2011-08-03 08:20:41 UTC (rev 92264)
+++ trunk/Source/WebKit/mac/WebCoreSupport/WebInspectorClient.h 2011-08-03 08:28:40 UTC (rev 92265)
@@ -59,7 +59,7 @@
virtual void openInspectorFrontend(WebCore::InspectorController*);
- virtual void highlight(WebCore::Node*);
+ virtual void highlight();
virtual void hideHighlight();
virtual bool sendMessageToFrontend(const WTF::String&);
Modified: trunk/Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm (92264 => 92265)
--- trunk/Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm 2011-08-03 08:20:41 UTC (rev 92264)
+++ trunk/Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm 2011-08-03 08:28:40 UTC (rev 92265)
@@ -97,9 +97,9 @@
m_frontendPage->inspectorController()->setInspectorFrontendClient(frontendClient.release());
}
-void WebInspectorClient::highlight(Node* node)
+void WebInspectorClient::highlight()
{
- [m_highlighter.get() highlightNode:kit(node)];
+ [m_highlighter.get() highlight];
}
void WebInspectorClient::hideHighlight()
Modified: trunk/Source/WebKit/mac/WebInspector/WebNodeHighlighter.h (92264 => 92265)
--- trunk/Source/WebKit/mac/WebInspector/WebNodeHighlighter.h 2011-08-03 08:20:41 UTC (rev 92264)
+++ trunk/Source/WebKit/mac/WebInspector/WebNodeHighlighter.h 2011-08-03 08:28:40 UTC (rev 92265)
@@ -36,6 +36,6 @@
WebNodeHighlight *_currentHighlight;
}
- (id)initWithInspectedWebView:(WebView *)webView;
-- (void)highlightNode:(DOMNode *)node;
+- (void)highlight;
- (void)hideHighlight;
@end
Modified: trunk/Source/WebKit/mac/WebInspector/WebNodeHighlighter.mm (92264 => 92265)
--- trunk/Source/WebKit/mac/WebInspector/WebNodeHighlighter.mm 2011-08-03 08:20:41 UTC (rev 92264)
+++ trunk/Source/WebKit/mac/WebInspector/WebNodeHighlighter.mm 2011-08-03 08:28:40 UTC (rev 92265)
@@ -54,7 +54,7 @@
// MARK: -
-- (void)highlightNode:(DOMNode *)node
+- (void)highlight
{
// The scrollview's content view stays around between page navigations, so target it.
NSView *view = [[[[[_inspectedWebView mainFrame] frameView] documentView] enclosingScrollView] contentView];
Modified: trunk/Source/WebKit/qt/ChangeLog (92264 => 92265)
--- trunk/Source/WebKit/qt/ChangeLog 2011-08-03 08:20:41 UTC (rev 92264)
+++ trunk/Source/WebKit/qt/ChangeLog 2011-08-03 08:28:40 UTC (rev 92265)
@@ -1,3 +1,14 @@
+2011-08-03 Pavel Feldman <[email protected]>
+
+ Web Inspector: remove Node parameter from the InspectorClient::highlight
+ https://bugs.webkit.org/show_bug.cgi?id=65549
+
+ Reviewed by Yury Semikhatsky.
+
+ * WebCoreSupport/InspectorClientQt.cpp:
+ (WebCore::InspectorClientQt::highlight):
+ * WebCoreSupport/InspectorClientQt.h:
+
2011-08-02 Kristóf Kosztyó <[email protected]>
[Qt] Fix tst_QDeclarativeWebView::basicProperties() and historyNav() autotests
Modified: trunk/Source/WebKit/qt/WebCoreSupport/InspectorClientQt.cpp (92264 => 92265)
--- trunk/Source/WebKit/qt/WebCoreSupport/InspectorClientQt.cpp 2011-08-03 08:20:41 UTC (rev 92264)
+++ trunk/Source/WebKit/qt/WebCoreSupport/InspectorClientQt.cpp 2011-08-03 08:28:40 UTC (rev 92265)
@@ -265,7 +265,7 @@
#endif
}
-void InspectorClientQt::highlight(Node*)
+void InspectorClientQt::highlight()
{
hideHighlight();
}
Modified: trunk/Source/WebKit/qt/WebCoreSupport/InspectorClientQt.h (92264 => 92265)
--- trunk/Source/WebKit/qt/WebCoreSupport/InspectorClientQt.h 2011-08-03 08:20:41 UTC (rev 92264)
+++ trunk/Source/WebKit/qt/WebCoreSupport/InspectorClientQt.h 2011-08-03 08:28:40 UTC (rev 92265)
@@ -43,7 +43,6 @@
namespace WebCore {
class InspectorFrontendClientQt;
class InspectorServerRequestHandlerQt;
-class Node;
class Page;
class RemoteFrontendChannel;
@@ -55,7 +54,7 @@
virtual void openInspectorFrontend(WebCore::InspectorController*);
- virtual void highlight(Node*);
+ virtual void highlight();
virtual void hideHighlight();
virtual bool sendMessageToFrontend(const String&);
Modified: trunk/Source/WebKit/win/ChangeLog (92264 => 92265)
--- trunk/Source/WebKit/win/ChangeLog 2011-08-03 08:20:41 UTC (rev 92264)
+++ trunk/Source/WebKit/win/ChangeLog 2011-08-03 08:28:40 UTC (rev 92265)
@@ -1,3 +1,14 @@
+2011-08-03 Pavel Feldman <[email protected]>
+
+ Web Inspector: remove Node parameter from the InspectorClient::highlight
+ https://bugs.webkit.org/show_bug.cgi?id=65549
+
+ Reviewed by Yury Semikhatsky.
+
+ * WebCoreSupport/WebInspectorClient.cpp:
+ (WebInspectorClient::highlight):
+ * WebCoreSupport/WebInspectorClient.h:
+
2011-07-31 Daniel Bates <[email protected]>
Attempt to fix the WinCairo Debug build after r92059 (https://bugs.webkit.org/show_bug.cgi?id=65419).
Modified: trunk/Source/WebKit/win/WebCoreSupport/WebInspectorClient.cpp (92264 => 92265)
--- trunk/Source/WebKit/win/WebCoreSupport/WebInspectorClient.cpp 2011-08-03 08:20:41 UTC (rev 92264)
+++ trunk/Source/WebKit/win/WebCoreSupport/WebInspectorClient.cpp 2011-08-03 08:28:40 UTC (rev 92265)
@@ -175,7 +175,7 @@
m_frontendHwnd = frontendHwnd;
}
-void WebInspectorClient::highlight(Node*)
+void WebInspectorClient::highlight()
{
bool creatingHighlight = !m_highlight;
Modified: trunk/Source/WebKit/win/WebCoreSupport/WebInspectorClient.h (92264 => 92265)
--- trunk/Source/WebKit/win/WebCoreSupport/WebInspectorClient.h 2011-08-03 08:20:41 UTC (rev 92264)
+++ trunk/Source/WebKit/win/WebCoreSupport/WebInspectorClient.h 2011-08-03 08:28:40 UTC (rev 92265)
@@ -58,7 +58,7 @@
virtual void openInspectorFrontend(WebCore::InspectorController*);
- virtual void highlight(WebCore::Node*);
+ virtual void highlight();
virtual void hideHighlight();
virtual bool sendMessageToFrontend(const WTF::String&);
Modified: trunk/Source/WebKit/wince/ChangeLog (92264 => 92265)
--- trunk/Source/WebKit/wince/ChangeLog 2011-08-03 08:20:41 UTC (rev 92264)
+++ trunk/Source/WebKit/wince/ChangeLog 2011-08-03 08:28:40 UTC (rev 92265)
@@ -1,3 +1,14 @@
+2011-08-03 Pavel Feldman <[email protected]>
+
+ Web Inspector: remove Node parameter from the InspectorClient::highlight
+ https://bugs.webkit.org/show_bug.cgi?id=65549
+
+ Reviewed by Yury Semikhatsky.
+
+ * WebCoreSupport/InspectorClientWinCE.cpp:
+ (WebKit::InspectorClientWinCE::highlight):
+ * WebCoreSupport/InspectorClientWinCE.h:
+
2011-07-26 Sadrul Habib Chowdhury <[email protected]>
Add support for download='filename' attribute in anchors.
Modified: trunk/Source/WebKit/wince/WebCoreSupport/InspectorClientWinCE.cpp (92264 => 92265)
--- trunk/Source/WebKit/wince/WebCoreSupport/InspectorClientWinCE.cpp 2011-08-03 08:20:41 UTC (rev 92264)
+++ trunk/Source/WebKit/wince/WebCoreSupport/InspectorClientWinCE.cpp 2011-08-03 08:28:40 UTC (rev 92265)
@@ -55,7 +55,7 @@
notImplemented();
}
-void InspectorClientWinCE::highlight(Node* node)
+void InspectorClientWinCE::highlight()
{
notImplemented();
}
Modified: trunk/Source/WebKit/wince/WebCoreSupport/InspectorClientWinCE.h (92264 => 92265)
--- trunk/Source/WebKit/wince/WebCoreSupport/InspectorClientWinCE.h 2011-08-03 08:20:41 UTC (rev 92264)
+++ trunk/Source/WebKit/wince/WebCoreSupport/InspectorClientWinCE.h 2011-08-03 08:28:40 UTC (rev 92265)
@@ -40,7 +40,7 @@
virtual void openInspectorFrontend(WebCore::InspectorController*);
- virtual void highlight(WebCore::Node*);
+ virtual void highlight();
virtual void hideHighlight();
virtual void populateSetting(const WTF::String& key, WTF::String* value);
Modified: trunk/Source/WebKit/wx/ChangeLog (92264 => 92265)
--- trunk/Source/WebKit/wx/ChangeLog 2011-08-03 08:20:41 UTC (rev 92264)
+++ trunk/Source/WebKit/wx/ChangeLog 2011-08-03 08:28:40 UTC (rev 92265)
@@ -1,3 +1,14 @@
+2011-08-03 Pavel Feldman <[email protected]>
+
+ Web Inspector: remove Node parameter from the InspectorClient::highlight
+ https://bugs.webkit.org/show_bug.cgi?id=65549
+
+ Reviewed by Yury Semikhatsky.
+
+ * WebKitSupport/InspectorClientWx.cpp:
+ (WebCore::InspectorClientWx::highlight):
+ * WebKitSupport/InspectorClientWx.h:
+
2011-07-30 Patrick Gansterer <[email protected]>
Remove inclusion of MainThread.h from Threading.h
Modified: trunk/Source/WebKit/wx/WebKitSupport/InspectorClientWx.cpp (92264 => 92265)
--- trunk/Source/WebKit/wx/WebKitSupport/InspectorClientWx.cpp 2011-08-03 08:20:41 UTC (rev 92264)
+++ trunk/Source/WebKit/wx/WebKitSupport/InspectorClientWx.cpp 2011-08-03 08:28:40 UTC (rev 92265)
@@ -52,7 +52,7 @@
notImplemented();
}
-void InspectorClientWx::highlight(Node*)
+void InspectorClientWx::highlight()
{
notImplemented();
}
Modified: trunk/Source/WebKit/wx/WebKitSupport/InspectorClientWx.h (92264 => 92265)
--- trunk/Source/WebKit/wx/WebKitSupport/InspectorClientWx.h 2011-08-03 08:20:41 UTC (rev 92264)
+++ trunk/Source/WebKit/wx/WebKitSupport/InspectorClientWx.h 2011-08-03 08:28:40 UTC (rev 92265)
@@ -31,7 +31,6 @@
namespace WebCore {
-class Node;
class Page;
class InspectorClientWx : public InspectorClient {
@@ -43,7 +42,7 @@
virtual void openInspectorFrontend(WebCore::InspectorController*);
- virtual void highlight(Node*);
+ virtual void highlight();
virtual void hideHighlight();
virtual void populateSetting(const String& key, String* value);
Modified: trunk/Source/WebKit2/ChangeLog (92264 => 92265)
--- trunk/Source/WebKit2/ChangeLog 2011-08-03 08:20:41 UTC (rev 92264)
+++ trunk/Source/WebKit2/ChangeLog 2011-08-03 08:28:40 UTC (rev 92265)
@@ -1,3 +1,14 @@
+2011-08-03 Pavel Feldman <[email protected]>
+
+ Web Inspector: remove Node parameter from the InspectorClient::highlight
+ https://bugs.webkit.org/show_bug.cgi?id=65549
+
+ Reviewed by Yury Semikhatsky.
+
+ * WebProcess/WebCoreSupport/WebInspectorClient.cpp:
+ (WebKit::WebInspectorClient::highlight):
+ * WebProcess/WebCoreSupport/WebInspectorClient.h:
+
2011-08-03 Carlos Garcia Campos <[email protected]>
[GTK] Reorganize pkg-config files
Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebInspectorClient.cpp (92264 => 92265)
--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebInspectorClient.cpp 2011-08-03 08:20:41 UTC (rev 92264)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebInspectorClient.cpp 2011-08-03 08:28:40 UTC (rev 92265)
@@ -54,7 +54,7 @@
inspectorPage->corePage()->inspectorController()->setInspectorFrontendClient(adoptPtr(new WebInspectorFrontendClient(m_page, inspectorPage)));
}
-void WebInspectorClient::highlight(Node*)
+void WebInspectorClient::highlight()
{
if (!m_highlightOverlay) {
RefPtr<PageOverlay> highlightOverlay = PageOverlay::create(this);
Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebInspectorClient.h (92264 => 92265)
--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebInspectorClient.h 2011-08-03 08:20:41 UTC (rev 92264)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebInspectorClient.h 2011-08-03 08:28:40 UTC (rev 92265)
@@ -54,7 +54,7 @@
virtual void openInspectorFrontend(WebCore::InspectorController*);
- virtual void highlight(WebCore::Node*);
+ virtual void highlight();
virtual void hideHighlight();
virtual bool sendMessageToFrontend(const String&);
