Diff
Modified: trunk/Source/WebCore/ChangeLog (92299 => 92300)
--- trunk/Source/WebCore/ChangeLog 2011-08-03 19:06:48 UTC (rev 92299)
+++ trunk/Source/WebCore/ChangeLog 2011-08-03 19:09:34 UTC (rev 92300)
@@ -1,3 +1,22 @@
+2011-08-03 Joseph Pecoraro <[email protected]>
+
+ Web Inspector: Remove InspectorFrontendHost load/saveSessionSetting
+ https://bugs.webkit.org/show_bug.cgi?id=65582
+
+ Reviewed by Pavel Feldman.
+
+ Remove stale code. WebInspector.settings uses localStorage and
+ handles the "debuggerEnabled" state. So remove the only remaining
+ usage of load/saveSessionSetting.
+
+ * inspector/InspectorFrontendClient.h:
+ * inspector/InspectorFrontendHost.cpp:
+ * inspector/InspectorFrontendHost.h:
+ * inspector/InspectorFrontendHost.idl:
+ * inspector/front-end/InspectorFrontendHostStub.js:
+ * inspector/front-end/ScriptsPanel.js:
+ (WebInspector.ScriptsPanel.prototype._debuggerWasDisabled):
+
2011-08-03 Adam Barth <[email protected]>
Crash in DocumentWriter::endIfNotLoadingMainResource
Modified: trunk/Source/WebCore/inspector/InspectorFrontendClient.h (92299 => 92300)
--- trunk/Source/WebCore/inspector/InspectorFrontendClient.h 2011-08-03 19:06:48 UTC (rev 92299)
+++ trunk/Source/WebCore/inspector/InspectorFrontendClient.h 2011-08-03 19:09:34 UTC (rev 92300)
@@ -63,9 +63,6 @@
virtual void inspectedURLChanged(const String&) = 0;
virtual void sendMessageToBackend(const String&) = 0;
-
- virtual void saveSessionSetting(const String&, const String&) { }
- virtual void loadSessionSetting(const String&, String*) { }
};
} // namespace WebCore
Modified: trunk/Source/WebCore/inspector/InspectorFrontendHost.cpp (92299 => 92300)
--- trunk/Source/WebCore/inspector/InspectorFrontendHost.cpp 2011-08-03 19:06:48 UTC (rev 92299)
+++ trunk/Source/WebCore/inspector/InspectorFrontendHost.cpp 2011-08-03 19:09:34 UTC (rev 92300)
@@ -228,20 +228,6 @@
m_client->saveAs(fileName, content);
}
-void InspectorFrontendHost::saveSessionSetting(const String& key, const String& value)
-{
- if (m_client)
- m_client->saveSessionSetting(key, value);
-}
-
-String InspectorFrontendHost::loadSessionSetting(const String& key)
-{
- String value;
- if (m_client)
- m_client->loadSessionSetting(key, &value);
- return value;
-}
-
void InspectorFrontendHost::sendMessageToBackend(const String& message)
{
if (m_client)
Modified: trunk/Source/WebCore/inspector/InspectorFrontendHost.h (92299 => 92300)
--- trunk/Source/WebCore/inspector/InspectorFrontendHost.h 2011-08-03 19:06:48 UTC (rev 92299)
+++ trunk/Source/WebCore/inspector/InspectorFrontendHost.h 2011-08-03 19:09:34 UTC (rev 92300)
@@ -75,9 +75,6 @@
void copyText(const String& text);
void saveAs(const String& fileName, const String& content);
- void saveSessionSetting(const String& key, const String& value);
- String loadSessionSetting(const String& key);
-
// Called from [Custom] implementations.
void showContextMenu(Event*, const Vector<ContextMenuItem*>& items);
void sendMessageToBackend(const String& message);
Modified: trunk/Source/WebCore/inspector/InspectorFrontendHost.idl (92299 => 92300)
--- trunk/Source/WebCore/inspector/InspectorFrontendHost.idl 2011-08-03 19:06:48 UTC (rev 92299)
+++ trunk/Source/WebCore/inspector/InspectorFrontendHost.idl 2011-08-03 19:09:34 UTC (rev 92300)
@@ -50,9 +50,6 @@
DOMString localizedStringsURL();
DOMString hiddenPanels();
- void saveSessionSetting(in DOMString key, in DOMString value);
- DOMString loadSessionSetting(in DOMString key);
-
void copyText(in DOMString text);
void saveAs(in DOMString fileName, in DOMString content);
Modified: trunk/Source/WebCore/inspector/front-end/InspectorFrontendHostStub.js (92299 => 92300)
--- trunk/Source/WebCore/inspector/front-end/InspectorFrontendHostStub.js 2011-08-03 19:06:48 UTC (rev 92299)
+++ trunk/Source/WebCore/inspector/front-end/InspectorFrontendHostStub.js 2011-08-03 19:09:34 UTC (rev 92300)
@@ -138,14 +138,6 @@
{
},
- saveSessionSetting: function(key, value)
- {
- },
-
- loadSessionSetting: function(key)
- {
- },
-
recordActionTaken: function(actionCode)
{
},
Modified: trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js (92299 => 92300)
--- trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js 2011-08-03 19:06:48 UTC (rev 92299)
+++ trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js 2011-08-03 19:09:34 UTC (rev 92300)
@@ -167,7 +167,7 @@
this._presentationModel.addEventListener(WebInspector.DebuggerPresentationModel.Events.CallFrameSelected, this._callFrameSelected, this);
var enableDebugger = Preferences.debuggerAlwaysEnabled || WebInspector.settings.debuggerEnabled.get();
- if (enableDebugger || InspectorFrontendHost.loadSessionSetting("debugger-enabled") === "true")
+ if (enableDebugger)
WebInspector.debuggerModel.enableDebugger();
}
@@ -478,7 +478,6 @@
if (this._debuggerEnabled)
return;
- InspectorFrontendHost.saveSessionSetting("debugger-enabled", "true");
this._debuggerEnabled = true;
this.reset(true);
},
@@ -488,7 +487,6 @@
if (!this._debuggerEnabled)
return;
- InspectorFrontendHost.saveSessionSetting("debugger-enabled", "false");
this._debuggerEnabled = false;
this.reset(true);
},
Modified: trunk/Source/WebKit/cf/ChangeLog (92299 => 92300)
--- trunk/Source/WebKit/cf/ChangeLog 2011-08-03 19:06:48 UTC (rev 92299)
+++ trunk/Source/WebKit/cf/ChangeLog 2011-08-03 19:09:34 UTC (rev 92300)
@@ -1,3 +1,12 @@
+2011-08-03 Joseph Pecoraro <[email protected]>
+
+ Web Inspector: Remove InspectorFrontendHost load/saveSessionSetting
+ https://bugs.webkit.org/show_bug.cgi?id=65582
+
+ Reviewed by Pavel Feldman.
+
+ * WebCoreSupport/WebInspectorClientCF.cpp:
+
2011-03-15 Kevin Ollivier <[email protected]>
Reviewed by Darin Adler.
Modified: trunk/Source/WebKit/cf/WebCoreSupport/WebInspectorClientCF.cpp (92299 => 92300)
--- trunk/Source/WebKit/cf/WebCoreSupport/WebInspectorClientCF.cpp 2011-08-03 19:06:48 UTC (rev 92299)
+++ trunk/Source/WebKit/cf/WebCoreSupport/WebInspectorClientCF.cpp 2011-08-03 19:09:34 UTC (rev 92300)
@@ -131,18 +131,6 @@
m_frontendPage = 0;
}
-void WebInspectorClient::saveSessionSetting(const String& key, const String& value)
-{
- if (!key.isEmpty())
- m_sessionSettings.set(key, value);
-}
-
-void WebInspectorClient::loadSessionSetting(const String& key, String* value)
-{
- if (!key.isEmpty())
- *value = m_sessionSettings.get(key);
-}
-
WTF::PassOwnPtr<WebCore::InspectorFrontendClientLocal::Settings> WebInspectorClient::createFrontendSettings()
{
class InspectorFrontendSettingsCF : public WebCore::InspectorFrontendClientLocal::Settings {
Modified: trunk/Source/WebKit/mac/ChangeLog (92299 => 92300)
--- trunk/Source/WebKit/mac/ChangeLog 2011-08-03 19:06:48 UTC (rev 92299)
+++ trunk/Source/WebKit/mac/ChangeLog 2011-08-03 19:09:34 UTC (rev 92300)
@@ -1,3 +1,13 @@
+2011-08-03 Joseph Pecoraro <[email protected]>
+
+ Web Inspector: Remove InspectorFrontendHost load/saveSessionSetting
+ https://bugs.webkit.org/show_bug.cgi?id=65582
+
+ Reviewed by Pavel Feldman.
+
+ * WebCoreSupport/WebInspectorClient.h:
+ * WebCoreSupport/WebInspectorClient.mm:
+
2011-08-03 Pavel Feldman <[email protected]>
Web Inspector: [Timeline] Hover on paint events and see rect outline around that area.
Modified: trunk/Source/WebKit/mac/WebCoreSupport/WebInspectorClient.h (92299 => 92300)
--- trunk/Source/WebKit/mac/WebCoreSupport/WebInspectorClient.h 2011-08-03 19:06:48 UTC (rev 92299)
+++ trunk/Source/WebKit/mac/WebCoreSupport/WebInspectorClient.h 2011-08-03 19:09:34 UTC (rev 92300)
@@ -69,17 +69,12 @@
void releaseFrontendPage();
- void saveSessionSetting(const String& key, const String& value);
- void loadSessionSetting(const String& key, String* value);
-
private:
WTF::PassOwnPtr<WebCore::InspectorFrontendClientLocal::Settings> createFrontendSettings();
WebView *m_webView;
RetainPtr<WebNodeHighlighter> m_highlighter;
WebCore::Page* m_frontendPage;
-
- WTF::HashMap<WTF::String, WTF::String> m_sessionSettings;
};
@@ -102,9 +97,6 @@
virtual void setAttachedWindowHeight(unsigned height);
virtual void inspectedURLChanged(const WTF::String& newURL);
- virtual void saveSessionSetting(const String& key, const String& value);
- virtual void loadSessionSetting(const String& key, String* value);
-
private:
void updateWindowTitle() const;
Modified: trunk/Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm (92299 => 92300)
--- trunk/Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm 2011-08-03 19:06:48 UTC (rev 92299)
+++ trunk/Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm 2011-08-03 19:09:34 UTC (rev 92300)
@@ -190,20 +190,6 @@
updateWindowTitle();
}
-void WebInspectorFrontendClient::saveSessionSetting(const String& key, const String& value)
-{
- WebInspectorClient* client = [m_windowController.get() inspectorClient];
- if (client)
- client->saveSessionSetting(key, value);
-}
-
-void WebInspectorFrontendClient::loadSessionSetting(const String& key, String* value)
-{
- WebInspectorClient* client = [m_windowController.get() inspectorClient];
- if (client)
- client->loadSessionSetting(key, value);
-}
-
void WebInspectorFrontendClient::updateWindowTitle() const
{
NSString *title = [NSString stringWithFormat:UI_STRING_INTERNAL("Web Inspector — %@", "Web Inspector window title"), (NSString *)m_inspectedURL];
Modified: trunk/Source/WebKit/win/ChangeLog (92299 => 92300)
--- trunk/Source/WebKit/win/ChangeLog 2011-08-03 19:06:48 UTC (rev 92299)
+++ trunk/Source/WebKit/win/ChangeLog 2011-08-03 19:09:34 UTC (rev 92300)
@@ -1,3 +1,13 @@
+2011-08-03 Joseph Pecoraro <[email protected]>
+
+ Web Inspector: Remove InspectorFrontendHost load/saveSessionSetting
+ https://bugs.webkit.org/show_bug.cgi?id=65582
+
+ Reviewed by Pavel Feldman.
+
+ * WebCoreSupport/WebInspectorClient.cpp:
+ * WebCoreSupport/WebInspectorClient.h:
+
2011-08-03 Adam Roben <[email protected]>
Windows nightly build fix after r91777
Modified: trunk/Source/WebKit/win/WebCoreSupport/WebInspectorClient.cpp (92299 => 92300)
--- trunk/Source/WebKit/win/WebCoreSupport/WebInspectorClient.cpp 2011-08-03 19:06:48 UTC (rev 92299)
+++ trunk/Source/WebKit/win/WebCoreSupport/WebInspectorClient.cpp 2011-08-03 19:09:34 UTC (rev 92300)
@@ -319,16 +319,6 @@
updateWindowTitle();
}
-void WebInspectorFrontendClient::saveSessionSetting(const String& key, const String& value)
-{
- m_inspectorClient->saveSessionSetting(key, value);
-}
-
-void WebInspectorFrontendClient::loadSessionSetting(const String& key, String* value)
-{
- m_inspectorClient->loadSessionSetting(key, value);
-}
-
void WebInspectorFrontendClient::closeWindowWithoutNotifications()
{
if (!m_frontendHwnd)
Modified: trunk/Source/WebKit/win/WebCoreSupport/WebInspectorClient.h (92299 => 92300)
--- trunk/Source/WebKit/win/WebCoreSupport/WebInspectorClient.h 2011-08-03 19:06:48 UTC (rev 92299)
+++ trunk/Source/WebKit/win/WebCoreSupport/WebInspectorClient.h 2011-08-03 19:09:34 UTC (rev 92300)
@@ -75,9 +75,6 @@
releaseFrontendPage();
}
- void saveSessionSetting(const WTF::String& key, const WTF::String& value);
- void loadSessionSetting(const WTF::String& key, WTF::String* value);
-
private:
virtual ~WebInspectorClient();
WTF::PassOwnPtr<WebCore::InspectorFrontendClientLocal::Settings> createFrontendSettings();
@@ -88,8 +85,6 @@
HWND m_frontendHwnd;
OwnPtr<WebNodeHighlight> m_highlight;
-
- WTF::HashMap<WTF::String, WTF::String> m_sessionSettings;
};
class WebInspectorFrontendClient : public WebCore::InspectorFrontendClientLocal, WebCore::WindowMessageListener {
@@ -112,9 +107,6 @@
virtual void setAttachedWindowHeight(unsigned height);
virtual void inspectedURLChanged(const WTF::String& newURL);
- virtual void saveSessionSetting(const WTF::String& key, const WTF::String& value);
- virtual void loadSessionSetting(const WTF::String& key, WTF::String* value);
-
private:
void closeWindowWithoutNotifications();
void showWindowWithoutNotifications();
