[webkit-changes] [92313] trunk/Source/WebCore

Wed, 03 Aug 2011 14:50:54 -0700

Title: [92313] trunk/Source/WebCore
Revision
92313
Author
[email protected]
Date
2011-08-03 14:50:48 -0700 (Wed, 03 Aug 2011)

Log Message

Remove LegacyDefaultOptionalArguments flag from DOMWindow.idl
https://bugs.webkit.org/show_bug.cgi?id=65353

Patch by Mark Pilgrim <[email protected]> on 2011-08-03
Reviewed by Adam Barth.

No new tests, all existing tests pass.

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateFunctionCallback):
* page/DOMWindow.idl:

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (92312 => 92313)


--- trunk/Source/WebCore/ChangeLog	2011-08-03 21:22:02 UTC (rev 92312)
+++ trunk/Source/WebCore/ChangeLog	2011-08-03 21:50:48 UTC (rev 92313)
@@ -1,3 +1,18 @@
+2011-08-03  Mark Pilgrim  <[email protected]>
+
+        Remove LegacyDefaultOptionalArguments flag from DOMWindow.idl
+        https://bugs.webkit.org/show_bug.cgi?id=65353
+
+        Reviewed by Adam Barth.
+
+        No new tests, all existing tests pass.
+
+        * bindings/scripts/CodeGeneratorJS.pm:
+        (GenerateImplementation):
+        * bindings/scripts/CodeGeneratorV8.pm:
+        (GenerateFunctionCallback):
+        * page/DOMWindow.idl:
+
 2011-08-03  Jeff Miller  <[email protected]>
 
         Fix Chromimum and Qt builds after r92308.

Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (92312 => 92313)


--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm	2011-08-03 21:22:02 UTC (rev 92312)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm	2011-08-03 21:50:48 UTC (rev 92313)
@@ -1976,11 +1976,11 @@
                 my $numParameters = @{$function->parameters};
 
                 my $requiresAllArguments;
-                if ($dataNode->extendedAttributes->{"LegacyDefaultOptionalArguments"}) {
-                    $requiresAllArguments = $function->signature->extendedAttributes->{"RequiresAllArguments"};
-                } else {
-                    $requiresAllArguments = "Raise";
+                my $requiresAllArgumentsDefault = "";
+                if (!$dataNode->extendedAttributes->{"LegacyDefaultOptionalArguments"}) {
+                    $requiresAllArgumentsDefault = "Raise";
                 }
+                $requiresAllArguments = $function->signature->extendedAttributes->{"RequiresAllArguments"} || $requiresAllArgumentsDefault;
                 if ($requiresAllArguments) {
                     my $numMandatoryParams = @{$function->parameters};
                     foreach my $param (reverse(@{$function->parameters})) {

Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm (92312 => 92313)


--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm	2011-08-03 21:22:02 UTC (rev 92312)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm	2011-08-03 21:50:48 UTC (rev 92313)
@@ -1248,11 +1248,11 @@
     my $numParameters = @{$function->parameters};
 
     my $requiresAllArguments;
-    if ($dataNode->extendedAttributes->{"LegacyDefaultOptionalArguments"}) {
-        $requiresAllArguments = $function->signature->extendedAttributes->{"RequiresAllArguments"};
-    } else {
-        $requiresAllArguments = "Raise";
+    my $requiresAllArgumentsDefault = "";
+    if (!$dataNode->extendedAttributes->{"LegacyDefaultOptionalArguments"}) {
+        $requiresAllArgumentsDefault = "Raise";
     }
+    $requiresAllArguments = $function->signature->extendedAttributes->{"RequiresAllArguments"} || $requiresAllArgumentsDefault;
     if ($requiresAllArguments) {
         my $numMandatoryParams = @{$function->parameters};
         foreach my $param (reverse(@{$function->parameters})) {

Modified: trunk/Source/WebCore/page/DOMWindow.idl (92312 => 92313)


--- trunk/Source/WebCore/page/DOMWindow.idl	2011-08-03 21:22:02 UTC (rev 92312)
+++ trunk/Source/WebCore/page/DOMWindow.idl	2011-08-03 21:50:48 UTC (rev 92313)
@@ -26,7 +26,6 @@
 module window {
 
     interface [
-        LegacyDefaultOptionalArguments,
         CheckDomainSecurity,
         CustomDefineGetter,
         CustomDefineSetter,
@@ -80,18 +79,18 @@
                                            in [Optional] DOMObject dialogArgs,
                                            in [Optional] DOMString featureArgs);
 
-        void alert(in DOMString message);
-        boolean confirm(in DOMString message);
-        [ConvertNullStringTo=Null] DOMString prompt(in DOMString message,
-                                                    in [ConvertUndefinedOrNullToNullString] DOMString defaultValue);
+        void alert(in [Optional=CallWithDefaultValue] DOMString message);
+        boolean confirm(in [Optional=CallWithDefaultValue] DOMString message);
+        [ConvertNullStringTo=Null] DOMString prompt(in [Optional=CallWithDefaultValue] DOMString message,
+                                                    in [ConvertUndefinedOrNullToNullString,Optional=CallWithDefaultValue] DOMString defaultValue);
 
-        boolean find(in DOMString string,
-                     in boolean caseSensitive,
-                     in boolean backwards,
-                     in boolean wrap,
-                     in boolean wholeWord,
-                     in boolean searchInFrames,
-                     in boolean showDialog);
+        boolean find(in [Optional=CallWithDefaultValue] DOMString string,
+                     in [Optional=CallWithDefaultValue] boolean caseSensitive,
+                     in [Optional=CallWithDefaultValue] boolean backwards,
+                     in [Optional=CallWithDefaultValue] boolean wrap,
+                     in [Optional=CallWithDefaultValue] boolean wholeWord,
+                     in [Optional=CallWithDefaultValue] boolean searchInFrames,
+                     in [Optional=CallWithDefaultValue] boolean showDialog);
 
         attribute [Replaceable] boolean offscreenBuffering;
 
@@ -148,25 +147,27 @@
         readonly attribute StyleMedia styleMedia;
 
         // DOM Level 2 Style Interface
-        CSSStyleDeclaration getComputedStyle(in Element element,
-                                             in [ConvertUndefinedOrNullToNullString] DOMString pseudoElement);
+        CSSStyleDeclaration getComputedStyle(in [Optional=CallWithDefaultValue] Element element,
+                                             in [ConvertUndefinedOrNullToNullString,Optional=CallWithDefaultValue] DOMString pseudoElement);
 
         // WebKit extensions
 #if defined(LANGUAGE_JAVASCRIPT) && LANGUAGE_JAVASCRIPT
-        CSSRuleList getMatchedCSSRules(in Element element,
-                                       in DOMString pseudoElement);
+        CSSRuleList getMatchedCSSRules(in [Optional=CallWithDefaultValue] Element element,
+                                       in [Optional=CallWithDefaultValue] DOMString pseudoElement);
 #endif
 
         attribute [Replaceable] double devicePixelRatio;
         
-        WebKitPoint webkitConvertPointFromPageToNode(in Node node, in WebKitPoint p);
-        WebKitPoint webkitConvertPointFromNodeToPage(in Node node, in WebKitPoint p);
+        WebKitPoint webkitConvertPointFromPageToNode(in [Optional=CallWithDefaultValue] Node node, 
+                                                     in [Optional=CallWithDefaultValue] WebKitPoint p);
+        WebKitPoint webkitConvertPointFromNodeToPage(in [Optional=CallWithDefaultValue] Node node, 
+                                                     in [Optional=CallWithDefaultValue] WebKitPoint p);
 
 #if defined(ENABLE_OFFLINE_WEB_APPLICATIONS) && ENABLE_OFFLINE_WEB_APPLICATIONS
         readonly attribute [EnabledAtRuntime] DOMApplicationCache applicationCache;
 #endif    
 #if defined(ENABLE_DATABASE) && ENABLE_DATABASE
-        [EnabledAtRuntime, RequiresAllArguments=Raise] Database openDatabase(in DOMString name, in DOMString version, in DOMString displayName, in unsigned long estimatedSize, in [Callback, Optional] DatabaseCallback creationCallback)
+        [EnabledAtRuntime] Database openDatabase(in DOMString name, in DOMString version, in DOMString displayName, in unsigned long estimatedSize, in [Callback, Optional] DatabaseCallback creationCallback)
             raises(DOMException);
 #endif
 #if defined(ENABLE_DOM_STORAGE) && ENABLE_DOM_STORAGE
@@ -225,14 +226,15 @@
 #endif
 
         // Timers
-        [Custom] long setTimeout(in TimeoutHandler handler, in long timeout);
+        [Custom] long setTimeout(in [Optional=CallWithDefaultValue] TimeoutHandler handler, 
+                                 in [Optional=CallWithDefaultValue] long timeout);
         // [Custom] long setTimeout(in TimeoutHandler handler, in long timeout, arguments...);
         // [Custom] long setTimeout(in DOMString code, in long timeout);
-        void clearTimeout(in long handle);
+        void clearTimeout(in [Optional=CallWithDefaultValue] long handle);
         [Custom] long setInterval(in TimeoutHandler handler, in long timeout);
         // [Custom] long setInterval(in TimeoutHandler handler, in long timeout, arguments...);
         // [Custom] long setInterval(in DOMString code, in long timeout);
-        void clearInterval(in long handle);
+        void clearInterval(in [Optional=CallWithDefaultValue] long handle);
 
 #if defined(ENABLE_REQUEST_ANIMATION_FRAME)
         // WebKit animation extensions
@@ -241,9 +243,9 @@
 #endif
 
         // Base64
-        DOMString atob(in [ConvertNullToNullString] DOMString string)
+        DOMString atob(in [ConvertNullToNullString,Optional=CallWithDefaultValue] DOMString string)
             raises(DOMException);
-        DOMString btoa(in [ConvertNullToNullString] DOMString string)
+        DOMString btoa(in [ConvertNullToNullString,Optional=CallWithDefaultValue] DOMString string)
             raises(DOMException);
 
         // Events

_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to