Title: [92316] trunk/Source/WebCore
- Revision
- 92316
- Author
- [email protected]
- Date
- 2011-08-03 15:24:13 -0700 (Wed, 03 Aug 2011)
Log Message
Chromium Mac: Make sure scrollbars flash when web page loads
https://bugs.webkit.org/show_bug.cgi?id=65586
On slow web pages scrollbars wouldn't flash when the page was done loading. The problem was that we were flashing the scrollbar 0.1 second after the load operation had started. If the page was slow to load then we might not have scrollbars to flash. To work around this I added an extra check to make sure that we had indeed finished loading the page before flashing the scrollbars.
Patch by Sailesh Agrawal <[email protected]> on 2011-08-03
Reviewed by James Robinson.
* platform/chromium/ScrollAnimatorChromiumMac.mm:
(WebCore::ScrollAnimatorChromiumMac::initialScrollbarPaintTimerFired):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (92315 => 92316)
--- trunk/Source/WebCore/ChangeLog 2011-08-03 21:58:44 UTC (rev 92315)
+++ trunk/Source/WebCore/ChangeLog 2011-08-03 22:24:13 UTC (rev 92316)
@@ -1,3 +1,15 @@
+2011-08-03 Sailesh Agrawal <[email protected]>
+
+ Chromium Mac: Make sure scrollbars flash when web page loads
+ https://bugs.webkit.org/show_bug.cgi?id=65586
+
+ On slow web pages scrollbars wouldn't flash when the page was done loading. The problem was that we were flashing the scrollbar 0.1 second after the load operation had started. If the page was slow to load then we might not have scrollbars to flash. To work around this I added an extra check to make sure that we had indeed finished loading the page before flashing the scrollbars.
+
+ Reviewed by James Robinson.
+
+ * platform/chromium/ScrollAnimatorChromiumMac.mm:
+ (WebCore::ScrollAnimatorChromiumMac::initialScrollbarPaintTimerFired):
+
2011-08-03 Mark Pilgrim <[email protected]>
Remove LegacyDefaultOptionalArguments flag from navigator IDL files
Modified: trunk/Source/WebCore/platform/chromium/ScrollAnimatorChromiumMac.mm (92315 => 92316)
--- trunk/Source/WebCore/platform/chromium/ScrollAnimatorChromiumMac.mm 2011-08-03 21:58:44 UTC (rev 92315)
+++ trunk/Source/WebCore/platform/chromium/ScrollAnimatorChromiumMac.mm 2011-08-03 22:24:13 UTC (rev 92316)
@@ -1289,7 +1289,10 @@
void ScrollAnimatorChromiumMac::initialScrollbarPaintTimerFired(Timer<ScrollAnimatorChromiumMac>*)
{
- wkScrollbarPainterForceFlashScrollers(m_scrollbarPainterController.get());
+ if (scrollableArea()->shouldSuspendScrollAnimations())
+ startScrollbarPaintTimer();
+ else
+ wkScrollbarPainterForceFlashScrollers(m_scrollbarPainterController.get());
}
#endif
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
