Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js (92395 => 92396)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js 2011-08-04 19:11:13 UTC (rev 92395)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js 2011-08-04 19:19:23 UTC (rev 92396)
@@ -29,30 +29,11 @@
var kWebKitTrunk = 'http://svn.webkit.org/repository/webkit/trunk/';
-function subversionURLAtRevision(subversionURL, revision)
-{
- return subversionURL + '?r=' + revision;
-}
-
checkout.subversionURLForTest = function(testName)
{
return kWebKitTrunk + 'LayoutTests/' + testName;
}
-checkout.existsAtRevision = function(subversionURL, revision, callback)
-{
- net.ajax({
- method: 'HEAD',
- url: subversionURLAtRevision(subversionURL, revision),
- success: function() {
- callback(true);
- },
- error: function() {
- callback(false);
- }
- });
-};
-
checkout.updateExpectations = function(failureInfoList, callback)
{
net.post('/updateexpectations', JSON.stringify(failureInfoList), function() {
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js (92395 => 92396)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js 2011-08-04 19:11:13 UTC (rev 92395)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js 2011-08-04 19:19:23 UTC (rev 92396)
@@ -31,4 +31,77 @@
equals(checkout.subversionURLForTest("path/to/test.html"), "http://svn.webkit.org/repository/webkit/trunk/LayoutTests/path/to/test.html");
});
+test("updateExpectations", 4, function() {
+ var simulator = new NetworkSimulator();
+ simulator.post = function(url, data, callback)
+ {
+ equals(url, '/updateexpectations');
+ equals(data, '[{"builderName":"WebKit Linux","testName":"another/test.svg","failureTypeList":["IMAGE"]}]');
+ simulator.scheduleCallback(callback);
+ };
+
+ simulator.runTest(function() {
+ checkout.updateExpectations([{
+ 'builderName': 'WebKit Linux',
+ 'testName': 'another/test.svg',
+ 'failureTypeList': ['IMAGE'],
+ }], function() {
+ ok(true);
+ });
+ });
+});
+
+test("optimizeBaselines", 3, function() {
+ var simulator = new NetworkSimulator();
+ simulator.post = function(url, callback)
+ {
+ equals(url, '/optimizebaselines?test=another%2Ftest.svg');
+ simulator.scheduleCallback(callback);
+ };
+
+ simulator.runTest(function() {
+ checkout.optimizeBaselines('another/test.svg', function() {
+ ok(true);
+ });
+ });
+});
+
+test("rebaseline", 3, function() {
+ var simulator = new NetworkSimulator();
+
+ var requestedURLs = [];
+ simulator.post = function(url, callback)
+ {
+ requestedURLs.push(url);
+ simulator.scheduleCallback(callback);
+ };
+
+ simulator.runTest(function() {
+ checkout.rebaseline([{
+ 'builderName': 'WebKit Linux',
+ 'testName': 'another/test.svg',
+ 'failureTypeList': ['IMAGE'],
+ }, {
+ 'builderName': 'WebKit Mac10.6',
+ 'testName': 'another/test.svg',
+ 'failureTypeList': ['IMAGE+TEXT'],
+ }, {
+ 'builderName': 'Webkit Vista',
+ 'testName': 'fast/test.html',
+ 'failureTypeList': ['TEXT'],
+ }], function() {
+ ok(true);
+ });
+ });
+
+ deepEqual(requestedURLs, [
+ "/rebaseline?builder=WebKit+Linux&test=another%2Ftest.svg&extension=png",
+ "/rebaseline?builder=WebKit+Mac10.6&test=another%2Ftest.svg&extension=txt",
+ "/rebaseline?builder=WebKit+Mac10.6&test=another%2Ftest.svg&extension=png",
+ "/rebaseline?builder=Webkit+Vista&test=fast%2Ftest.html&extension=txt",
+ "/optimizebaselines?test=another%2Ftest.svg",
+ "/optimizebaselines?test=fast%2Ftest.html"
+ ]);
+});
+
})();
Modified: trunk/Tools/ChangeLog (92395 => 92396)
--- trunk/Tools/ChangeLog 2011-08-04 19:11:13 UTC (rev 92395)
+++ trunk/Tools/ChangeLog 2011-08-04 19:19:23 UTC (rev 92396)
@@ -1,3 +1,15 @@
+2011-08-04 Adam Barth <[email protected]>
+
+ checkout_unittest.js should have better coverage of checkout.js
+ https://bugs.webkit.org/show_bug.cgi?id=65671
+
+ Reviewed by Dimitri Glazkov.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
+ - Remove unused functions.
+ * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js:
+ - Test remaining public functions in the checkout module.
+
2011-08-04 Dmitry Lomov <[email protected]>
https://bugs.webkit.org/show_bug.cgi?id=65706
