Title: [92406] trunk/Source/WebCore
Revision
92406
Author
[email protected]
Date
2011-08-04 13:14:37 -0700 (Thu, 04 Aug 2011)

Log Message

<rdar://problem/9882581>, <rdar://problem/9868015>, and https://bugs.webkit.org/show_bug.cgi?id=65712
REGRESSION (91931) - Two LocalStorage threads started, thread unsafe operations can cause crash or other problems later.

Reviewed by Darin Adler.

* storage/StorageTracker.cpp:
(WebCore::StorageTracker::internalInitialize): Set the "needs initialization" flag before doing a 
  whole bunch of stuff that might need to check it.

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (92405 => 92406)


--- trunk/Source/WebCore/ChangeLog	2011-08-04 20:09:18 UTC (rev 92405)
+++ trunk/Source/WebCore/ChangeLog	2011-08-04 20:14:37 UTC (rev 92406)
@@ -1,3 +1,14 @@
+2011-08-04  Brady Eidson  <[email protected]>
+
+        <rdar://problem/9882581>, <rdar://problem/9868015>, and https://bugs.webkit.org/show_bug.cgi?id=65712
+        REGRESSION (91931) - Two LocalStorage threads started, thread unsafe operations can cause crash or other problems later.
+
+        Reviewed by Darin Adler.
+
+        * storage/StorageTracker.cpp:
+        (WebCore::StorageTracker::internalInitialize): Set the "needs initialization" flag before doing a 
+          whole bunch of stuff that might need to check it.
+
 2011-08-04  Jeff Miller  <[email protected]>
 
         Adopt AVCF media back end on Windows

Modified: trunk/Source/WebCore/storage/StorageTracker.cpp (92405 => 92406)


--- trunk/Source/WebCore/storage/StorageTracker.cpp	2011-08-04 20:09:18 UTC (rev 92405)
+++ trunk/Source/WebCore/storage/StorageTracker.cpp	2011-08-04 20:14:37 UTC (rev 92406)
@@ -62,6 +62,8 @@
 
 void StorageTracker::internalInitialize()
 {
+    m_needsInitialization = false;
+
     ASSERT(isMainThread());
 
     // Make sure text encoding maps have been built on the main thread, as the StorageTracker thread might try to do it there instead.
@@ -72,8 +74,6 @@
     storageTracker->setIsActive(true);
     storageTracker->m_thread->start();  
     storageTracker->importOriginIdentifiers();
-    
-    m_needsInitialization = false;
 }
 
 StorageTracker& StorageTracker::tracker()
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to