Title: [92541] trunk/Source/WebCore
Revision
92541
Author
[email protected]
Date
2011-08-05 19:25:57 -0700 (Fri, 05 Aug 2011)

Log Message

https://bugs.webkit.org/show_bug.cgi?id=64613
Use supported framebuffer renderbuffer mode; chromium command buffer
allows DEPTH and STENCIL but not DEPTH_STENCIL.

Patch by Tom Hudson <[email protected]> on 2011-08-05
Reviewed by James Robinson.

No new tests because was caught by extant tests, albeit only when
accelerated drawing and forced compositing were both turned on.

* platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp:
(WebCore::LayerTextureUpdaterSkPicture::createFrameBuffer):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (92540 => 92541)


--- trunk/Source/WebCore/ChangeLog	2011-08-06 02:17:55 UTC (rev 92540)
+++ trunk/Source/WebCore/ChangeLog	2011-08-06 02:25:57 UTC (rev 92541)
@@ -1,3 +1,17 @@
+2011-08-05  Tom Hudson  <[email protected]>
+
+        https://bugs.webkit.org/show_bug.cgi?id=64613
+        Use supported framebuffer renderbuffer mode; chromium command buffer
+        allows DEPTH and STENCIL but not DEPTH_STENCIL.
+
+        Reviewed by James Robinson.
+
+        No new tests because was caught by extant tests, albeit only when
+        accelerated drawing and forced compositing were both turned on.
+
+        * platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp:
+        (WebCore::LayerTextureUpdaterSkPicture::createFrameBuffer):
+
 2011-08-05  Anna Cavender  <[email protected]>
 
         Adding a WebVTTParser for <track>.

Modified: trunk/Source/WebCore/platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp (92540 => 92541)


--- trunk/Source/WebCore/platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp	2011-08-06 02:17:55 UTC (rev 92540)
+++ trunk/Source/WebCore/platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp	2011-08-06 02:25:57 UTC (rev 92541)
@@ -229,7 +229,8 @@
     }
     context()->bindRenderbuffer(GraphicsContext3D::RENDERBUFFER, m_depthStencilBuffer);
     context()->renderbufferStorage(GraphicsContext3D::RENDERBUFFER, Extensions3D::DEPTH24_STENCIL8, m_bufferSize.width(), m_bufferSize.height());
-    context()->framebufferRenderbuffer(GraphicsContext3D::FRAMEBUFFER, GraphicsContext3D::DEPTH_STENCIL_ATTACHMENT, GraphicsContext3D::RENDERBUFFER, m_depthStencilBuffer);
+    context()->framebufferRenderbuffer(GraphicsContext3D::FRAMEBUFFER, GraphicsContext3D::DEPTH_ATTACHMENT, GraphicsContext3D::RENDERBUFFER, m_depthStencilBuffer);
+    context()->framebufferRenderbuffer(GraphicsContext3D::FRAMEBUFFER, GraphicsContext3D::STENCIL_ATTACHMENT, GraphicsContext3D::RENDERBUFFER, m_depthStencilBuffer);
 
     // Create a skia gpu canvas.
     GrPlatformSurfaceDesc targetDesc;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to