Title: [92568] trunk/Source/WebKit2
Revision
92568
Author
[email protected]
Date
2011-08-06 18:09:23 -0700 (Sat, 06 Aug 2011)

Log Message

Fix a memory leak found via code inspection.

Rubber-stamped by Dan Bernstein.

* WebProcess/Downloads/mac/DownloadMac.mm:
(WebKit::setOriginalURLForDownload): Adopt the newly-allocated NSURL instance
so that it does not leak.

Modified Paths

Diff

Modified: trunk/Source/WebKit2/ChangeLog (92567 => 92568)


--- trunk/Source/WebKit2/ChangeLog	2011-08-07 01:09:06 UTC (rev 92567)
+++ trunk/Source/WebKit2/ChangeLog	2011-08-07 01:09:23 UTC (rev 92568)
@@ -1,3 +1,13 @@
+2011-08-06  Mark Rowe  <[email protected]>
+
+        Fix a memory leak found via code inspection.
+
+        Rubber-stamped by Dan Bernstein.
+
+        * WebProcess/Downloads/mac/DownloadMac.mm:
+        (WebKit::setOriginalURLForDownload): Adopt the newly-allocated NSURL instance
+        so that it does not leak.
+
 2011-08-06  Aron Rosenberg  <[email protected]>
 
         Reviewed by Benjamin Poulain.

Modified: trunk/Source/WebKit2/WebProcess/Downloads/mac/DownloadMac.mm (92567 => 92568)


--- trunk/Source/WebKit2/WebProcess/Downloads/mac/DownloadMac.mm	2011-08-07 01:09:06 UTC (rev 92567)
+++ trunk/Source/WebKit2/WebProcess/Downloads/mac/DownloadMac.mm	2011-08-07 01:09:23 UTC (rev 92568)
@@ -110,7 +110,7 @@
         else
             hostOnlyURLString.adoptNS([[NSString alloc] initWithFormat:@"%@://%@", scheme, host]);
 
-        RetainPtr<NSURL> hostOnlyURL = [[NSURL alloc] initWithString:hostOnlyURLString.get()];
+        RetainPtr<NSURL> hostOnlyURL(AdoptNS, [[NSURL alloc] initWithString:hostOnlyURLString.get()]);
 
         ASSERT([download respondsToSelector:@selector(_setOriginatingURL:)]);
         [download _setOriginatingURL:hostOnlyURL.get()];
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to